MantisBT - Community
View Issue Details
0029409Community[OCCT] OCCT:Configurationpublic2018-01-01 17:102018-06-29 21:19
abv 
apn 
normaltrivial 
closedfixed 
 
[OCCT] 7.3.0[OCCT] 7.3.0 
Not needed
0029409: Configuration, macOS - "AppKit" is spelled in CMake scripts using wrong case for "K"
The following problem has been reported by external user:

~~~~~
The cmake scripts fail to build on case-senstive macOS file systems because Appkit, should be AppKit. Here is a patch against the V7_2_0 tag that solves the problem:

diff --git a/adm/cmake/occt_csf.cmake b/adm/cmake/occt_csf.cmake
index c62425d..0e2db4e 100644
--- a/adm/cmake/occt_csf.cmake
+++ b/adm/cmake/occt_csf.cmake
@@ -85,7 +85,7 @@ if (WIN32)
     set (CSF_objc "objc")

 
     # frameworks
- find_library (Appkit_LIB NAMES Appkit)
+ find_library (Appkit_LIB NAMES AppKit)
     set (CSF_Appkit ${Appkit_LIB})

 
     find_library (IOKit_LIB NAMES IOKit)

~~~~~
Build OCCT on macOS with case sensitive file system (HDD formatted as "Mac OS Extended (Case-sensitive)")
No tags attached.
Issue History
2018-01-01 17:10abvNew Issue
2018-01-01 17:10abvAssigned To => bugmaster
2018-01-02 14:03gitNote Added: 0073219
2018-01-02 14:06abvNote Added: 0073220
2018-01-02 14:06abvStatusnew => resolved
2018-01-02 14:06abvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18409#r18409
2018-01-09 10:05kgvNote Added: 0073258
2018-01-09 10:05kgvAssigned Tobugmaster => abv
2018-01-09 10:05kgvSeverityminor => trivial
2018-01-09 10:05kgvStatusresolved => feedback
2018-01-10 23:08gitNote Added: 0073300
2018-01-10 23:32abvNote Added: 0073301
2018-01-10 23:32abvAssigned Toabv => kgv
2018-01-10 23:32abvStatusfeedback => resolved
2018-01-11 09:34kgvNote Added: 0073303
2018-01-11 09:34kgvAssigned Tokgv => bugmaster
2018-01-11 09:34kgvStatusresolved => reviewed
2018-01-11 10:05kgvSummaryConfiguration, macOS - "Appkit" is spelled in CMake scripts using wrong case for "K" => Configuration, macOS - "AppKit" is spelled in CMake scripts using wrong case for "K"
2018-01-11 11:22apnTest case number => Not needed
2018-01-11 11:22apnNote Added: 0073347
2018-01-11 11:22apnStatusreviewed => tested
2018-01-13 15:26apnChangeset attached => occt master 2c3f1a57
2018-01-13 15:26apnAssigned Tobugmaster => apn
2018-01-13 15:26apnStatustested => verified
2018-01-13 15:26apnResolutionopen => fixed
2018-02-05 11:39gitNote Added: 0073775
2018-06-29 21:15aivFixed in Version => 7.3.0
2018-06-29 21:19aivStatusverified => closed

Notes
(0073219)
git   
2018-01-02 14:03   
Branch CR29409 has been created by abv.

SHA-1: 7133469631050b3d9da98a4c4122d35222b1393f


Detailed log of new commits:

Author: abv
Date: Tue Jan 2 14:03:16 2018 +0300

    0029409: Configuration, macOS - "Appkit" is spelled in CMake scripts using wrong case for "K"
    
    Spelling error is corrected in name of AppKit library in CMake scripts for macOS
(0073220)
abv   
2018-01-02 14:06   
I have pushed correction, please test if possible
(0073258)
kgv   
2018-01-09 10:05   
The patch is incomplete - the misprint is originating from genproj.tcl, where framework is still misspelled.
(0073300)
git   
2018-01-10 23:08   
Branch CR29409 has been updated forcibly by abv.

SHA-1: 29e9b9067061fa33977d917be7a3afe9b75d415a
(0073301)
abv   
2018-01-10 23:32   
Corrected (in the same branch), please review
(0073303)
kgv   
2018-01-11 09:34   
Please test the patch (regression testing is not needed - see abv comment).
(0073347)
apn   
2018-01-11 11:22   
Combination -
OCCT branch : CR29409 SHA - 29e9b9067061fa33977d917be7a3afe9b75d415a
Products branch : master SHA - c667ca9e3bc920614b06911e337a09899f80aa2f
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings
(0073775)
git   
2018-02-05 11:39   
Branch CR29409 has been deleted by kgv.

SHA-1: 29e9b9067061fa33977d917be7a3afe9b75d415a