MantisBT - Open CASCADE
View Issue Details
0029331Open CASCADE[OCCT] OCCT:Visualizationpublic2017-11-16 22:562018-06-29 21:19
kgv 
kgv 
normalintegration request 
closedfixed 
 
[OCCT] 7.3.0[OCCT] 7.3.0 
Not required
0029331: Visualization, TKOpenGl - make OpenGl_PrimitiveArray::IsFillDrawMode() as virtual method of OpenGl_Element
According to profiling data, dynamic_cast increases overhead of OpenGl_LayerList::OpenGl_OpaqueFilter::ShouldRender() considerably (ShouldRender() make take up to 5% of CPU time in the frame in case of a big amount of elements).

Thus, it is proposed moving OpenGl_PrimitiveArray::IsFillDrawMode() method to interface of base OpenGl_Element class.
N/A
No tags attached.
Issue History
2017-11-16 22:56kgvNew Issue
2017-11-16 22:56kgvAssigned To => kgv
2017-11-16 22:59kgvDescription Updatedbug_revision_view_page.php?rev_id=18173#r18173
2017-11-16 23:00gitNote Added: 0072301
2017-11-16 23:35gitNote Added: 0072303
2017-11-17 02:06kgvNote Added: 0072304
2017-11-17 02:06kgvAssigned Tokgv => san
2017-11-17 02:06kgvStatusnew => resolved
2017-11-29 19:21sanNote Added: 0072597
2017-11-29 19:21sanAssigned Tosan => bugmaster
2017-11-29 19:21sanStatusresolved => reviewed
2017-11-30 11:00bugmasterTest case number => Not required
2017-11-30 11:00bugmasterNote Added: 0072610
2017-11-30 11:00bugmasterStatusreviewed => tested
2017-12-02 16:59kgvChangeset attached => occt master 64c6d8df
2017-12-02 16:59kgvAssigned Tobugmaster => kgv
2017-12-02 16:59kgvStatustested => verified
2017-12-02 16:59kgvResolutionopen => fixed
2017-12-07 21:08gitNote Added: 0072820
2018-02-20 12:58aivTarget Version7.4.0* => 7.3.0
2018-06-29 21:15aivFixed in Version => 7.3.0
2018-06-29 21:19aivStatusverified => closed

Notes
(0072301)
git   
2017-11-16 23:00   
Branch CR29331 has been created by kgv.

SHA-1: fc91751066787e245427af6bf306e6868e0c5aa1


Detailed log of new commits:

Author: kgv
Date: Thu Nov 16 22:57:48 2017 +0300

    0029331: Visualization, TKOpenGl - make OpenGl_PrimitiveArray::IsFillDrawMode() as virtual method of OpenGl_Element
(0072303)
git   
2017-11-16 23:35   
Branch CR29331 has been updated forcibly by kgv.

SHA-1: 4e09793d16d1439de01678b5efcb23326a2f6b6e
(0072304)
kgv   
2017-11-17 02:06   
Patch is ready for review.
(0072597)
san   
2017-11-29 19:21   
Branch CR29331 reviewed without remarks, ready for testing.
(0072610)
bugmaster   
2017-11-30 11:00   
Combination -
OCCT branch : CR29331 SHA - 4e09793d16d1439de01678b5efcb23326a2f6b6e
Products branch : master SHA - f67feaac4198a68556ed91368fbdc40829907d00
was compiled on Linux, MacOS and Windows platforms and tested on optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 20669.63000000052 / 20769.880000000467 [-0.48%]
Products
Total CPU difference: 7851.580000000089 / 7901.260000000098 [-0.63%]
Windows-64-VC10:
OCCT
Total CPU difference: 18476.35283739856 / 18481.95327329852 [-0.03%]
Products
Total CPU difference: 7857.037165299989 / 7874.587277799976 [-0.22%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0072820)
git   
2017-12-07 21:08   
Branch CR29331 has been deleted by kgv.

SHA-1: 4e09793d16d1439de01678b5efcb23326a2f6b6e