MantisBT - Open CASCADE
View Issue Details
0029214Open CASCADE[OCCT] OCCT:Application Frameworkpublic2017-10-12 11:302018-06-29 21:19
kgv 
bugmaster 
normalminor 
closedfixed 
[OCCT] 5.2.2 
[OCCT] 7.3.0[OCCT] 7.3.0 
Not required
0029214: Application Framework - TPrsStd_AISPresentation::AISUpdate() should not implicitly redraw 3D Viewer
All places within TPrsStd_AISPresentation::AISUpdate() modify presentation without redrawing 3D Viewer, except one place:
void TPrsStd_AISPresentation::AISUpdate()
{
  ...
  aContext->Remove (myAIS, Standard_True);


This makes XShow command executing ages on big model due to viewer redraw on each root in the Document.

It looks like a bug in TPrsStd_AISPresentation::AISUpdate() implementation.
N/A
No tags attached.
child of 0028088closed kgv Visualization, AIS_InteractiveContext - drop default value for Update Viewer parameter 
Issue History
2017-10-12 11:30kgvNew Issue
2017-10-12 11:30kgvAssigned To => mpv
2017-10-12 11:32gitNote Added: 0071362
2017-10-12 11:32kgvNote Added: 0071363
2017-10-12 11:32kgvStatusnew => resolved
2017-10-12 11:34kgvProduct Version7.2.0 => 5.2.2
2017-10-16 09:40mpvAssigned Tompv => vro
2017-10-16 09:41mpvNote Added: 0071510
2017-10-16 10:10vroNote Added: 0071513
2017-10-16 10:10vroAssigned Tovro => bugmaster
2017-10-16 10:10vroStatusresolved => reviewed
2017-10-16 15:06bugmasterTest case number => Not required
2017-10-16 15:08bugmasterNote Added: 0071538
2017-10-16 15:08bugmasterStatusreviewed => tested
2017-10-27 09:54bugmasterChangeset attached => occt master f6c2b39a
2017-10-27 09:54bugmasterStatustested => verified
2017-10-27 09:54bugmasterResolutionopen => fixed
2017-11-02 09:56kgvRelationship addedchild of 0028088
2017-11-08 18:24gitNote Added: 0072071
2018-02-17 19:03abvTarget Version7.4.0* => 7.3.0
2018-06-29 21:15aivFixed in Version => 7.3.0
2018-06-29 21:19aivStatusverified => closed

Notes
(0071362)
git   
2017-10-12 11:32   
Branch CR29214 has been created by kgv.

SHA-1: fabb900c5e58b858fc889fcbda7decd9b78008fe


Detailed log of new commits:

Author: kgv
Date: Thu Oct 12 11:31:41 2017 +0300

    0029214: Application Framework - TPrsStd_AISPresentation::AISUpdate() should not implicitly redraw 3D Viewer
(0071363)
kgv   
2017-10-12 11:32   
Patch is ready for review.
(0071510)
mpv   
2017-10-16 09:41   
Dear VRO,

Could you review this fix, since you have wider experience of working with AIS.
(0071513)
vro   
2017-10-16 10:10   
I agree, it was a mistake to redraw the view on AISUpdate().
(0071538)
bugmaster   
2017-10-16 15:08   
Combination -
OCCT branch : CR29214 SHA-1: fabb900c5e58b858fc889fcbda7decd9b78008fe
Products branch : master
was compiled on Linux, MacOS and Windows platforms and tested on optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
No differences that require special attention

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0072071)
git   
2017-11-08 18:24   
Branch CR29214 has been deleted by kgv.

SHA-1: fabb900c5e58b858fc889fcbda7decd9b78008fe