MantisBT - Open CASCADE
View Issue Details
0029169Open CASCADE[OCCT] OCCT:Configurationpublic2017-09-30 19:462018-06-29 21:19
kgv 
bugmaster 
lowminor 
closedfixed 
[OCCT] 7.2.0 
[OCCT] 7.3.0[OCCT] 7.3.0 
Not required
0029169: Configuration - fix compilation with undefined UNICODE on Windows
OCCT is expected to be compiled with UNICODE macros on Windows, however in some cases it can be undefined leading to compilation errors.
0. Install Code::Blocks with MinGW
1. Generate Code::Blocks project on Windows running "genproj cbp"
2. Start codeblocks.bat
3. Build TKernel
No tags attached.
child of 0028110closed apn Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio 
Issue History
2017-09-30 19:46kgvNew Issue
2017-09-30 19:46kgvAssigned To => kgv
2017-09-30 19:52gitNote Added: 0071084
2017-09-30 19:52kgvNote Added: 0071085
2017-09-30 19:52kgvAssigned Tokgv => abv
2017-09-30 19:52kgvPrioritynormal => low
2017-09-30 19:52kgvStatusnew => resolved
2017-09-30 19:53kgvRelationship addedchild of 0028110
2017-10-01 13:53abvNote Added: 0071091
2017-10-01 13:53abvStatusresolved => reviewed
2017-10-01 13:53abvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17786#r17786
2017-10-01 13:53abvTarget Version7.4.0 => 7.3.0
2017-10-01 21:13gitNote Added: 0071100
2017-10-01 22:07gitNote Added: 0071103
2017-10-03 09:42bugmasterNote Added: 0071137
2017-10-03 09:42bugmasterStatusreviewed => tested
2017-10-03 09:52bugmasterTest case number => Not required
2017-10-06 14:55bugmasterChangeset attached => occt master c85a994a
2017-10-06 14:55bugmasterAssigned Toabv => bugmaster
2017-10-06 14:55bugmasterStatustested => verified
2017-10-06 14:55bugmasterResolutionopen => fixed
2017-10-14 12:20gitNote Added: 0071475
2018-06-29 21:15aivFixed in Version => 7.3.0
2018-06-29 21:19aivStatusverified => closed

Notes
(0071084)
git   
2017-09-30 19:52   
Branch CR29169 has been created by kgv.

SHA-1: a783861e304be3bfe73bba36b2d89a89a6540944


Detailed log of new commits:

Author: kgv
Date: Sat Sep 30 19:52:10 2017 +0300

    0029169: Configuration - fix compilation with undefined UNICODE on Windows
    
    Eliminated usage of TEXT macros, usage of OSVERSIONINFO instead of OSVERSIONINFOW.
    LoadIcon/LoadCursor are now used instead of LoadIconW/LoadCursorW
    when passing macros to standard resources (which depend on UNICODE flag).
(0071085)
kgv   
2017-09-30 19:52   
Patch is ready for review.
(0071091)
abv   
2017-10-01 13:53   
Reviewed with no remarks
(0071100)
git   
2017-10-01 21:13   
Branch CR29169 has been updated forcibly by abv.

SHA-1: d6b241ef46f85ac731a033c1cad43bd28f4b52a6
(0071103)
git   
2017-10-01 22:07   
Branch CR29169 has been updated forcibly by abv.

SHA-1: 2bd1ffe4423029fe3b0a6808e298ca37e60b8a68
(0071137)
bugmaster   
2017-10-03 09:42   
Tested in framework of testing issue 29170
(0071475)
git   
2017-10-14 12:20   
Branch CR29169 has been deleted by kgv.

SHA-1: 2bd1ffe4423029fe3b0a6808e298ca37e60b8a68