MantisBT - Open CASCADE
View Issue Details
0029158Open CASCADE[OCCT] OCCT:Visualizationpublic2017-09-29 09:192018-06-29 21:19
abv 
bugmaster 
normalminor 
closedfixed 
[OCCT] 7.0.0 
[OCCT] 7.3.0[OCCT] 7.3.0 
Not required
0029158: Visualization - suspicious pass-through of case labels in switch statements
GCC 7.1 reports multiple warnings "this statement may fall through [-Wimplicit-fallthrough=]" in situations when code can pass through the case label of switch statement (i.e. code of the preceding case label does not leave the switch using break, return etc.). Some of such warnings highlight suspicious places in the code:

MeshVS_Mesh.cxx:422

If fall-through is intentional, add macro Standard_FALLTHROUGH (introduced in 0029151) before the case label to avoid this warning.
No tags attached.
child of 0029151closed abv Open CASCADE Coding Rules - eliminate GCC compiler warnings -Wimplicit-fallthrough 
Issue History
2017-09-29 09:19abvNew Issue
2017-09-29 09:19abvAssigned To => kgv
2017-09-29 09:20abvRelationship addedchild of 0029151
2017-09-29 09:21abvDescription Updatedbug_revision_view_page.php?rev_id=17758#r17758
2017-09-29 14:29abvSummary0029157: Visualization - suspicious pass-through of case labels in switch statements => Visualization - suspicious pass-through of case labels in switch statements
2017-10-04 20:09gitNote Added: 0071209
2017-10-04 20:11kgvRelationship addedchild of 0027180
2017-10-04 20:11kgvProduct Version => 7.0.0
2017-10-04 21:34gitNote Added: 0071211
2017-10-04 22:22gitNote Added: 0071218
2017-10-04 23:01kgvNote Added: 0071220
2017-10-04 23:01kgvAssigned Tokgv => san
2017-10-04 23:01kgvStatusnew => resolved
2017-10-08 22:02sanNote Added: 0071284
2017-10-08 22:02sanAssigned Tosan => bugmaster
2017-10-08 22:02sanStatusresolved => reviewed
2017-10-09 10:39bugmasterTest case number => Not required
2017-10-09 10:46bugmasterNote Added: 0071292
2017-10-09 10:46bugmasterStatusreviewed => tested
2017-10-12 19:00bugmasterChangeset attached => occt master 022d142b
2017-10-12 19:00bugmasterStatustested => verified
2017-10-12 19:00bugmasterResolutionopen => fixed
2017-10-14 12:20gitNote Added: 0071469
2018-06-29 21:15aivFixed in Version => 7.3.0
2018-06-29 21:19aivStatusverified => closed

Notes
(0071209)
git   
2017-10-04 20:09   
Branch CR29158 has been created by kgv.

SHA-1: 5e36fa598035021e86e8daf5c69c01f538bf466b


Detailed log of new commits:

Author: Zia ul Azam
Date: Wed Sep 13 17:12:57 2017 +0200

    0029158: Visualization - suspicious pass-through of case labels in switch statements
    
    MeshVS_Mesh::ComputeSelection() - fixed incorrect fall-through
    from MeshVS_SMF_Mesh to MeshVS_SMF_Group.
(0071211)
git   
2017-10-04 21:34   
Branch CR29158 has been updated forcibly by kgv.

SHA-1: 762e93d32b27600b1c0aa13dea1b56461b7604a7
(0071218)
git   
2017-10-04 22:22   
Branch CR29158 has been updated forcibly by kgv.

SHA-1: 0394d954e9912d3429bbb4d6cd532833b6f93e3d
(0071220)
kgv   
2017-10-04 23:01   
Patch is ready for review.

http://jenkins-test-10.nnov.opencascade.com/view/CR29158-master-KGV [^]
(0071284)
san   
2017-10-08 22:02   
Branch CR29158 reviewed without remarks, ready for testing.
(0071292)
bugmaster   
2017-10-09 10:46   
Combination -
OCCT branch :CR29158 SHA-1: 0394d954e9912d3429bbb4d6cd532833b6f93e3d
Products branch : master
was compiled on Linux, MacOS and Windows platforms and tested on optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
No differences that require special attention

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0071469)
git   
2017-10-14 12:20   
Branch CR29158 has been deleted by kgv.

SHA-1: 0394d954e9912d3429bbb4d6cd532833b6f93e3d