MantisBT - Community
View Issue Details
0029109Community[OCCT] OCCT:Visualizationpublic2017-09-13 17:552018-06-29 21:19
ziaulazam 
bugmaster 
normalfeature 
closedfixed 
MinGW-w64Windows7
 
[OCCT] 7.3.0[OCCT] 7.3.0 
Not required
0029109: Visualization, AIS_Trihedron - add option hiding arrows tips
Visualization gets slower if many AIS_Trihedron(s) are rendered at the same time in the visualization window.

The visualization can be optimized by providing a possibility to switch off the visualization of arrows if many AIS_Trihedron(s) are to be rendered.

Therefore, a public method can be provided to the users of class to toggle the visualization of arrows according to the application use case.
Not Required
No tags attached.
parent of 0029414closed bugmaster Coding Rules - remove duplicate methods in class Prs3d_DatumAspect 
png occ_trihedrons.png (6,351) 2017-10-04 13:57
https://tracker.dev.opencascade.org/
Issue History
2017-09-13 17:55ziaulazamNew Issue
2017-09-13 17:55ziaulazamAssigned To => kgv
2017-09-13 18:16gitNote Added: 0070511
2017-09-14 09:11kgvNote Added: 0070518
2017-09-15 15:32gitNote Added: 0070591
2017-09-15 16:18ziaulazamNote Added: 0070597
2017-10-01 21:03ziaulazamNote Added: 0071096
2017-10-01 21:03ziaulazamStatusnew => resolved
2017-10-01 21:03ziaulazamSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17792#r17792
2017-10-04 10:47gitNote Added: 0071181
2017-10-04 11:42kgvSummaryVisualization gets slower if many AIS_Trihedron(s) are rendered => Visualization, AIS_Trihedron - add option hiding arrows tips
2017-10-04 11:42kgvSeverityminor => feature
2017-10-04 11:42kgvTarget Version => 7.4.0
2017-10-04 11:51gitNote Added: 0071188
2017-10-04 12:45gitNote Added: 0071189
2017-10-04 12:51gitNote Added: 0071190
2017-10-04 13:57kgvFile Added: occ_trihedrons.png
2017-10-04 19:51kgvNote Added: 0071208
2017-10-04 19:51kgvAssigned Tokgv => bugmaster
2017-10-04 19:51kgvStatusresolved => reviewed
2017-10-05 13:07bugmasterNote Added: 0071232
2017-10-05 13:07bugmasterStatusreviewed => tested
2017-10-05 13:07bugmasterNote Edited: 0071232bug_revision_view_page.php?bugnote_id=71232#r17831
2017-10-06 14:55bugmasterChangeset attached => occt master fae1ae11
2017-10-06 14:55bugmasterStatustested => verified
2017-10-06 14:55bugmasterResolutionopen => fixed
2017-10-09 10:22bugmasterTest case number => Not required
2017-10-14 12:19gitNote Added: 0071454
2017-10-14 12:19gitNote Added: 0071455
2017-10-14 12:19gitNote Added: 0071456
2018-01-09 11:44kgvRelationship addedparent of 0029414
2018-02-20 12:58aivTarget Version7.4.0 => 7.3.0
2018-06-29 21:15aivFixed in Version => 7.3.0
2018-06-29 21:19aivStatusverified => closed

Notes
(0070511)
git   
2017-09-13 18:16   
Branch CR29109 has been created by Zia ul Azam.

SHA-1: 2b7b305f8dd8b7ce534fbf7846481fd3155db2f6


Detailed log of new commits:

Author: Zia ul Azam
Date: Wed Sep 13 17:12:57 2017 +0200

    0029109: Visualization gets slower if many AIS_Trihedron(s) are rendered
    
    Added a public method to toggle arrows visibility in AIS_Trihedron.
(0070518)
kgv   
2017-09-14 09:11   
+  Standard_EXPORT void ToggleArrowsVisibility() { myIsArrowsVisible = !myIsArrowsVisible; }

This is not how Boolean flags are usually provided in OCCT classes - there should be a getter ToDrawArrows() and setter SetDrawArrows().
Also declaring inline method Standard_EXPORT will force each binary (DLL, EXE - including application itself) where this header will be included in some cpp file to export this function.
(0070591)
git   
2017-09-15 15:32   
Branch CR29109 has been updated by Zia ul Azam.

SHA-1: 36212450fc1a34ccbf8628f1a86dc79ca7e8cf00


Detailed log of new commits:

Author: Zia ul Azam
Date: Fri Sep 15 14:31:47 2017 +0200

    0029109: Visualization gets slower if many AIS_Trihedron(s) are rendered
    
    Added getters and setters to manage whether to draw arrows or not.

(0070597)
ziaulazam   
2017-09-15 16:18   
I cannot change the status of this issue? Why?
(0071096)
ziaulazam   
2017-10-01 21:03   
The comments on the previous commit have been taken care of now. I have added the getter and setter as pointed out.
(0071181)
git   
2017-10-04 10:47   
Branch CR29109_1 has been created by kgv.

SHA-1: 628ed2d8559d5b7680a77cb07b2c782562c65357


Detailed log of new commits:

Author: Zia ul Azam
Date: Wed Sep 13 17:12:57 2017 +0200

    0029109: Visualization gets slower if many AIS_Trihedron(s) are rendered
    
    Added getters and setters to manage whether to draw arrows or not.
(0071188)
git   
2017-10-04 11:51   
Branch CR29109_1 has been updated by kgv.

SHA-1: daf7ad81873a399581a3618557d03659ad940a21


Detailed log of new commits:

Author: kgv
Date: Wed Oct 4 11:51:18 2017 +0300

    vtrihedron - added new option -arrowTip.
    Fixed misprint in help -arrowscolor -> -arrowcolor.

(0071189)
git   
2017-10-04 12:45   
Branch CR29109_1 has been updated by kgv.

SHA-1: 05c2ce3d0f0eac92f5b0e67d0c2c3a6e256c3ddd


Detailed log of new commits:

Author: kgv
Date: Wed Oct 4 12:45:34 2017 +0300

    Prs3d_DatumAspect::DrawDatumPart() now handles new flag myToDrawArrows.

(0071190)
git   
2017-10-04 12:51   
Branch CR29109_2 has been created by kgv.

SHA-1: a14f512cfe39a23a25ba60a8eff2824ed26286f6


Detailed log of new commits:

Author: Zia ul Azam
Date: Wed Sep 13 17:12:57 2017 +0200

    0029109: Visualization, AIS_Trihedron - add option hiding arrows tips
    
    Prs3d_DatumAspect::DrawDatumPart() now handles new flag ToDrawArrows().
    
    vtrihedron - added new option -arrowTip.
    Fixed misprint in command description -arrowscolor -> -arrowcolor.
(0071208)
kgv   
2017-10-04 19:51   
Please take the patch.

http://jenkins-test-10.nnov.opencascade.com/view/CR29109_2-master-KGV/ [^]
(0071232)
bugmaster   
2017-10-05 13:07   
Combination -
OCCT branch : CR29109_2 SHA-1: a14f512cfe39a23a25ba60a8eff2824ed26286f6
Products branch : master
was compiled on Linux, MacOS and Windows platforms and tested on optimize mode.


Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
No differences that require special attention

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

(0071454)
git   
2017-10-14 12:19   
Branch CR29109 has been deleted by kgv.

SHA-1: 36212450fc1a34ccbf8628f1a86dc79ca7e8cf00
(0071455)
git   
2017-10-14 12:19   
Branch CR29109_1 has been deleted by kgv.

SHA-1: 05c2ce3d0f0eac92f5b0e67d0c2c3a6e256c3ddd
(0071456)
git   
2017-10-14 12:19   
Branch CR29109_2 has been deleted by kgv.

SHA-1: a14f512cfe39a23a25ba60a8eff2824ed26286f6