MantisBT - Open CASCADE
View Issue Details
0029059Open CASCADE[OCCT] OCCT:Modeling Algorithmspublic2017-08-28 09:332021-05-11 21:47
emv 
msv 
normalminor 
assignedopen 
[OCCT] 7.1.0 
[OCCT] 7.6.0* 
0029059: It is necessary to have a unique way of checking of the validity of the edge and its 2D curves
Currently, at least three such checks are implemented in OCCT:
1. In BRepCheck_Edge;
2. In Boolean Operations - BOPTools_AlgoTools (the check is a copy of the check implemented in BRepCheck_Edge);
3. In ShapeAnalysis_Edge.

It is necessary to unify all these checks in one place (BRepLib package looks ideal for this) and replace the current checks with the usage of the unified one. It will allow avoiding errors due to inconsistency between similar checks and will help to maintain it easily.
No tags attached.
related to 0026365assigned kgv Open CASCADE Optimization of work of OSD_Parallel class members for GeomLib_CheckCurveOnSurface 
Issue History
2017-08-28 09:33emvNew Issue
2017-08-28 09:33emvAssigned To => msv
2019-08-12 16:43msvTarget Version7.4.0 => 7.5.0
2020-09-14 22:55msvTarget Version7.5.0 => 7.6.0*
2021-04-16 10:02szyNote Added: 0100330
2021-04-16 10:02szyAssigned Tomsv => asuraven
2021-04-16 10:02szyStatusnew => assigned
2021-04-16 15:03asuravenNote Added: 0100340
2021-04-16 16:34asuravenNote Edited: 0100340bug_revision_view_page.php?bugnote_id=100340#r25068
2021-04-19 15:08asuravenNote Added: 0100451
2021-04-19 19:02asuravenRelationship addedrelated to 0029136
2021-04-21 17:17asuravenRelationship addedrelated to 0026365
2021-04-23 12:22asuravenNote Added: 0100523
2021-04-23 12:32asuravenNote Added: 0100526
2021-04-26 10:20asuravenNote Edited: 0100526bug_revision_view_page.php?bugnote_id=100526#r25100
2021-04-26 10:20asuravenNote Edited: 0100523bug_revision_view_page.php?bugnote_id=100523#r25102
2021-04-26 10:21asuravenNote Added: 0100585
2021-04-27 18:48asuravenNote Added: 0100622
2021-04-28 12:38gitNote Added: 0100636
2021-04-28 20:23gitNote Added: 0100645
2021-04-29 11:52asuravenNote Added: 0100658
2021-04-29 19:11gitNote Added: 0100672
2021-04-29 19:11gitNote Added: 0100673
2021-04-30 17:57gitNote Added: 0100704
2021-04-30 20:39gitNote Added: 0100711
2021-04-30 20:56asuravenNote Added: 0100712
2021-05-04 18:22gitNote Added: 0100768
2021-05-04 18:50gitNote Added: 0100769
2021-05-04 18:51gitNote Added: 0100770
2021-05-04 19:57gitNote Added: 0100771
2021-05-04 19:59gitNote Added: 0100772
2021-05-04 19:59asuravenNote Added: 0100773
2021-05-05 11:04gitNote Added: 0100775
2021-05-05 11:04gitNote Added: 0100776
2021-05-05 12:12gitNote Added: 0100778
2021-05-05 13:08asuravenNote Added: 0100779
2021-05-05 16:32gitNote Added: 0100785
2021-05-05 16:32gitNote Added: 0100786
2021-05-05 21:35gitNote Added: 0100792
2021-05-06 11:59asuravenRelationship addedrelated to 0022428
2021-05-06 12:28asuravenNote Added: 0100794
2021-05-07 10:44gitNote Added: 0100809
2021-05-07 16:16gitNote Added: 0100818
2021-05-07 19:04gitNote Added: 0100820
2021-05-07 20:32asuravenNote Added: 0100822
2021-05-07 21:08gitNote Added: 0100823
2021-05-08 10:38gitNote Added: 0100824
2021-05-08 10:38gitNote Added: 0100825
2021-05-08 11:25gitNote Added: 0100826
2021-05-09 13:32gitNote Added: 0100834
2021-05-10 16:59gitNote Added: 0100856
2021-05-10 18:26gitNote Added: 0100858
2021-05-10 18:59gitNote Added: 0100859
2021-05-10 20:40gitNote Added: 0100860
2021-05-10 20:40gitNote Added: 0100861
2021-05-11 13:30gitNote Added: 0100875
2021-05-11 13:30gitNote Added: 0100876
2021-05-11 13:31gitNote Added: 0100877
2021-05-11 15:11gitNote Added: 0100880
2021-05-11 21:12asuravenNote Added: 0100894
2021-05-11 21:15asuravenNote Edited: 0100894bug_revision_view_page.php?bugnote_id=100894#r25167
2021-05-11 21:47asuravenAssigned Toasuraven => msv

Notes
(0100330)
szy   
2021-04-16 10:02   
Analyze and estimate the issue, please.
(0100340)
asuraven   
2021-04-16 15:03   
(edited on: 2021-04-16 16:34)


(0100451)
asuraven   
2021-04-19 15:08   
(0100523)
asuraven   
2021-04-23 12:22   
(edited on: 2021-04-26 10:20)


(0100526)
asuraven   
2021-04-23 12:32   
(edited on: 2021-04-26 10:20)


(0100585)
asuraven   
2021-04-26 10:21   
(0100622)
asuraven   
2021-04-27 18:48   
(0100636)
git   
2021-04-28 12:38   
Branch CR29059 has been created by asuraven.

SHA-1: bef364518656a1afededd8ddbaa0fe155391f647


Detailed log of new commits:

Author: asuraven
Date: Wed Apr 28 12:06:39 2021 +0300

    0029059: It is necessary to have a unique way of checking of the validity of the edge and its 2D curves
(0100645)
git   
2021-04-28 20:23   
Branch CR29059 has been updated by asuraven.

SHA-1: 5dee243e6f2e6e73bc2bc53d2e789f8df8c57a53


Detailed log of new commits:

Author: asuraven
Date: Wed Apr 28 20:23:37 2021 +0300

    debug changes

(0100658)
asuraven   
2021-04-29 11:52   
(0100672)
git   
2021-04-29 19:11   
Branch CR29059 has been deleted by asuraven.

SHA-1: 5dee243e6f2e6e73bc2bc53d2e789f8df8c57a53
(0100673)
git   
2021-04-29 19:11   
Branch CR29059 has been created by asuraven.

SHA-1: 9ca1b26415806cb8a46f4eac42387ea32a6bcb5a


Detailed log of new commits:

Author: asuraven
Date: Wed Apr 28 12:06:39 2021 +0300

    0029059: It is necessary to have a unique way of checking of the validity of the edge and its 2D curves
(0100704)
git   
2021-04-30 17:57   
Branch CR29059 has been updated by asuraven.

SHA-1: a5f32c4386e57dc4da8f1827176eed7177011508


Detailed log of new commits:

Author: asuraven
Date: Fri Apr 30 17:57:45 2021 +0300

    debug

(0100711)
git   
2021-04-30 20:39   
Branch CR29059 has been updated by asuraven.

SHA-1: 54418a5cfedd5b57daa7241745311b9052e609da


Detailed log of new commits:

Author: asuraven
Date: Fri Apr 30 19:24:51 2021 +0300

    debug

(0100712)
asuraven   
2021-04-30 20:56   
(0100768)
git   
2021-05-04 18:22   
Branch CR29059_1 has been created by asuraven.

SHA-1: 5b21e1ec1b8cf3535deccf42e0b4a38eb86ba6ee


Detailed log of new commits:

Author: asuraven
Date: Tue May 4 18:22:19 2021 +0300

    debug
(0100769)
git   
2021-05-04 18:50   
Branch CR29059_1 has been deleted by asuraven.

SHA-1: 5b21e1ec1b8cf3535deccf42e0b4a38eb86ba6ee
(0100770)
git   
2021-05-04 18:51   
Branch CR29059_1 has been created by asuraven.

SHA-1: 514180b263892097b66d148269cf0e5024a3aa90


Detailed log of new commits:

Author: asuraven
Date: Tue May 4 18:22:19 2021 +0300

    debug

Author: asuraven
Date: Fri Apr 30 17:57:45 2021 +0300

    debug

Author: asuraven
Date: Fri Apr 30 19:24:51 2021 +0300

    debug

Author: asuraven
Date: Wed Apr 28 12:06:39 2021 +0300

    0029059: It is necessary to have a unique way of checking of the validity of the edge and its 2D curves
(0100771)
git   
2021-05-04 19:57   
Branch CR29059 has been deleted by asuraven.

SHA-1: 54418a5cfedd5b57daa7241745311b9052e609da
(0100772)
git   
2021-05-04 19:59   
Branch CR29059 has been created by asuraven.

SHA-1: ef04985b840d7588b44c12a1c508af5c08e89587


Detailed log of new commits:

Author: asuraven
Date: Tue May 4 19:58:16 2021 +0300

    debug

Author: asuraven
Date: Wed Apr 28 12:06:39 2021 +0300

    0029059: It is necessary to have a unique way of checking of the validity of the edge and its 2D curves

Author: asuraven
Date: Fri Apr 30 17:57:45 2021 +0300

    debug

Author: asuraven
Date: Fri Apr 30 19:24:51 2021 +0300

    debug
(0100773)
asuraven   
2021-05-04 19:59   
(0100775)
git   
2021-05-05 11:04   
Branch CR29059 has been deleted by asuraven.

SHA-1: ef04985b840d7588b44c12a1c508af5c08e89587
(0100776)
git   
2021-05-05 11:04   
Branch CR29059 has been created by asuraven.

SHA-1: 6a43679b3668a6d96ea897457ea8dbe9c6162a3a


Detailed log of new commits:

Author: asuraven
Date: Wed Apr 28 12:06:39 2021 +0300

    0029059: It is necessary to have a unique way of checking of the validity of the edge and its 2D curves
(0100778)
git   
2021-05-05 12:12   
Branch CR29059 has been updated by asuraven.

SHA-1: c87200280608bfb7b0f49140995513b68ffd0a14


Detailed log of new commits:

Author: asuraven
Date: Wed May 5 12:12:49 2021 +0300

    0029059: Exclude old code

(0100779)
asuraven   
2021-05-05 13:08   
(0100785)
git   
2021-05-05 16:32   
Branch CR29059 has been deleted by asuraven.

SHA-1: c87200280608bfb7b0f49140995513b68ffd0a14
(0100786)
git   
2021-05-05 16:32   
Branch CR29059 has been created by asuraven.

SHA-1: 3d6494e42c04656e99e6dfd3af6a9b3a0fc2ff64


Detailed log of new commits:

Author: asuraven
Date: Wed May 5 12:12:49 2021 +0300

    0029059: Exclude old code

Author: asuraven
Date: Wed Apr 28 12:06:39 2021 +0300

    0029059: It is necessary to have a unique way of checking of the validity of the edge and its 2D curves
(0100792)
git   
2021-05-05 21:35   
Branch CR29059_2 has been created by asuraven.

SHA-1: 779adf61db82bee4898595a610046fdb8a7f92c4


Detailed log of new commits:

Author: asuraven
Date: Wed May 5 21:35:39 2021 +0300

    debug
(0100794)
asuraven   
2021-05-06 12:28   
(0100809)
git   
2021-05-07 10:44   
Branch CR29059_2 has been updated by asuraven.

SHA-1: 28bb8c732fc6a6c338a708448397a861c4bec679


Detailed log of new commits:

Author: asuraven
Date: Fri May 7 10:44:28 2021 +0300

    debug

(0100818)
git   
2021-05-07 16:16   
Branch CR29059_3 has been created by asuraven.

SHA-1: 5aa8f2af014ab895eecbb9e4b7804567cf950f08


Detailed log of new commits:

Author: asuraven
Date: Fri May 7 16:17:11 2021 +0300

    BRepLib_ValidateEdge class
(0100820)
git   
2021-05-07 19:04   
Branch CR29059_3 has been updated by asuraven.

SHA-1: 14591cad585dd854c5d9462b269dbd69eb63ebf4


Detailed log of new commits:

Author: asuraven
Date: Fri May 7 19:04:35 2021 +0300

    fix for unix

(0100822)
asuraven   
2021-05-07 20:32   
(0100823)
git   
2021-05-07 21:08   
Branch CR29059_3 has been updated by asuraven.

SHA-1: b7233c678d15226dfee6e8fb169ad34a0b370df6


Detailed log of new commits:

Author: asuraven
Date: Fri May 7 21:08:55 2021 +0300

    fix for unix + 1 exact method

(0100824)
git   
2021-05-08 10:38   
Branch CR29059_3 has been deleted by asuraven.

SHA-1: b7233c678d15226dfee6e8fb169ad34a0b370df6
(0100825)
git   
2021-05-08 10:38   
Branch CR29059_3 has been created by asuraven.

SHA-1: b340f72e4ace7979f5d9f469b81cf5e9d2229daf


Detailed log of new commits:

Author: asuraven
Date: Wed Apr 28 12:06:39 2021 +0300

    0029059: It is necessary to have a unique way of checking of the validity of the edge and its 2D curves
(0100826)
git   
2021-05-08 11:25   
Branch CR29059_3 has been updated by asuraven.

SHA-1: cfdbed86ac03a19b38a7ab0d49c4d0851914dcde


Detailed log of new commits:

Author: asuraven
Date: Sat May 8 11:25:33 2021 +0300

    Exclude old code

(0100834)
git   
2021-05-09 13:32   
Branch CR29059_4 has been created by asuraven.

SHA-1: 40aef9da442a65e5a994d9e42d81a8c366e35d3f


Detailed log of new commits:

Author: asuraven
Date: Sun May 9 13:33:24 2021 +0300

    using of exact method
(0100856)
git   
2021-05-10 16:59   
Branch CR29059_4 has been updated by asuraven.

SHA-1: 46822041b21a90281af774b09f5a58eb16b50b59


Detailed log of new commits:

Author: asuraven
Date: Mon May 10 17:00:17 2021 +0300

    fix

(0100858)
git   
2021-05-10 18:26   
Branch CR29059_3 has been deleted by asuraven.

SHA-1: cfdbed86ac03a19b38a7ab0d49c4d0851914dcde
(0100859)
git   
2021-05-10 18:59   
Branch CR29059_3 has been created by asuraven.

SHA-1: c2dc72b45e62fded0ec78f772263bdbbd772da8e


Detailed log of new commits:

Author: asuraven
Date: Wed Apr 28 12:06:39 2021 +0300

    0029059: It is necessary to have a unique way of checking of the validity of the edge and its 2D curves
    
    Add new class BRepLib_ValidateEdge to edge checking to use instead function:
    - Validate() from BOPTools_AlgoTools.cxx
    - Validate() from BRepCheck_Edge.cxx
    - ShapeAnalysis_Edge::ComputeDeviation()
(0100860)
git   
2021-05-10 20:40   
Branch CR29059_4 has been deleted by asuraven.

SHA-1: 46822041b21a90281af774b09f5a58eb16b50b59
(0100861)
git   
2021-05-10 20:40   
Branch CR29059_4 has been created by asuraven.

SHA-1: 67ef0a940c60d647dc0fa54ec2cfdb885ea0c83e


Detailed log of new commits:

Author: asuraven
Date: Sun May 9 13:33:24 2021 +0300

    using of exact method

Author: asuraven
Date: Sat May 8 11:25:33 2021 +0300

    Exclude old code

Author: asuraven
Date: Wed Apr 28 12:06:39 2021 +0300

    0029059: It is necessary to have a unique way of checking of the validity of the edge and its 2D curves
(0100875)
git   
2021-05-11 13:30   
Branch CR29059_4 has been deleted by asuraven.

SHA-1: 67ef0a940c60d647dc0fa54ec2cfdb885ea0c83e
(0100876)
git   
2021-05-11 13:30   
Branch CR29059_4 has been created by asuraven.

SHA-1: cd0aac1a0a492ff5ff81d4207f3b070a9357ced2


Detailed log of new commits:

Author: asuraven
Date: Tue May 11 13:30:59 2021 +0300

    fix

Author: asuraven
Date: Sun May 9 13:33:24 2021 +0300

    using of exact method

Author: asuraven
Date: Sat May 8 11:25:33 2021 +0300

    Exclude old code

Author: asuraven
Date: Wed Apr 28 12:06:39 2021 +0300

    0029059: It is necessary to have a unique way of checking of the validity of the edge and its 2D curves
(0100877)
git   
2021-05-11 13:31   
Branch CR29059_4 has been deleted by asuraven.

SHA-1: cd0aac1a0a492ff5ff81d4207f3b070a9357ced2
(0100880)
git   
2021-05-11 15:11   
Branch CR29059_4 has been created by asuraven.

SHA-1: 1b38e44c2cdfc11ce1486e5e6070cb08d62733fe


Detailed log of new commits:

Author: asuraven
Date: Sun May 9 13:33:24 2021 +0300

    using of exact method

Author: asuraven
Date: Sat May 8 11:25:33 2021 +0300

    Exclude old code

Author: asuraven
Date: Wed Apr 28 12:06:39 2021 +0300

    0029059: It is necessary to have a unique way of checking of the validity of the edge and its 2D curves
(0100894)
asuraven   
2021-05-11 21:12   
(edited on: 2021-05-11 21:15)
Dear Michael!
Please consider the variants of the issue solution.
The Branch CR29059_3 contains solution with fixed points count checking implemented in new BRepLib_ValidateEdge class.
This solution passed all tests: http://jenkins-test-occt.nnov.opencascade.com/view/CR29059_3-master-ASURAVEN/view/COMPARE/ [^]
The Branch CR29059_4 containts exact checking solution
 using GeomLib_CheckCurveOnSurface/BrepmLib_CheckCurveOnSurface classes.
This solution contains a lot of failed tests and full report not generated for this reason. See set of reports in \\ownCloud\OCCT\Issues\0029059 29059_tests_results.7z file.
Please carefully check my using of _CheckCurveOnSurface classes in last CR29059_4 commit because so many failed tests in this branch.