MantisBT - Community
View Issue Details
0028982Community[OCCT] OCCT:Modeling Algorithmspublic2017-08-08 09:122018-06-29 21:19
ickby 
bugmaster 
normalmajor 
closedfixed 
PCWindows7
[OCCT] 7.1.0 
[OCCT] 7.3.0[OCCT] 7.3.0 
bugs modalg_7 bug28982
0028982: 2D offset creates faulty result from wire
The given ellipse creates a faulty shape when used in a 2d offset operation. It seems valid when checked with "checkshape" but it can be detected with bopcheck command. When th eoffset is used in further operations the created geometry is invalid: https://forum.freecadweb.org/viewtopic.php?f=3&t=17448&p=137535#p137503 [^]

This was reproduced with OCC 7.2beta.

pload ALL
restore ellipse.brep
mkoffset r ellipse 1 1
checkshape r_1 #valid
bopcheck r_1 #gives errors
No tags attached.
? ellipse.brep (2,247) 2017-08-08 09:12
https://tracker.dev.opencascade.org/
Issue History
2017-08-08 09:12ickbyNew Issue
2017-08-08 09:12ickbyAssigned To => msv
2017-08-08 09:12ickbyFile Added: ellipse.brep
2017-08-08 10:55emvAssigned Tomsv => emv
2017-08-08 10:58emvNote Added: 0069194
2017-08-08 10:58emvStatusnew => assigned
2017-08-08 15:50gitNote Added: 0069210
2017-08-09 07:43gitNote Added: 0069229
2017-08-09 13:34emvNote Added: 0069241
2017-08-09 13:34emvAssigned Toemv => nbv
2017-08-09 13:34emvStatusassigned => resolved
2017-08-09 15:05nbvNote Added: 0069248
2017-08-09 15:05nbvAssigned Tonbv => bugmaster
2017-08-09 15:05nbvStatusresolved => reviewed
2017-08-10 10:41bugmasterNote Added: 0069269
2017-08-10 10:41bugmasterStatusreviewed => tested
2017-08-10 10:41bugmasterTest case number => bugs modalg_7 bug28982
2017-08-10 10:42bugmasterNote Edited: 0069269bug_revision_view_page.php?bugnote_id=69269#r17299
2017-08-11 07:52bugmasterChangeset attached => occt master a318d719
2017-08-11 07:52bugmasterStatustested => verified
2017-08-11 07:52bugmasterResolutionopen => fixed
2017-08-18 17:00gitNote Added: 0069655
2018-02-19 10:33abvTarget Version => 7.4.0*
2018-02-20 12:58aivTarget Version7.4.0* => 7.3.0
2018-06-29 21:15aivFixed in Version => 7.3.0
2018-06-29 21:19aivStatusverified => closed

Notes
(0069194)
emv   
2017-08-08 10:58   
The result of the offset operation seems to be valid. The problem is on the bopcheck side. The exception is raised during the check of the result r_1 with bopcheck command. I will analyze the issue when I have time.
(0069210)
git   
2017-08-08 15:50   
Branch CR28982 has been created by emv.

SHA-1: 435f2bf630eb3418511d999bff3e3b1cf1852aec


Detailed log of new commits:

Author: emv
Date: Tue Aug 8 11:20:57 2017 +0300

    0028982: 2D offset creates faulty result from wire
    
    Protection of the Edge/Edge intersection algorithm (IntTools_EdgeEdge) from incomplete type conversion due to presence of the Trimmed curves by using Adaptors for getting typed curves instead of direct casting.
    
    Test case for the issue.
(0069229)
git   
2017-08-09 07:43   
Branch CR28982 has been updated forcibly by emv.

SHA-1: ac0d2fbe6c51ebbf84664ccd5ff370761fa94ff5
(0069241)
emv   
2017-08-09 13:34   
Dear Nikolay, could you please review the patch?

Test results are available here - http://jenkins-test-10.nnov.opencascade.com:8080/view/CR28982-master-EMV/view/COMPARE/ [^]
(0069248)
nbv   
2017-08-09 15:05   
Reviewed.
(0069269)
bugmaster   
2017-08-10 10:41   
(edited on: 2017-08-10 10:42)
Combination -
OCCT branch : CR28982 : SHA-1: ac0d2fbe6c51ebbf84664ccd5ff370761fa94ff5
Products branch : master
was compiled on Linux, MacOS and Windows platforms and tested on optimize mode.

http://jenkins-test-10.nnov.opencascade.com/view/CR28982-master-EMV/view/START%20BRANCH%20CERTIFICATION/ [^]

Number of compiler warnings:

OCCT :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

Products :
Linux: 5 (5 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
No differences that require special attention

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

New test cases: OK
http://occt-tests/CR28982-master-EMV-OCCT/Windows-64-VC10/bugs/modalg_7/bug28982.html [^]
http://occt-tests/CR28982-master-EMV-OCCT/Debian70-64/bugs/modalg_7/bug28982.html [^]

(0069655)
git   
2017-08-18 17:00   
Branch CR28982 has been deleted by kgv.

SHA-1: ac0d2fbe6c51ebbf84664ccd5ff370761fa94ff5