MantisBT - Open CASCADE
View Issue Details
0028959Open CASCADE[OCCT] OCCT:Configurationpublic2017-07-29 09:382017-09-29 16:29
abv 
abv 
normalminor 
closedfixed 
[OCCT] 7.1.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not required
0028959: Configuration, genproj - provide warning on update of scripts in root folder (msvc.bat etc.)
Procedure genproj.bat currently overrides file msvc.bat in the root folder by copying template from adm/templates/msvc.bat without any message. It can be quite confusing -- when you modify msvc.bat, it gets overridden silently and your changes get lost. To improve the situation, warning message can be given on override (unless the files are already the same); old copy can be saved in .bak file.
genproj.bat
No tags attached.
Issue History
2017-07-29 09:38abvNew Issue
2017-07-29 09:38abvAssigned To => bugmaster
2017-07-29 09:42gitNote Added: 0068861
2017-07-29 09:50abvAssigned Tobugmaster => kgv
2017-07-29 09:50abvStatusnew => resolved
2017-07-29 09:50abvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17217#r17217
2017-07-29 09:53abvNote Added: 0068862
2017-07-29 09:53abvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17218#r17218
2017-07-29 09:53kgvNote Added: 0068863
2017-07-29 09:53kgvAssigned Tokgv => bugmaster
2017-07-29 09:53kgvStatusresolved => reviewed
2017-07-29 09:53kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17219#r17219
2017-07-29 09:55abvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17220#r17220
2017-07-29 10:07abvNote Added: 0068864
2017-07-29 10:07abvAssigned Tobugmaster => abv
2017-07-29 10:07abvStatusreviewed => assigned
2017-08-17 12:31gitNote Added: 0069515
2017-08-17 12:34abvNote Added: 0069516
2017-08-17 12:34abvAssigned Toabv => bugmaster
2017-08-17 12:34abvStatusassigned => resolved
2017-08-17 12:35abvStatusresolved => reviewed
2017-08-17 12:36bugmasterStatusreviewed => tested
2017-08-18 12:53abvChangeset attached => occt master 471a2ca0
2017-08-18 12:53abvAssigned Tobugmaster => abv
2017-08-18 12:53abvStatustested => verified
2017-08-18 12:53abvResolutionopen => fixed
2017-08-18 13:09bugmasterTest case number => Not required
2017-08-18 17:00gitNote Added: 0069642
2017-08-18 17:00gitNote Added: 0069643
2017-09-29 16:17aivFixed in Version => 7.2.0
2017-09-29 16:29aivStatusverified => closed

Notes
(0068861)
git   
2017-07-29 09:42   
Branch CR28959 has been created by abv.

SHA-1: 5993c8c6cd261a453a96cff372c06dc546ae7cce


Detailed log of new commits:

Author: abv
Date: Sat Jul 29 09:42:16 2017 +0300

    0028959: Configuration, genproj - provide warning on update of scripts in root folder (msvc.bat etc.)
    
    When updating files msvc.bat, env.bat/sh, and draw.bat/sh in the root folder by copying template from adm/templates, procedure genproj will give a warning (unless the files are already the same); if the target file is newer, its copy is saved with additional extension .bak.
(0068862)
abv   
2017-07-29 09:53   
Fix pushed to CR28959, please review.

Note that env.bat is now copied verbatim; in previous version it was copied with substitution of CASROOT macro; this was obsolete since env.bat does not contain such macro any more.
(0068863)
kgv   
2017-07-29 09:53   
No remark, please take the patch.
(0068864)
abv   
2017-07-29 10:07   
Sorry, template for env.sh still contains __CASROOT__ substitution; to be removed and checked
(0069515)
git   
2017-08-17 12:31   
Branch CR28959_1 has been created by abv.

SHA-1: 708d8ca813a57fb1b17eb0dae5f23a47f1ce7a39


Detailed log of new commits:

Author: abv
Date: Sat Jul 29 09:42:16 2017 +0300

    0028959: Configuration, genproj - provide warning on update of scripts in root folder (msvc.bat etc.)
    
    When updating files msvc.bat and draw.bat/sh in the root folder by copying template from adm/templates, procedure genproj will give a warning (unless the files are already the same); if the target file is newer, its copy is saved with additional extension .bak.
(0069516)
abv   
2017-08-17 12:34   
Previous change was incorrect: in the current approach, products have their own env.bat/sh located in the folder which is current for genproj, and it should not be overwritten. Branch CR28959_1 contains only generation of warning, and no change of the logic. Please integrate.
(0069642)
git   
2017-08-18 17:00   
Branch CR28959 has been deleted by kgv.

SHA-1: 5993c8c6cd261a453a96cff372c06dc546ae7cce
(0069643)
git   
2017-08-18 17:00   
Branch CR28959_1 has been deleted by kgv.

SHA-1: 708d8ca813a57fb1b17eb0dae5f23a47f1ce7a39