MantisBT - Open CASCADE
View Issue Details
0028927Open CASCADE[OCCT] OCCT:Visualizationpublic2017-07-19 16:502017-09-29 16:28
kgv 
bugmaster 
normalminor 
closedfixed 
[OCCT] 7.2.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028927: Visualization - Graphic3d_StructureManager destructor should invalidate its pointer in Graphic3d_Structure
Graphic3d_StructureManager clears the map of displayed structures, however if Graphic3d_Structure is held by pointer in other place it might remain holding invalid pointer to Graphic3d_StructureManager* leading to memory issues.

>	TKV3d.dll!Graphic3d_Structure::Erase() Line 249	C++
     TKV3d.dll!V3d_Trihedron::Erase() Line 251	C++
     TKV3d.dll!V3d_Trihedron::~V3d_Trihedron() Line 136	C++
N/A
No tags attached.
child of 0028889closed kgv Community Visualization, V3d_View - View specific Graphic3d_Structure should be removed if the view is removed 
Issue History
2017-07-19 16:50kgvNew Issue
2017-07-19 16:50kgvAssigned To => kgv
2017-07-19 17:40gitNote Added: 0068442
2017-07-19 17:40kgvNote Added: 0068443
2017-07-19 17:40kgvAssigned Tokgv => apl
2017-07-19 17:40kgvStatusnew => resolved
2017-07-19 17:41kgvRelationship addedchild of 0028889
2017-07-19 22:16kgvNote Added: 0068460
2017-07-20 11:12aplNote Added: 0068477
2017-07-20 11:12aplAssigned Toapl => bugmaster
2017-07-20 11:12aplStatusresolved => reviewed
2017-07-20 12:02mkvNote Added: 0068483
2017-07-20 12:02mkvNote Added: 0068484
2017-07-20 12:02mkvStatusreviewed => tested
2017-07-20 12:02mkvTest case number => Not needed
2017-07-21 16:08bugmasterChangeset attached => occt master b4fd9d00
2017-07-21 16:08bugmasterStatustested => verified
2017-07-21 16:08bugmasterResolutionopen => fixed
2017-07-21 16:16gitNote Added: 0068577
2017-09-29 16:17aivFixed in Version => 7.2.0
2017-09-29 16:28aivStatusverified => closed

Notes
(0068442)
git   
2017-07-19 17:40   
Branch CR28927 has been created by kgv.

SHA-1: 7014dabf8f715cdf26df28495b7c92606c221b5d


Detailed log of new commits:

Author: kgv
Date: Wed Jul 19 17:38:54 2017 +0300

    0028927: Visualization - Graphic3d_StructureManager destructor should invalidate its pointer in Graphic3d_Structure
    
    Graphic3d_Structure::myFirstStructureManager - removed unused class field.
    ~Graphic3d_StructureManager() now removes displayed Structures explicitly.
(0068443)
kgv   
2017-07-19 17:40   
Patch is ready for review.
(0068460)
kgv   
2017-07-19 22:16   
CR28927-master-KGV-Products-Debian70-64-opt-tests-compare-linux - Build # 1 - Successful:
Check console output at http://jenkins-test-10.nnov.opencascade.com:8080/job/CR28927-master-KGV-Products-Debian70-64-opt-tests-compare-linux/1/ [^] to view the results.

CR28927-master-KGV-Products-Windows-64-VC10-opt-tests-compare-windows - Build # 1 - Successful:
Check console output at http://jenkins-test-10.nnov.opencascade.com:8080/job/CR28927-master-KGV-Products-Windows-64-VC10-opt-tests-compare-windows/1/ [^] to view the results.
(0068477)
apl   
2017-07-20 11:12   
Dear bugmaster,

The patch is reviewed.
(0068483)
mkv   
2017-07-20 12:02   
Dear BugMaster,
Branch CR28927 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 7014dabf8f715cdf26df28495b7c92606c221b5d

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 10 (10 on master)
Windows: 0 (0 on master)
MacOS : 28 (28 on master)

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total CPU difference: 19270.61000000009 / 19401.700000000146 [-0.68%]
Total MEMORY difference: 92464009 / 92470226 [-0.01%]
products component :
Total CPU difference: 6527.61000000006 / 6549.0400000000745 [-0.33%]
Total MEMORY difference: 38250883 / 38042393 [+0.55%]
Testing on Windows:
occt component :
Total CPU difference: 18117.41013649854 / 17787.76442339872 [+1.85%]
Total MEMORY difference: 59105892 / 59108328 [-0.00%]
products component :
Total CPU difference: 6771.207804900063 / 6684.861251400067 [+1.29%]
Total MEMORY difference: 28934022 / 28820451 [+0.39%]

There are no differences in images found by testdiff.
(0068484)
mkv   
2017-07-20 12:02   
Dear BugMaster,
Branch CR28927 from occt git-repository is TESTED.
(0068577)
git   
2017-07-21 16:16   
Branch CR28927 has been deleted by kgv.

SHA-1: 7014dabf8f715cdf26df28495b7c92606c221b5d