MantisBT - Open CASCADE
View Issue Details
0028920Open CASCADE[OCCT] OCCT:Samplespublic2017-07-18 07:322017-09-29 16:29
kgv 
bugmaster 
highmajor 
closedfixed 
[OCCT] 7.2.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028920: Samples - fix msvc.bat for building samples without CMake
0028769 improvement has broken starting VS projects in case if OCCT has been built using genproj.bat (not CMake).

The reason is that DevEnvDir has been removed from msvc.bat for samples, but was not added to env.bat of OCCT itself.
No tags attached.
child of 0028769closed bugmaster Unification of msvc.bat files. 
Issue History
2017-07-18 07:32kgvNew Issue
2017-07-18 07:32kgvAssigned To => apn
2017-07-18 07:32kgvRelationship addedchild of 0028769
2017-07-18 07:33kgvPrioritynormal => high
2017-07-18 07:33kgvSeverityminor => major
2017-07-19 18:34gitNote Added: 0068450
2017-07-19 18:57kgvNote Added: 0068452
2017-07-20 11:50gitNote Added: 0068479
2017-07-20 11:53apnNote Added: 0068480
2017-07-20 11:53apnTest case number => Not needed
2017-07-20 11:53apnAssigned Toapn => kgv
2017-07-20 11:53apnStatusnew => resolved
2017-07-20 13:11kgvNote Added: 0068493
2017-07-20 13:11kgvAssigned Tokgv => apn
2017-07-20 13:11kgvStatusresolved => assigned
2017-07-20 13:53gitNote Added: 0068496
2017-07-21 13:49kgvNote Added: 0068547
2017-07-21 17:57gitNote Added: 0068599
2017-07-21 18:04apnNote Added: 0068602
2017-07-21 18:04apnAssigned Toapn => kgv
2017-07-21 18:04apnStatusassigned => resolved
2017-07-21 20:10kgvNote Added: 0068612
2017-07-21 20:10kgvAssigned Tokgv => bugmaster
2017-07-21 20:10kgvStatusresolved => reviewed
2017-07-24 16:54apvAssigned Tobugmaster => apv
2017-07-24 16:57apnNote Added: 0068633
2017-07-24 17:17gitNote Added: 0068635
2017-07-24 17:18apvNote Added: 0068637
2017-07-24 18:25apvNote Added: 0068645
2017-07-24 18:25apvAssigned Toapv => bugmaster
2017-07-24 18:25apvStatusreviewed => tested
2017-07-24 18:26apvNote Added: 0068646
2017-07-28 17:18bugmasterChangeset attached => occt master 48691eaa
2017-07-28 17:18bugmasterStatustested => verified
2017-07-28 17:18bugmasterResolutionopen => fixed
2017-07-31 17:46gitNote Added: 0068957
2017-09-29 16:17aivFixed in Version => 7.2.0
2017-09-29 16:29aivStatusverified => closed

Notes
(0068450)
git   
2017-07-19 18:34   
Branch CR28920 has been created by apn.

SHA-1: 44a276f37ee6b9ec58008f9b4c64ff0e2af93c0a


Detailed log of new commits:

Author: apn
Date: Wed Jul 19 18:34:09 2017 +0300

    0028920: Samples - fix msvc.bat for building samples without CMake
    
    Added DevEnvDir to env.bat.
(0068452)
kgv   
2017-07-19 18:57   
Please also make msvc.bat within Samples consistent to msvc.bat for OCCT itself.
E.g. specify window title to "start" directly to avoid issues (on my computer msvc.bat in Samples starts VS2017 instead of VS2015).

samples/mfc/standard/msvc.bat:
  11 rem Launch Visual Studio - either professional (devenv) or Express, as available
  12 if exist "%DevEnvDir%\devenv.exe"  (
  13   start "%DevEnvDir%\devenv.exe" "%PRJFILE%"
  14 ) else if exist "%DevEnvDir%\%VisualStudioExpressName%.exe"  (
  15   start "%DevEnvDir%\%VisualStudioExpressName%.exe" "%PRJFILE%"
  16 ) else (
  17   echo Error: Could not find MS Visual Studio ^(%VCFMT%^)
  18   echo Check relevant environment variable ^(e.g. VS100COMNTOOLS for vc10^)
  19 )


adm/templates/msvc.bat:
  42 rem Launch Visual Studio - either professional (devenv) or Express, as available
  43 if exist "%DevEnvDir%\devenv.exe"  (
  44   start "" "%DevEnvDir%\devenv.exe" "%PRJFILE%"
  45 ) else if exist "%DevEnvDir%\%VisualStudioExpressName%.exe"  (
  46   start "" "%DevEnvDir%\%VisualStudioExpressName%.exe" "%PRJFILE%"
  
47 ) else (
(0068479)
git   
2017-07-20 11:50   
Branch CR28920 has been updated forcibly by apn.

SHA-1: 82d2d3284392e45faa6d16a01cd23f566dd6ea6f
(0068480)
apn   
2017-07-20 11:53   
Dear kgv, could you please review CR28920.
(0068493)
kgv   
2017-07-20 13:11   
--- a/samples/mfc/standard/msvc.bat
+++ b/samples/mfc/standard/msvc.bat

The remark was for all "msvc.bat" files, not only for particular msvc.bat in MFC samples.
(0068496)
git   
2017-07-20 13:53   
Branch CR28920 has been updated forcibly by apn.

SHA-1: c116a70c733c262c4cedf403e4b6f410a8f6b239
(0068547)
kgv   
2017-07-21 13:49   
As DevEnvDir is set within adm/templates/env.bat, the duplicating code should be removed from adm/templates/msvc.bat
(0068599)
git   
2017-07-21 17:57   
Branch CR28920 has been updated forcibly by apn.

SHA-1: b347675d5e72f5150d5806f5b065f38a337ad412
(0068602)
apn   
2017-07-21 18:04   
Remarks were applied and all "msvc.bat" files were corrected. Dear kgv, could you please review occt and products branches CR28920.
(0068612)
kgv   
2017-07-21 20:10   
Patch looks OK (supposing that all modified samples have been actually checked).
(0068633)
apn   
2017-07-24 16:57   
Please check only compilation, testing is not required.
(0068635)
git   
2017-07-24 17:17   
Branch CR28920 has been updated forcibly by apv.

SHA-1: b2150b7cc6888cf359aef365d91303f63d74d5f1
(0068637)
apv   
2017-07-24 17:18   
Branches CR28920 from occt and products git-repositories have been rebased on the current masters.
(0068645)
apv   
2017-07-24 18:25   
Dear BugMaster,

Branch CR28920 from occt git-repository (and CR28920 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: b2150b7cc6888cf359aef365d91303f63d74d5f1
SHA-1: 4bd8c48f71086af0e65c56fb05d3173dc4929ff3

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 8 (8 on master)
   Windows: 0 (0 on master)
   MacOS: 2 (2 on master)
(0068646)
apv   
2017-07-24 18:26   
Dear BugMaster,

Please integrate branch CR28920 into the occt git-repository master.
Please integrate branch CR28920 into the products git-repository master.
(0068957)
git   
2017-07-31 17:46   
Branch CR28920 has been deleted by kgv.

SHA-1: b2150b7cc6888cf359aef365d91303f63d74d5f1