MantisBT - Open CASCADE
View Issue Details
0028908Open CASCADE[OCCT] OCCT:Application Frameworkpublic2017-07-11 08:562017-09-29 16:23
vro 
bugmaster 
normaltweak 
closedfixed 
WindowsVC++ 201032 bit
[OCCT] 7.1.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
bugs caf bug24755
0028908: Improvement on attachment of attributes to the label
Before Open CASCADE 7.0.0 the attributes were prepended to a list of attributes of a label. Later, they were appended. This improvement introduces a boolean flag to the method AddAttribute() to decide for each particular attribute whether it should be appended or prepended.

Some remarks:
A. Prepending some frequently used attributes may accelerate performance (access to the attributes).
B. Some attributes expect a predefined order of attributes at a label (for example, TDataXtd_Presentation and TPrsStd_AISPresentation). In this case appending of attributes is preferable because TPrsStd_AISPresentation is created later.
No need in a new special test. I re-used (and a little extended) an already existing test case "testgrid bugs caf bug24755" - it checks a sequence of attributes attached to a label.
No tags attached.
related to 0028946closed bugmaster Open CASCADE Exception on Undo 
related to 0028973closed bugmaster Open CASCADE Undo/Redo changes the order of some attributes 
related to 0029116verified bugmaster Community [Regression] OCAF attributes insertion order is violated again 
Issue History
2017-07-11 08:56vroNew Issue
2017-07-11 08:56vroAssigned To => vro
2017-07-11 11:27gitNote Added: 0068181
2017-07-13 09:15vroNote Added: 0068236
2017-07-13 09:18vroAssigned Tovro => mpv
2017-07-13 09:18vroStatusnew => resolved
2017-07-13 09:18vroSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17082#r17082
2017-07-14 12:36gitNote Added: 0068309
2017-07-14 13:03gitNote Added: 0068311
2017-07-18 09:56mpvAssigned Tompv => vro
2017-07-18 09:56mpvStatusresolved => assigned
2017-07-24 08:47gitNote Added: 0068622
2017-07-25 13:33mpvRelationship addedrelated to 0028946
2017-07-26 07:10vroNote Added: 0068701
2017-07-26 07:10vroAssigned Tovro => mpv
2017-07-26 07:10vroStatusassigned => resolved
2017-07-26 11:56mpvNote Added: 0068709
2017-07-26 11:56mpvAssigned Tompv => bugmaster
2017-07-26 11:56mpvStatusresolved => reviewed
2017-07-26 12:37apvAssigned Tobugmaster => apv
2017-07-26 13:54apvTest case number => bugs caf bug24755
2017-07-26 13:58apvNote Added: 0068719
2017-07-26 13:58apvAssigned Toapv => bugmaster
2017-07-26 13:58apvStatusreviewed => tested
2017-07-26 13:59apvNote Added: 0068720
2017-07-28 17:18bugmasterChangeset attached => occt master 0f3d1d7c
2017-07-28 17:18bugmasterStatustested => verified
2017-07-28 17:18bugmasterResolutionopen => fixed
2017-07-31 17:46gitNote Added: 0068954
2017-07-31 17:46gitNote Added: 0068955
2017-07-31 17:46gitNote Added: 0068956
2017-08-07 08:43vroRelationship addedrelated to 0028973
2017-09-15 14:52mpvRelationship addedrelated to 0029116
2017-09-29 16:17aivFixed in Version => 7.2.0
2017-09-29 16:23aivStatusverified => closed

Notes
(0068181)
git   
2017-07-11 11:27   
Branch CR28908 has been created by vro.

SHA-1: 14746559d8c815b06be2af491d839fc6d733fb7e


Detailed log of new commits:

Author: vro
Date: Tue Jul 11 11:27:33 2017 +0300

    0028908: Improvement on attachment of attributes to the label
(0068236)
vro   
2017-07-13 09:15   
http://jenkins-test-10.nnov.opencascade.com:8080/view/CR28908-master/view/TESTING/ [^]
(0068309)
git   
2017-07-14 12:36   
Branch CR28908 has been updated by vro.

SHA-1: 2c805aab167bec8ae66e4b572797e647c2df55aa


Detailed log of new commits:

Author: vro
Date: Fri Jul 14 12:35:50 2017 +0300

    The order of attributes in the label is synchronized on copying. Sometimes it is important (for presentation attributes, for example).

(0068311)
git   
2017-07-14 13:03   
Branch CR28908_1 has been created by vro.

SHA-1: f07703fc4cd248cb304c0a2dd4848a49f0554e9f


Detailed log of new commits:

Author: vro
Date: Fri Jul 14 13:02:44 2017 +0300

    A merged version.
(0068622)
git   
2017-07-24 08:47   
Branch CR28908_2 has been created by vro.

SHA-1: 1de833888b7fe743cfab4f513efade7ecd341bcf


Detailed log of new commits:

Author: vro
Date: Mon Jul 24 08:47:30 2017 +0300

    A merged version
(0068701)
vro   
2017-07-26 07:10   
http://jenkins-test-10.nnov.opencascade.com:8080/view/CR28908-master/view/COMPARE/ [^]
(0068709)
mpv   
2017-07-26 11:56   
Reviewed. Please, test.
(0068719)
apv   
2017-07-26 13:58   
Dear BugMaster,

Branch CR28908_2 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 1de833888b7fe743cfab4f513efade7ecd341bcf

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 8 (8 on master)
   Windows: 0 (0 on master)
   MacOS: 2 (2 on master)

Regressions/Differences:
Not detected

Testing cases:
bugs caf bug24755 - OK
http://occt-tests/CR28908-master-OCCT/Debian70-64/bugs/caf/bug24755.html [^]
http://occt-tests/CR28908-master-OCCT/Windows-64-VC10/bugs/caf/bug24755.html [^]

Testing on Linux:
Total MEMORY difference: 94192872 / 92039972 [+2.34%]
Total CPU difference: 19303.149999999983 / 19421.550000000127 [-0.61%]

Testing on Windows:
Total MEMORY difference: 55856386 / 55867730 [-0.02%]
Total CPU difference: 17959.864726598862 / 17810.271985598964 [+0.48%]
(0068720)
apv   
2017-07-26 13:59   
Dear BugMaster,

Please integrate branch CR28908_2 into the occt git-repository master.
(0068954)
git   
2017-07-31 17:46   
Branch CR28908 has been deleted by kgv.

SHA-1: 2c805aab167bec8ae66e4b572797e647c2df55aa
(0068955)
git   
2017-07-31 17:46   
Branch CR28908_1 has been deleted by kgv.

SHA-1: f07703fc4cd248cb304c0a2dd4848a49f0554e9f
(0068956)
git   
2017-07-31 17:46   
Branch CR28908_2 has been deleted by kgv.

SHA-1: 1de833888b7fe743cfab4f513efade7ecd341bcf