MantisBT - Open CASCADE
View Issue Details
0028862Open CASCADE[OCCT] OCCT:Application Frameworkpublic2017-06-22 15:302017-09-29 16:28
szy 
bugmaster 
normaltweak 
closedfixed 
[OCCT] 7.1.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
caf basic Y1, Y2
0028862: Unification of empty labels saving procedure
It is proposed to add a possibility to save empty labels to persistent file. By default empty labels will be removed (current default behavior). But in case of need a document designer can set a corresponding flag to inform document driver to save empty labels.
tests/caf/basic/Y1
tests/caf/basic/Y2
No tags attached.
Issue History
2017-06-22 15:30szyNew Issue
2017-06-22 15:30szyAssigned To => szy
2017-06-27 12:25szyStatusnew => assigned
2017-06-29 17:52gitNote Added: 0067818
2017-06-29 17:52szyTarget Version7.3.0 => 7.2.0
2017-07-26 19:00bugmasterNote Added: 0068755
2017-07-26 19:01gitNote Added: 0068756
2017-07-27 10:21szyNote Added: 0068764
2017-07-27 10:21szyAssigned Toszy => mpv
2017-07-27 10:21szyStatusassigned => resolved
2017-07-27 10:21szySteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17197#r17197
2017-07-27 11:22mpvAssigned Tompv => bugmaster
2017-07-27 11:22mpvStatusresolved => reviewed
2017-07-27 12:01mkvTest case number => caf basic Y1, Y2
2017-07-27 12:01mkvNote Added: 0068775
2017-07-27 12:01mkvStatusreviewed => tested
2017-07-27 12:01mkvNote Added: 0068776
2017-07-28 17:18bugmasterChangeset attached => occt master 030ba648
2017-07-28 17:18bugmasterStatustested => verified
2017-07-28 17:18bugmasterResolutionopen => fixed
2017-07-31 17:46gitNote Added: 0068952
2017-09-29 16:17aivFixed in Version => 7.2.0
2017-09-29 16:28aivStatusverified => closed

Notes
(0067818)
git   
2017-06-29 17:52   
Branch CR28862 has been created by szy.

SHA-1: 243697c327fd7d658838eefcb000ea8ec69bbaa8


Detailed log of new commits:

Author: szy
Date: Thu Jun 29 17:51:43 2017 +0300

    0028862: Unification of empty labels saving procedure.
    
    1.Added a possibility to save empty labels to a persistent document in case of need.
    // modified classes: TDocStd_Document, BinLDrivers_DocumentStorageDriver, XmlMDF, DDocStd_ApplicationCommands
    // 2 new test cases: caf/basic/Y1, caf/basic/Y2
(0068755)
bugmaster   
2017-07-26 19:00   
Sergey,

Please rebase you branches on current master !!!!!!
Otherwise you always you have different problem

I rebased CR28862 to master and restart branch certification
(0068756)
git   
2017-07-26 19:01   
Branch CR28862 has been updated forcibly by inv.

SHA-1: a7fd3b5aa9087b56a33962efac621497f5056903
(0068764)
szy   
2017-07-27 10:21   
Review, please.
http://jenkins-test-10.nnov.opencascade.com:8080/view/CR28862-master/ [^]
(0068775)
mkv   
2017-07-27 12:01   
Dear BugMaster,
Branch CR28862 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: a7fd3b5aa9087b56a33962efac621497f5056903

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 8 (8 on master)
Windows: 0 (0 on master)
MacOS : 2 (2 on master)

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
http://occt-tests/CR28862-master-OCCT/Debian70-64/caf/basic/Y1.html [^]
http://occt-tests/CR28862-master-OCCT/Windows-64-VC10/caf/basic/Y1.html [^]
caf basic Y1: OK
http://occt-tests/CR28862-master-OCCT/Debian70-64/caf/basic/Y2.html [^]
http://occt-tests/CR28862-master-OCCT/Windows-64-VC10/caf/basic/Y2.html [^]
caf basic Y2: OK

Testing on Linux:
occt component :
Total CPU difference: 19290.960000000006 / 19421.550000000127 [-0.67%]
Total MEMORY difference: 92231370 / 92044100 [+0.20%]
products component :
Total CPU difference: 6518.730000000052 / 6527.870000000079 [-0.14%]
Total MEMORY difference: 38181568 / 38296461 [-0.30%]
Testing on Windows:
occt component :
Total CPU difference: 18741.694938298722 / 17810.05696629893 [+5.23%]
Total MEMORY difference: 59117373 / 59120758 [-0.01%]
products component :
Total CPU difference: 6722.239090999996 / 6662.319106899978 [+0.90%]
Total MEMORY difference: 29050966 / 28992682 [+0.20%]

There are no differences in images found by testdiff.
(0068776)
mkv   
2017-07-27 12:01   
Dear BugMaster,
Branch CR28862 from occt git-repository is TESTED.
(0068952)
git   
2017-07-31 17:46   
Branch CR28862 has been deleted by kgv.

SHA-1: a7fd3b5aa9087b56a33962efac621497f5056903