MantisBT - Community
View Issue Details
0028852Community[OCCT] OCCT:Application Frameworkpublic2017-06-19 10:552017-09-29 16:28
BenjaminBihler 
bugmaster 
normaltext 
closedfixed 
 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028852: TDF_AttributeIterator should not be marked as "handle with care"
The header discourages from using TDF_AttributeIterator, but there seems to be no valid reason for that (see https://www.opencascade.com/content/should-tdfattributeiterator-be-handled-care [^]).
Not required
No tags attached.
Issue History
2017-06-19 10:55BenjaminBihlerNew Issue
2017-06-19 10:55BenjaminBihlerAssigned To => BenjaminBihler
2017-06-19 12:44gitNote Added: 0067512
2017-06-19 12:44BenjaminBihlerAssigned ToBenjaminBihler => abv
2017-06-19 12:44BenjaminBihlerStatusnew => resolved
2017-06-19 12:44BenjaminBihlerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16924#r16924
2017-06-19 12:49kgvCategoryOCCT:Foundation Classes => OCCT:Application Framework
2017-06-19 12:49kgvAssigned Toabv => mpv
2017-06-20 12:14gitNote Added: 0067532
2017-06-20 12:15mpvAssigned Tompv => szy
2017-06-20 12:15mpvNote Added: 0067533
2017-06-20 13:50BenjaminBihlerNote Added: 0067535
2017-06-20 14:12kgvNote Added: 0067537
2017-06-20 16:48gitNote Added: 0067546
2017-06-20 16:50mpvNote Added: 0067548
2017-06-22 10:07szyNote Added: 0067579
2017-06-22 10:07szyAssigned Toszy => bugmaster
2017-06-22 10:07szyStatusresolved => reviewed
2017-06-22 10:26apvTest case number => Not needed
2017-06-22 10:26apvNote Added: 0067581
2017-06-22 10:26apvStatusreviewed => tested
2017-06-22 10:27apvNote Edited: 0067581bug_revision_view_page.php?bugnote_id=67581#r16934
2017-06-23 12:25bugmasterChangeset attached => occt master c1a688e9
2017-06-23 12:25bugmasterStatustested => verified
2017-06-23 12:25bugmasterResolutionopen => fixed
2017-07-03 08:45gitNote Added: 0067896
2017-07-03 08:45gitNote Added: 0067897
2017-09-29 16:18aivFixed in Version => 7.2.0
2017-09-29 16:28aivStatusverified => closed

Notes
(0067512)
git   
2017-06-19 12:44   
Branch CR28852 has been created by BenjaminBihler.

SHA-1: ff9a1b77702f22a2523e878de728cae597da5202


Detailed log of new commits:

Author: Benjamin Bihler
Date: Mon Jun 19 11:42:23 2017 +0200

    0028852: TDF_AttributeIterator should not be marked as "handle with care"
    
    Warning lines have been removed.
(0067532)
git   
2017-06-20 12:14   
Branch CR28852 has been updated by mpv.

SHA-1: 645f2a589e20a118c4aa398f7ec90512fd8cf47f


Detailed log of new commits:

Author: mpv
Date: Tue Jun 20 12:14:14 2017 +0300

    0028852: TDF_AttributeIterator should not be marked as "handle with care"
    
    Make "Value" method of the iterator return Handle (instead of pointer) to unify public interfaces (since this class now may be used as public).
    
    Simplified implementation of the iterator with Handle myValue field.
    
    Added comment about usage of this class.

(0067533)
mpv   
2017-06-20 12:15   
Dear szy,

Could you review my extra fix for this issue.
(0067535)
BenjaminBihler   
2017-06-20 13:50   
Dear mpv,
I have created another issue for making the "Value" method of the iterator return handle instead of pointer, but unfortunately I have chosen the wrong category: it is issue 0028853.
Benjamin
(0067537)
kgv   
2017-06-20 14:12   
-inline TDF_Attribute * TDF_AttributeIterator::Value() const
+inline Handle(TDF_Attribute) TDF_AttributeIterator::Value() const
 { return myValue; }

Why not "const Handle(TDF_Attribute)&"?
(0067546)
git   
2017-06-20 16:48   
Branch CR28852_2 has been created by mpv.

SHA-1: 25a65a8ade9a45f286bdeb29c02623d3202f960c


Detailed log of new commits:

Author: mpv
Date: Tue Jun 20 16:47:48 2017 +0300

    0028852: TDF_AttributeIterator should not be marked as "handle with care"
    
    Warning lines have been removed.
    Added a comment about usage of this class.
(0067548)
mpv   
2017-06-20 16:50   
Please, use branch CR28852_2 for review.

No tests are required, since it is only change in comments.
(0067579)
szy   
2017-06-22 10:07   
Reviewed.
(0067581)
apv   
2017-06-22 10:26   
(edited on: 2017-06-22 10:27)
Dear BugMaster,

Please integrate branch CR28852_2 into the occt git-repository master.

(0067896)
git   
2017-07-03 08:45   
Branch CR28852 has been deleted by kgv.

SHA-1: 645f2a589e20a118c4aa398f7ec90512fd8cf47f
(0067897)
git   
2017-07-03 08:45   
Branch CR28852_2 has been deleted by kgv.

SHA-1: 25a65a8ade9a45f286bdeb29c02623d3202f960c