MantisBT - Open CASCADE
View Issue Details
0028778Open CASCADE[OCCT] OCCT:Codingpublic2017-05-23 18:132017-09-29 16:25
kgv 
bugmaster 
normaltrivial 
closedfixed 
[OCCT] 7.1.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028778: Coding Rules - clean up confusing code from Select3D
Select3D_SensitivePoly defines the following ill-formed code which should be cleared:
Standard_Real Select3D_SensitivePoly::Center (const Standard_Integer theIdx,
                                              const Standard_Integer theAxis) const
{
..
  const SelectMgr_Vec3& aCenter = (aBndBox.CornerMin() + aBndBox.CornerMax()) * 0.5;
N/A
No tags attached.
related to 0028789closed bugmaster Visualization, TKV3d - extend API for accessing and assigning BVH builders 
Issue History
2017-05-23 18:13kgvNew Issue
2017-05-23 18:13kgvAssigned To => kgv
2017-05-23 19:06gitNote Added: 0066495
2017-05-23 19:06kgvNote Added: 0066496
2017-05-23 19:06kgvAssigned Tokgv => bugmaster
2017-05-23 19:06kgvStatusnew => resolved
2017-05-23 19:06kgvStatusresolved => reviewed
2017-05-24 12:19mkvAssigned Tobugmaster => mkv
2017-05-25 11:32mkvNote Added: 0066550
2017-05-25 11:32mkvNote Added: 0066551
2017-05-25 11:32mkvAssigned Tomkv => bugmaster
2017-05-25 11:32mkvStatusreviewed => tested
2017-05-25 11:33mkvTest case number => Not needed
2017-05-26 10:51kgvRelationship addedrelated to 0028789
2017-05-26 14:28bugmasterChangeset attached => occt master 14077ce9
2017-05-26 14:29bugmasterStatustested => verified
2017-05-26 14:29bugmasterResolutionopen => fixed
2017-05-26 14:56bugmasterChangeset attached => occt master 0609d8ee
2017-05-29 16:06gitNote Added: 0066785
2017-09-29 16:18aivFixed in Version => 7.2.0
2017-09-29 16:25aivStatusverified => closed

Notes
(0066495)
git   
2017-05-23 19:06   
Branch CR28778 has been created by kgv.

SHA-1: cf1ba97e6cb9fb0696658382a62a5a82b0e5d23c


Detailed log of new commits:

Author: kgv
Date: Tue May 23 19:05:41 2017 +0300

    0028778: Coding Rules - clean up confusing code from Select3D
(0066496)
kgv   
2017-05-23 19:06   
Please test the patch.
(0066550)
mkv   
2017-05-25 11:32   
Dear BugMaster,
Branch CR28778 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: cf1ba97e6cb9fb0696658382a62a5a82b0e5d23c

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1181

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 91947520 / 91629864 [+0.35%]
Total CPU difference: 18889.25000000024 / 18660.720000000343 [+1.22%]
products component :
Total MEMORY difference: 31354184 / 31347866 [+0.02%]
Total CPU difference: 5420.529999999986 / 5401.239999999972 [+0.36%]
Testing on Windows:
occt component :
Total MEMORY difference: 58429529 / 58426283 [+0.01%]
Total CPU difference: 17660.124405198585 / 17319.43382129878 [+1.97%]
products component :
Total MEMORY difference: 22719513 / 22681228 [+0.17%]
Total CPU difference: 5407.041460299969 / 5370.256424499971 [+0.68%]

There are no differences in images found by testdiff.
(0066551)
mkv   
2017-05-25 11:32   
Dear BugMaster,
Branch CR28778 is TESTED.
(0066785)
git   
2017-05-29 16:06   
Branch CR28778 has been deleted by kgv.

SHA-1: cf1ba97e6cb9fb0696658382a62a5a82b0e5d23c