MantisBT - Open CASCADE
View Issue Details
0028744Open CASCADE[OCCT] OCCT:Visualizationpublic2017-05-16 13:062017-09-29 16:25
bugmaster 
bugmaster 
normalminor 
closedfixed 
[OCCT] 7.3.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028744: Visualization, OpenGl_FrameBuffer - handle GL_RGB8 format
Function getColorDataFormat does not handling GL_RGB8 and GL_RGB formats.
Not required
No tags attached.
related to 0028758closed bugmaster Visualization - Implement exporting generated image to HRD/EXR images 
Issue History
2017-05-16 13:06user815New Issue
2017-05-16 13:06user815Assigned To => user815
2017-05-16 13:06user815Statusnew => assigned
2017-05-16 13:16gitNote Added: 0066137
2017-05-16 13:18user815Note Added: 0066138
2017-05-16 13:18user815Assigned Touser815 => apl
2017-05-16 13:18user815Statusassigned => resolved
2017-05-16 13:18user815Steps to Reproduce Updatedbug_revision_view_page.php?rev_id=16627#r16627
2017-05-16 13:53kgvNote Added: 0066142
2017-05-16 13:53kgvNote Edited: 0066142bug_revision_view_page.php?bugnote_id=66142#r16631
2017-05-16 20:24kgvSummaryVisualization, OpenGl_FrameBuffer missing GL_RGB8 format => Visualization, OpenGl_FrameBuffer - handle GL_RGB8 format
2017-05-17 14:18gitNote Added: 0066195
2017-05-17 14:20user815Note Added: 0066196
2017-05-17 19:15gitNote Added: 0066228
2017-05-17 19:17aplNote Added: 0066229
2017-05-17 19:17aplAssigned Toapl => bugmaster
2017-05-17 19:17aplStatusresolved => reviewed
2017-05-17 19:32apvAssigned Tobugmaster => apv
2017-05-18 14:56kgvRelationship addedrelated to 0028758
2017-05-19 13:35bugmasterReporteruser815 => bugmaster
2017-05-19 15:45apvTest case number => Not needed
2017-05-19 15:51apvNote Added: 0066331
2017-05-19 15:51apvAssigned Toapv => bugmaster
2017-05-19 15:51apvStatusreviewed => tested
2017-05-19 15:52apvNote Added: 0066332
2017-05-26 14:28bugmasterChangeset attached => occt master 58772a28
2017-05-26 14:29bugmasterStatustested => verified
2017-05-26 14:29bugmasterResolutionopen => fixed
2017-05-29 16:06gitNote Added: 0066777
2017-05-29 16:06gitNote Added: 0066778
2017-09-29 16:18aivFixed in Version => 7.2.0
2017-09-29 16:25aivStatusverified => closed

Notes
(0066137)
git   
2017-05-16 13:16   
Branch CR28744 has been created by Andrey GOLODAEV.

SHA-1: f58ead146592cf4dbe9c22f1278481a1476d6f99


Detailed log of new commits:

Author: age
Date: Tue May 16 13:12:50 2017 +0300

    0028744: Visualization, OpenGl_FrameBuffer missing GL_RGB8 format
    
    Missing GL_RGB8 and GL_RGB formats added to getColorDataFormat function.
(0066138)
user815   
2017-05-16 13:18   
Dear apl,

Please review the patch in branch CR28744.
(0066142)
kgv   
2017-05-16 13:53   
+      case GL_RGB8:
+      {
+        thePixelFormat = GL_RGB;
+        theDataType = GL_UNSIGNED_INT;

I think GL_RGB8 should be the same as GL_RGB (e.g. GL_UNSIGNED_BYTE),
as well as GL_RGBA8/GL_RGBA - don't get where GL_UNSIGNED_INT is coming from.

(0066195)
git   
2017-05-17 14:18   
Branch CR28744 has been updated by Andrey GOLODAEV.

SHA-1: a543341d5a99ffeda8a8ba6aaf58499999d22563


Detailed log of new commits:

Author: age
Date: Wed May 17 14:16:14 2017 +0300

    0028744: Visualization, OpenGl_FrameBuffer - handle GL_RGB8 format
    
    Joined GL_RGB8 with GL_RGB, GL_RGBA8 with GL_RGBA - changed format to GL_UNSIGNED_BYTE

(0066196)
user815   
2017-05-17 14:20   
Changed GL_RGB8 and GL_RGBA8 format to GL_UNSIGNED_BYTE
(0066228)
git   
2017-05-17 19:15   
Branch CR28744_1 has been created by apl.

SHA-1: 4b28aa79bd68445c6ff68736ce9c8ac5edae7095


Detailed log of new commits:

Author: age
Date: Tue May 16 13:12:50 2017 +0300

    0028744: Visualization, OpenGl_FrameBuffer missing GL_RGB8 format
    
    Missing GL_RGB8 and GL_RGB formats added to getColorDataFormat function.
(0066229)
apl   
2017-05-17 19:17   
Dear bugmaster,

The branch been squashed into a single commit.

Please test CR28744_1.
(0066331)
apv   
2017-05-19 15:51   
Dear BugMaster,

Branch CR28744_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 4b28aa79bd68445c6ff68736ce9c8ac5edae7095

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1195

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 92972287 / 91776192 [+1.30%]
Total CPU difference: 18776.400000000238 / 18651.980000000363 [+0.67%]

Testing on Windows:
Total MEMORY difference: 58427012 / 58426407 [+0.00%]
Total CPU difference: 17604.22924689861 / 17338.309942298663 [+1.53%]
(0066332)
apv   
2017-05-19 15:52   
Dear BugMaster,

Please integrate branch CR28744_1 into the occt git-repository master.
(0066777)
git   
2017-05-29 16:06   
Branch CR28744 has been deleted by kgv.

SHA-1: a543341d5a99ffeda8a8ba6aaf58499999d22563
(0066778)
git   
2017-05-29 16:06   
Branch CR28744_1 has been deleted by kgv.

SHA-1: 4b28aa79bd68445c6ff68736ce9c8ac5edae7095