MantisBT - Open CASCADE
View Issue Details
0028704Open CASCADE[OCCT] OCCT:Codingpublic2017-05-02 08:592017-09-29 16:25
kgv 
mkv 
normalintegration request 
closedfixed 
 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028704: Coding Rules - recommend adding the class header first in its source file
It is usual practice to put class header file first in its source file, however the current coding rules do not clarify it.

This simplifies source file identification and helps implicitly validate header file to avoid common C++ problem - missed inclusion of header files by header file.
N/A
No tags attached.
Issue History
2017-05-02 08:59kgvNew Issue
2017-05-02 08:59kgvAssigned To => kgv
2017-05-02 09:09gitNote Added: 0065662
2017-05-02 09:09kgvNote Added: 0065663
2017-05-02 09:09kgvAssigned Tokgv => abv
2017-05-02 09:09kgvStatusnew => resolved
2017-05-03 16:38abvNote Added: 0065727
2017-05-03 16:38abvAssigned Toabv => bugmaster
2017-05-03 16:38abvStatusresolved => reviewed
2017-05-03 18:09mkvNote Added: 0065730
2017-05-03 18:09mkvAssigned Tobugmaster => ysn
2017-05-03 18:09mkvStatusreviewed => feedback
2017-05-11 15:21ysnAssigned Toysn => mkv
2017-05-11 15:21ysnNote Added: 0065833
2017-05-11 15:21ysnAssigned Tomkv => bugmaster
2017-05-11 15:21ysnStatusfeedback => reviewed
2017-05-11 15:55gitNote Added: 0065834
2017-05-11 15:56mkvStatusreviewed => tested
2017-05-11 15:56mkvTest case number => Not needed
2017-05-11 15:57mkvNote Added: 0065835
2017-05-19 13:25mkvChangeset attached => occt master 629362c6
2017-05-19 13:25mkvAssigned Tobugmaster => mkv
2017-05-19 13:25mkvStatustested => verified
2017-05-19 13:25mkvResolutionopen => fixed
2017-05-29 16:06gitNote Added: 0066763
2017-09-29 16:18aivFixed in Version => 7.2.0
2017-09-29 16:25aivStatusverified => closed

Notes
(0065662)
git   
2017-05-02 09:09   
Branch CR28704 has been created by kgv.

SHA-1: bcfe48e60192f639f9cb13c164a00d53f374147c


Detailed log of new commits:

Author: kgv
Date: Tue May 2 09:09:27 2017 +0300

    0028704: Coding Rules - recommend adding the class header first in its source file
(0065663)
kgv   
2017-05-02 09:09   
Patch is ready for review.
(0065727)
abv   
2017-05-03 16:38   
No remarks, please integrate - no testing is needed
(0065730)
mkv   
2017-05-03 18:09   
Dear ysn,
could you please review.
(0065833)
ysn   
2017-05-11 15:21   
I have no remarks.
(0065834)
git   
2017-05-11 15:55   
Branch CR28704 has been updated forcibly by mkv.

SHA-1: 629362c6fafe99973b355730e2b677f716c73d2c
(0065835)
mkv   
2017-05-11 15:57   
TESTED.
(0066763)
git   
2017-05-29 16:06   
Branch CR28704 has been deleted by kgv.

SHA-1: 629362c6fafe99973b355730e2b677f716c73d2c