MantisBT - Open CASCADE
View Issue Details
0028646Open CASCADE[OCCT] OCCT:DRAWpublic2017-04-11 11:392017-09-29 16:25
kgv 
abv 
normalintegration request 
closedfixed 
[OCCT] 7.2.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028646: Draw Harness, ViewerTest - rename vsetfilter command with vselfilter
#0028365 introduced new command vsetfilter for testing selection filters.
However the command name sounds misnamed - vselfilter would be more expected since command is related to selection.
No tags attached.
Issue History
2017-04-11 11:39kgvNew Issue
2017-04-11 11:39kgvAssigned To => kgv
2017-04-11 11:40kgvRelationship addedchild of 0028365
2017-05-16 16:37gitNote Added: 0066153
2017-05-16 16:37kgvNote Added: 0066154
2017-05-16 16:37kgvAssigned Tokgv => bugmaster
2017-05-16 16:37kgvStatusnew => resolved
2017-05-16 16:38kgvStatusresolved => reviewed
2017-05-16 16:59apvAssigned Tobugmaster => apv
2017-05-17 16:56apvTest case number => Not needed
2017-05-17 16:59apvNote Added: 0066216
2017-05-17 16:59apvAssigned Toapv => kgv
2017-05-17 16:59apvStatusreviewed => assigned
2017-05-17 17:01apvNote Added: 0066217
2017-05-17 17:22gitNote Added: 0066219
2017-05-17 17:22kgvNote Added: 0066220
2017-05-17 17:22kgvAssigned Tokgv => bugmaster
2017-05-17 17:22kgvStatusassigned => resolved
2017-05-17 17:22kgvStatusresolved => reviewed
2017-05-17 17:38apvAssigned Tobugmaster => apv
2017-05-18 13:49apvNote Added: 0066262
2017-05-18 13:49apvAssigned Toapv => bugmaster
2017-05-18 13:49apvStatusreviewed => tested
2017-05-19 13:25abvChangeset attached => occt master d2e60688
2017-05-19 13:25abvAssigned Tobugmaster => abv
2017-05-19 13:25abvStatustested => verified
2017-05-19 13:25abvResolutionopen => fixed
2017-05-29 16:05gitNote Added: 0066760
2017-09-29 16:18aivFixed in Version => 7.2.0
2017-09-29 16:25aivStatusverified => closed

Notes
(0066153)
git   
2017-05-16 16:37   
Branch CR28646 has been created by kgv.

SHA-1: d194e090b47eb95b65be6e9b21ad1726eb967d5e


Detailed log of new commits:

Author: kgv
Date: Tue May 16 16:37:18 2017 +0300

    0028646: Draw Harness, ViewerTest - rename vsetfilter command with vselfilter
    
    TopAbs::ShapeTypeToString() is now used instead of duplicating TopAbs_ShapeEnum printing code.
    vselmode now accepts shape type string for activating standard AIS_Shape selection modes.
(0066154)
kgv   
2017-05-16 16:37   
Please test the patch.
(0066216)
apv   
2017-05-17 16:59   
Dear BugMaster,

Branch CR28646 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: d194e090b47eb95b65be6e9b21ad1726eb967d5e

Number of compiler warnings:
occt component:
   Linux: 1 (0 on master)
   Windows: 1 (0 on master)
   MasOS: 1 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1192

New warning has been detected during OCCT component building
on Linux:
http://jenkins-test-05.nnov.opencascade.com/view/CR28646-master/job/CR28646-master-OCCT-Debian70-64-opt-compile/1/warnings19Result/ [^]
on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR28646-master/job/CR28646-master-OCCT-Windows-64-VC10-opt-compile/2/warnings38Result/ [^]
on MacOS:
http://jenkins-test-05.nnov.opencascade.com/view/CR28646-master/job/CR28646-master-OCCT-MacOS-opt-compile/1/warnings8Result/ [^]

Regressions/Differences:
http://occt-tests/CR28646-master-OCCT/Debian70-64/summary.html [^]
http://occt-tests/CR28646-master-OCCT/Windows-64-VC10/summary.html [^]
bugs vis bug12121

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 92279461 / 91759353 [+0.57%]
Total CPU difference: 18808.670000000246 / 18651.250000000364 [+0.84%]

Testing on Windows:
Total MEMORY difference: 58422506 / 58423846 [-0.00%]
Total CPU difference: 17466.152761798672 / 17338.185141498663 [+0.74%]
(0066217)
apv   
2017-05-17 17:01   
Dear Kirill,

Branch CR28646 has been rejected due to:
- additional warnings
- regressions/differences/improvements
(0066219)
git   
2017-05-17 17:22   
Branch CR28646 has been updated by kgv.

SHA-1: cd6f97c6b803b15f42a90bed4f29efb8173a8b3c


Detailed log of new commits:

Author: kgv
Date: Wed May 17 17:21:53 2017 +0300

    // fix error in test script and compiler warning

(0066220)
kgv   
2017-05-17 17:22   
Please check updated patch (only modified test case can be re-checked).
(0066262)
apv   
2017-05-18 13:49   
Dear BugMaster,

Branch CR28646 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: cd6f97c6b803b15f42a90bed4f29efb8173a8b3c

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1183

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 92335574 / 91777456 [+0.61%]
Total CPU difference: 18751.12000000032 / 18651.940000000362 [+0.53%]

Testing on Windows:
Total MEMORY difference: 58421648 / 58423846 [-0.00%]
Total CPU difference: 17444.14102069858 / 17338.185141498663 [+0.61%]
(0066760)
git   
2017-05-29 16:05   
Branch CR28646 has been deleted by kgv.

SHA-1: cd6f97c6b803b15f42a90bed4f29efb8173a8b3c