MantisBT - Open CASCADE
View Issue Details
0028601Open CASCADE[OCCT] OCCT:Shape Healingpublic2017-03-28 11:422017-09-29 16:25
msv 
bugmaster 
normalminor 
closedfixed 
[OCCT] 7.1.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
bugs modalg_6 bug28601
0028601: ShapeFix_Shape increases tolerance of sub-shapes of a valid shape
Even for a valid shape like box the command fixshape increases tolerance of vertices and edges.
And if we repeat fixshape on the result it again increases tolerances.
box b 10 10 10
tolerance b

# Initial tolerances:
#Tolerance MAX=9.9999999999999995e-008 AVG=9.9999999999999995e-008 MIN=9.9999999999999995e-008
#FACE : MAX=9.9999999999999995e-008 AVG=9.9999999999999995e-008 MIN=9.9999999999999995e-008
#EDGE : MAX=9.9999999999999995e-008 AVG=9.9999999999999995e-008 MIN=9.9999999999999995e-008
#VERTEX : MAX=9.9999999999999995e-008 AVG=9.9999999999999995e-008 MIN=9.9999999999999995e-008

fixshape b1 b
tolerance b1

# Result tolerances:
#Tolerance MAX=1.0001000025000001e-007 AVG=1.0000923099999988e-007 MIN=9.9999999999999995e-008
#FACE : MAX=9.9999999999999995e-008 AVG=9.9999999999999995e-008 MIN=9.9999999999999995e-008
#EDGE : MAX=1.0001000025000001e-007 AVG=1.0001000025000001e-007 MIN=1.0001000025000001e-007
#VERTEX : MAX=1.0001000025000001e-007 AVG=1.0001000025000001e-007 MIN=1.0001000025000001e-007

fixshape b2 b1
tolerance b2

# Next result tolerances:
Tolerance MAX=1.0002000150005004e-007 AVG=1.0001846292312312e-007 MIN=9.9999999999999995e-008
FACE : MAX=9.9999999999999995e-008 AVG=9.9999999999999995e-008 MIN=9.9999999999999995e-008
EDGE : MAX=1.0002000150005004e-007 AVG=1.0002000150005004e-007 MIN=1.0002000150005004e-007
VERTEX : MAX=1.0002000150005004e-007 AVG=1.0002000150005004e-007 MIN=1.0002000150005004e-007
No tags attached.
related to 0028602assigned isn Prevent ShapeFix_Shape to modify the input shape 
Issue History
2017-03-28 11:42msvNew Issue
2017-03-28 11:42msvAssigned To => gka
2017-03-28 11:49msvRelationship addedrelated to 0028602
2017-04-04 16:19msvAssigned Togka => imn
2017-04-04 16:19msvStatusnew => assigned
2017-04-14 15:17gitNote Added: 0065230
2017-04-14 15:21imnNote Added: 0065231
2017-04-14 15:21imnAssigned Toimn => msv
2017-04-14 15:21imnStatusassigned => resolved
2017-04-18 09:57msvNote Added: 0065279
2017-04-18 09:57msvAssigned Tomsv => imn
2017-04-18 09:57msvStatusresolved => assigned
2017-04-18 11:41gitNote Added: 0065282
2017-04-18 11:44imnNote Added: 0065283
2017-04-18 11:44imnAssigned Toimn => msv
2017-04-18 11:44imnStatusassigned => resolved
2017-04-18 14:48msvNote Added: 0065295
2017-04-18 14:48msvAssigned Tomsv => bugmaster
2017-04-18 14:48msvStatusresolved => reviewed
2017-04-18 15:42mkvAssigned Tobugmaster => mkv
2017-04-19 19:37mkvNote Added: 0065368
2017-04-19 19:38gitNote Added: 0065369
2017-04-19 19:38mkvNote Added: 0065370
2017-04-19 19:38mkvNote Added: 0065371
2017-04-19 19:38mkvAssigned Tomkv => imn
2017-04-19 19:38mkvStatusreviewed => feedback
2017-04-19 19:39mkvTest case number => bugs modalg_6 bug28601
2017-04-20 16:07imnNote Added: 0065401
2017-04-20 16:07imnAssigned Toimn => msv
2017-04-20 16:07imnStatusfeedback => resolved
2017-04-20 16:07imnStatusresolved => feedback
2017-04-20 16:54msvNote Added: 0065405
2017-04-20 16:55msvAssigned Tomsv => mkv
2017-04-20 16:56msvNote Added: 0065406
2017-04-21 17:20mkvNote Added: 0065433
2017-04-21 17:20mkvAssigned Tomkv => bugmaster
2017-04-21 17:20mkvStatusfeedback => tested
2017-04-28 13:08bugmasterChangeset attached => occt master 0af424c2
2017-04-28 13:08bugmasterStatustested => verified
2017-04-28 13:08bugmasterResolutionopen => fixed
2017-05-12 11:36gitNote Added: 0065944
2017-05-12 11:36gitNote Added: 0065945
2017-09-29 16:19aivFixed in Version => 7.2.0
2017-09-29 16:25aivStatusverified => closed

Notes
(0065230)
git   
2017-04-14 15:17   
Branch CR28601 has been created by imn.

SHA-1: c45b9971d94cc97e4aa3003a801e0793c8e10978


Detailed log of new commits:

Author: imn
Date: Fri Apr 14 15:15:18 2017 +0300

    0028601: ShapeFix_Shape increases tolerance of sub-shapes of a valid shape
    - If tolerance hasn't been changed then 'fixshape' will not change it.
(0065231)
imn   
2017-04-14 15:21   
Dear Mikhail, could you please review CR28601.
(0065279)
msv   
2017-04-18 09:57   
Remarks:

- Change commit message:
Avoid increase of edge/vertex tolerance if the distance between 3D curve and p-curve is within old tolerance.

src\ShapeFix\ShapeFix.cxx
- Avoid unneeded computation (line 227) if isChanged is false.

tests\bugs\modalg_6\bug28601
- remove 'checkview' command, as the picture does not contain anything worth to check.
- remove tab characters in the file and align lines properly.
(0065282)
git   
2017-04-18 11:41   
Branch CR28601_1 has been created by imn.

SHA-1: 3629d44c0138bb1fe00f3e38562ae813d431c357


Detailed log of new commits:

Author: imn
Date: Fri Apr 14 15:15:18 2017 +0300

    0028601: ShapeFix_Shape increases tolerance of sub-shapes of a valid shape
    - Avoid increase of edge/vertex tolerance if the distance between 3D curve and p-curve is within old tolerance.
(0065283)
imn   
2017-04-18 11:44   
Dear Mikhail, could you please review CR28601_1, branch is updated according to remarks
(0065295)
msv   
2017-04-18 14:48   
Reviewed.
(0065368)
mkv   
2017-04-19 19:37   
Dear BugMaster,
Branch CR28601_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 3629d44c0138bb1fe00f3e38562ae813d431c357

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1209

Regressions/Differences/Improvements:
http://occt-tests/CR28601_1-master-OCCT/Debian70-64/bugs/heal/bug329.html [^]
http://occt-tests/CR28601_1-master-OCCT/Windows-64-VC10/bugs/heal/bug329.html [^]
Improvements:
  bugs heal bug329

Testing cases:
http://occt-tests/CR28601_1-master-OCCT/Debian70-64/bugs/modalg_6/bug28601.html [^]
http://occt-tests/CR28601_1-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug28601.html [^]
bugs modalg_6 bug28601: OK

Testing on Linux:
occt component :
Total MEMORY difference: 91811326 / 90701406 [+1.22%]
Total CPU difference: 19810.100000000286 / 19728.26000000033 [+0.41%]
products component :
Total MEMORY difference: 30349096 / 30341918 [+0.02%]
Total CPU difference: 5370.089999999985 / 5356.299999999965 [+0.26%]
Testing on Windows:
occt component :
Total MEMORY difference: 57806030 / 57804189 [+0.00%]
Total CPU difference: 18296.09368189848 / 18136.473458698543 [+0.88%]
products component :
Total MEMORY difference: 22303813 / 22265369 [+0.17%]
Total CPU difference: 5365.669995099962 / 5359.788757399982 [+0.11%]

There are following differences in images found by testdiff.
http://occt-tests/CR28601_1-master-Products/Debian70-64/diff-Debian70-64.html [^]
http://occt-tests/CR28601_1-master-Products/Windows-64-VC10/diff-Windows-64-VC10-image.html [^]
IMAGE sat doc_6 H4: H4.png differs
(0065369)
git   
2017-04-19 19:38   
Branch CR28601_1 has been updated by mkv.

SHA-1: c7d56f462b5a8407dd37c6907f898087885f1bce


Detailed log of new commits:

Author: mkv
Date: Wed Apr 19 19:37:27 2017 +0300

    // Small correction of test case for issue CR28601

(0065370)
mkv   
2017-04-19 19:38   
Dear BugMaster,
Test case bugs/heal/bug329 was corrected and pushed to branch CR28601_1, now it is OK.
(0065371)
mkv   
2017-04-19 19:38   
Dear imn,
Branch CR28601_1 has been rejected due to:
- differences in images
(0065401)
imn   
2017-04-20 16:07   
Differences in images are due to losses of curves during read/write source file. Now 4 more curves, which source shape contains, is founded and displayed, it's improvement.
(0065405)
msv   
2017-04-20 16:54   
I agree, please test.
(0065406)
msv   
2017-04-20 16:56   
Sorry, already tested, so integrate.
(0065433)
mkv   
2017-04-21 17:20   
Dear BugMaster,
Branch CR28601_1 is TESTED.
(0065944)
git   
2017-05-12 11:36   
Branch CR28601 has been deleted by kgv.

SHA-1: c45b9971d94cc97e4aa3003a801e0793c8e10978
(0065945)
git   
2017-05-12 11:36   
Branch CR28601_1 has been deleted by kgv.

SHA-1: c7d56f462b5a8407dd37c6907f898087885f1bce