MantisBT - Open CASCADE
View Issue Details
0028562Open CASCADE[OCCT] OCCT:Modeling Algorithmspublic2017-03-16 16:212017-09-29 16:25
emv 
bugmaster 
normalminor 
closedfixed 
[OCCT] 7.1.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028562: Replacement of old Boolean operations (BRepAlgo) with new ones (BRepAlgoAPI) in BRepAlgo_NormalProjection
The issue is intended to transferring of the BRepAlgo_NormalProjection algorithm from old Boolean operations (BRepAlgo) to new ones (BRepAlgoAPI).
Not needed.
No tags attached.
related to 0028575assigned emv Open CASCADE Removal of the old Boolean Operations algorithm - BRepAlgo_BooleanOperation 
related to 0027279assigned ifv Community BRepOffsetAPI_NormalProjection fails to project an edge on a face 
Issue History
2017-03-16 16:21emvNew Issue
2017-03-16 16:21emvAssigned To => msv
2017-03-16 16:21emvAssigned Tomsv => emv
2017-03-16 16:21emvStatusnew => assigned
2017-03-16 16:22emvRelationship addedrelated to 0025731
2017-03-16 18:13TimoRelationship addedrelated to 0027279
2017-03-17 13:57gitNote Added: 0064394
2017-03-17 13:58emvNote Added: 0064395
2017-03-17 13:58emvAssigned Toemv => msv
2017-03-17 13:58emvStatusassigned => resolved
2017-03-17 13:58emvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16229#r16229
2017-03-17 19:22msvNote Added: 0064417
2017-03-17 19:22msvAssigned Tomsv => bugmaster
2017-03-17 19:22msvStatusresolved => reviewed
2017-03-17 19:53gitNote Added: 0064421
2017-03-17 19:54mkvAssigned Tobugmaster => mkv
2017-03-20 09:47emvRelationship addedrelated to 0028567
2017-03-20 14:50emvRelationship deletedrelated to 0028567
2017-03-20 14:51emvRelationship addedrelated to 0028575
2017-03-20 20:45mkvNote Added: 0064555
2017-03-20 20:45mkvNote Added: 0064556
2017-03-20 20:46mkvNote Added: 0064557
2017-03-20 20:46mkvAssigned Tomkv => emv
2017-03-20 20:46mkvStatusreviewed => feedback
2017-03-20 20:46mkvTest case number => Not needed
2017-03-21 16:53emvNote Added: 0064582
2017-03-21 16:53emvAssigned Toemv => apv
2017-03-21 16:54emvAssigned Toapv => mkv
2017-03-21 17:02mkvNote Added: 0064584
2017-03-21 17:02mkvAssigned Tomkv => bugmaster
2017-03-21 17:02mkvStatusfeedback => tested
2017-03-24 15:53bugmasterChangeset attached => occt master 8b956afe
2017-03-24 15:53bugmasterStatustested => verified
2017-03-24 15:53bugmasterResolutionopen => fixed
2017-05-12 11:35gitNote Added: 0065925
2017-09-29 16:20aivFixed in Version => 7.2.0
2017-09-29 16:25aivStatusverified => closed

Notes
(0064394)
git   
2017-03-17 13:57   
Branch CR28562 has been created by emv.

SHA-1: 98b85d2a42b2e5f4de0c5ce55b6be8fa8ba5cff9


Detailed log of new commits:

Author: emv
Date: Fri Mar 17 11:34:21 2017 +0300

    0028562: Replacement of old Boolean operations (BRepAlgo) with new ones (BRepAlgoAPI) in BRepAlgo_NormalProjection
    
    The usage of the old Boolean operations (implemented in the class BRepAlgo_BooleanOperations) in the
    BRepAlgo_NormalProjection algorithm has been replaced with the usage of new Boolean operations
    (implemented in the class BRepAlgoAPI_BooleanOperations).
(0064395)
emv   
2017-03-17 13:58   
Dear Mikhail, could you please review the git branch CR28562?
(0064417)
msv   
2017-03-17 19:22   
Reviewed.
(0064421)
git   
2017-03-17 19:53   
Branch CR28562 has been updated forcibly by mkv.

SHA-1: d1951a04a1361dfed13423f16f5f621065ad96f3
(0064555)
mkv   
2017-03-20 20:45   
Dear BugMaster,
Branch CR28562 was rebased on current master of occt git-repository.
SHA-1: d1951a04a1361dfed13423f16f5f621065ad96f3
(0064556)
mkv   
2017-03-20 20:45   
Dear BugMaster,
Branch CR28562 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: d1951a04a1361dfed13423f16f5f621065ad96f3

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1185

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 92893745 / 92537449 [+0.39%]
Total CPU difference: 20192.190000000155 / 20187.16000000011 [+0.02%]
products component :
Total MEMORY difference: 31034777 / 31146794 [-0.36%]
Total CPU difference: 5434.769999999982 / 5412.149999999975 [+0.42%]

Testing on Windows:
occt component :
http://occt-tests/CR28562-master-OCCT/Windows-64-VC10-cpu/diff-Windows-64-VC10-cpu.html [^]
CPU bugs moddata_3 bug24886: 4.6644299 / 0.2964019 [+1473.68%]

Total MEMORY difference: 57784525 / 57782265 [+0.00%]
Total CPU difference: 18813.783000398467 / 18782.551600198512 [+0.17%]
products component :
Total MEMORY difference: 22292934 / 22254740 [+0.17%]
Total CPU difference: 5452.687352899982 / 5421.409152399973 [+0.58%]

There are following differences in images found by testdiff.
http://occt-tests/CR28562-master-OCCT/Debian70-64/diff-Debian70-64.html [^]
http://occt-tests/CR28562-master-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html [^]
IMAGE bugs modalg_2 bug474: bug474.png differs
IMAGE bugs modalg_5 bug24012: bug24012.png differs
(0064557)
mkv   
2017-03-20 20:46   
Dear emv,
Branch CR28562 has been rejected due to:
- CPU problems
- differences in images
(0064582)
emv   
2017-03-21 16:53   
1. I do not see any real difference in images for the test case bugs modalg_2 bug474;
2. bugs modalg_5 bug24012 - improvement;
3. The case bugs moddata_3 bug24886 produces absolutely incorrect result in master. Due to performing correct Boolean operation the result produced on the fix is much better. Thus, it should not be considered as CPU regression.

Basing on above, please consider the branch TESTED.
(0064584)
mkv   
2017-03-21 17:02   
Dear BugMaster,
Branch CR28562 is TESTED.
(0065925)
git   
2017-05-12 11:35   
Branch CR28562 has been deleted by kgv.

SHA-1: d1951a04a1361dfed13423f16f5f621065ad96f3