MantisBT - Open CASCADE
View Issue Details
0028556Open CASCADE[OCCT] OCCT:Modeling Algorithmspublic2017-03-15 09:092017-09-29 16:25
emv 
bugmaster 
normalminor 
closedfixed 
[OCCT] 7.1.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
bugs moddata_2 bug469
0028556: Invalid result of Fuse operation in the test case bugs moddata_2 bug469
The result of Fuse operation performed in the test case bugs moddata_2 bug469 is invalid. The test case is marked as BAD (known problem).
test bugs moddata_2 bug469
checkshape result
checknbshapes result -solid 1
No tags attached.
Issue History
2017-03-15 09:09emvNew Issue
2017-03-15 09:09emvAssigned To => msv
2017-03-15 09:09emvRelationship addedrelated to 0028501
2017-03-16 08:07gitNote Added: 0064356
2017-03-16 08:12emvNote Added: 0064357
2017-03-16 08:12emvStatusnew => resolved
2017-03-16 11:01msvNote Added: 0064361
2017-03-16 11:01msvAssigned Tomsv => emv
2017-03-16 11:01msvStatusresolved => assigned
2017-03-16 14:46gitNote Added: 0064381
2017-03-16 14:47emvNote Added: 0064382
2017-03-16 14:47emvAssigned Toemv => msv
2017-03-16 14:47emvStatusassigned => resolved
2017-03-17 19:56gitNote Added: 0064422
2017-03-17 19:59gitNote Added: 0064423
2017-03-17 20:00msvNote Added: 0064424
2017-03-17 20:00msvAssigned Tomsv => bugmaster
2017-03-17 20:00msvStatusresolved => reviewed
2017-03-17 20:12mkvAssigned Tobugmaster => mkv
2017-03-20 20:01mkvNote Added: 0064551
2017-03-20 20:01mkvNote Added: 0064552
2017-03-20 20:01mkvAssigned Tomkv => bugmaster
2017-03-20 20:01mkvStatusreviewed => tested
2017-03-20 20:02mkvTest case number => bugs moddata_2 bug469
2017-03-24 15:53bugmasterChangeset attached => occt master f80842e3
2017-03-24 15:53bugmasterStatustested => verified
2017-03-24 15:53bugmasterResolutionopen => fixed
2017-05-12 11:35gitNote Added: 0065923
2017-05-12 11:35gitNote Added: 0065924
2017-09-29 16:20aivFixed in Version => 7.2.0
2017-09-29 16:25aivStatusverified => closed

Notes
(0064356)
git   
2017-03-16 08:07   
Branch CR28556 has been created by emv.

SHA-1: d6db30e1b4c88398d8c1734a01b9148464a5cdaf


Detailed log of new commits:

Author: emv
Date: Wed Mar 15 09:15:46 2017 +0300

    0028556: Invalid result of Fuse operation in the test case bugs moddata_2 bug469
    
    1. Using appropriate intersection tolerance for splitting the degenerated edges in Boolean operations (void BOPAlgo_PaveFiller::FillPaves()).
    
    2. Avoid creation of the wires consisting of degenerated edges only (BOPAlgo_WireSplitter).
    
    3. Test case bugs/moddata_2/bug469 has been corrected to obtain valid result of operation. TODO statements have been removed from the case.
(0064357)
emv   
2017-03-16 08:12   
The shapes in the test case are slightly misaligned, and this misalignment leads to creation of invalid faces. To resolve that, additionally to the fixes in BOP algorithm, the use of fuzzy value has been added into the test case.

Dear Mikhail, could you please review the git branch CR28556?
(0064361)
msv   
2017-03-16 11:01   
src\BOPAlgo\BOPAlgo_PaveFiller_8.cxx
- 234: paves => pave blocks
- 259: double ;;
- aTolCmp should be computed with resolution of only direction of the degenerated edge.
(0064381)
git   
2017-03-16 14:46   
Branch CR28556 has been updated by emv.

SHA-1: ea7f309d65b8ac6c992122324cfa67bd0c52d07a


Detailed log of new commits:

Author: emv
Date: Thu Mar 16 14:40:24 2017 +0300

    Small corrections considering remarks.

(0064382)
emv   
2017-03-16 14:47   
Corrected. Please review again.
(0064422)
git   
2017-03-17 19:56   
Branch CR28556 has been updated by msv.

SHA-1: 4cc23a3501fedb645f14854731cfe71f414c59fe


Detailed log of new commits:

Author: msv
Date: Fri Mar 17 19:55:58 2017 +0300

    // small correction

(0064423)
git   
2017-03-17 19:59   
Branch CR28556_1 has been created by msv.

SHA-1: 67af679208369e8d7d1f0aa164dad7b6199afea9


Detailed log of new commits:

Author: emv
Date: Wed Mar 15 09:15:46 2017 +0300

    0028556: Invalid result of Fuse operation in the test case bugs moddata_2 bug469
    
    1. Using appropriate intersection tolerance for splitting the degenerated edges in Boolean operations (void BOPAlgo_PaveFiller::FillPaves()).
    
    2. Avoid creation of the wires consisting of degenerated edges only (BOPAlgo_WireSplitter).
    
    3. Test case bugs/moddata_2/bug469 has been corrected to obtain valid result of operation. TODO statements have been removed from the case.
(0064424)
msv   
2017-03-17 20:00   
I have made small correction and put the new branch rebased on current master.
Please test.
(0064551)
mkv   
2017-03-20 20:01   
Dear BugMaster,
Branch CR28556_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 67af679208369e8d7d1f0aa164dad7b6199afea9

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1198

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
http://occt-tests/CR28556_1-master-OCCT/Debian70-64/bugs/moddata_2/bug469.html [^]
http://occt-tests/CR28556_1-master-OCCT/Windows-64-VC10/bugs/moddata_2/bug469.html [^]
bugs moddata_2 bug469: OK

Testing on Linux:
occt component :
Total MEMORY difference: 92897520 / 92532835 [+0.39%]
Total CPU difference: 20102.790000000245 / 20174.39000000011 [-0.35%]
products component :
Total MEMORY difference: 31026661 / 31146794 [-0.39%]
Total CPU difference: 5444.639999999978 / 5412.149999999975 [+0.60%]

Testing on Windows:
occt component :
Total MEMORY difference: 57783680 / 57782265 [+0.00%]
Total CPU difference: 18857.182478598552 / 18782.551600198512 [+0.40%]
products component :
Total MEMORY difference: 22292931 / 22254740 [+0.17%]
Total CPU difference: 5453.701359399969 / 5421.409152399973 [+0.60%]

There are following differences in images found by testdiff.
http://occt-tests/CR28556_1-master-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html [^]
IMAGE bugs moddata_2 bug469: bug469.png differs
(0064552)
mkv   
2017-03-20 20:01   
Dear BugMaster,
Branch CR28556_1 is TESTED.
(0065923)
git   
2017-05-12 11:35   
Branch CR28556 has been deleted by kgv.

SHA-1: 4cc23a3501fedb645f14854731cfe71f414c59fe
(0065924)
git   
2017-05-12 11:35   
Branch CR28556_1 has been deleted by kgv.

SHA-1: 67af679208369e8d7d1f0aa164dad7b6199afea9