MantisBT - Open CASCADE
View Issue Details
0028499Open CASCADE[OCCT] OCCT:Modeling Algorithmspublic2017-03-01 18:232018-06-29 21:19
msv 
apn 
normalminor 
closedfixed 
[OCCT] 7.1.0 
[OCCT] 7.3.0[OCCT] 7.3.0 
bugs modalg_7 bug28499
0028499: Checkshape incorrectly reports BRepCheck_NotClosed when gap is covered by vertex tolerance
For the attached face, checkshape reports BRepCheck_NotClosed for the wire of the face.
Really the gap between edges is covered by their common vertex tolerance (0.000394386026756954).
The checking algorithm checks the distance in 2D space that can be significantly distorted. It is needed to check distance only in 3D space.
Test case

bugs modalg_7 bug28499
No tags attached.
png gap_3d.PNG (6,897) 2017-03-01 18:23
https://tracker.dev.opencascade.org/
? bug28499.brep (31,020) 2017-12-26 11:32
https://tracker.dev.opencascade.org/
Issue History
2017-03-01 18:23msvNew Issue
2017-03-01 18:23msvAssigned To => msv
2017-03-01 18:23msvFile Added: gap_3d.PNG
2017-03-01 18:23msvFile Added: face_with_gap.brep
2017-04-05 12:54msvAssigned Tomsv => mpa
2017-04-05 12:54msvStatusnew => assigned
2017-05-17 14:57gitNote Added: 0066201
2017-05-17 15:14mpaNote Added: 0066206
2017-05-17 15:14mpaAssigned Tompa => msv
2017-05-17 15:14mpaStatusassigned => resolved
2017-05-17 15:14mpaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16645#r16645
2017-05-18 18:05msvNote Added: 0066292
2017-05-18 18:05msvAssigned Tomsv => mpa
2017-05-18 18:05msvStatusresolved => assigned
2017-07-24 09:22msvTarget Version7.2.0 => 7.3.0
2017-11-24 11:16msvRelationship addedrelated to 0028722
2017-11-24 11:17msvNote Added: 0072458
2017-11-24 11:17msvAssigned Tompa => ifv
2017-12-05 17:08msvTarget Version7.3.0 => 7.4.0
2017-12-15 10:25gitNote Added: 0072996
2017-12-15 13:33gitNote Added: 0073000
2017-12-18 11:47gitNote Added: 0073013
2017-12-21 12:06gitNote Added: 0073062
2017-12-22 17:04gitNote Added: 0073092
2017-12-25 14:56gitNote Added: 0073110
2017-12-26 11:32ifvFile Added: bug28499.brep
2017-12-26 11:32ifvFile Deleted: face_with_gap.brep
2017-12-26 11:33ifvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18397#r18397
2017-12-26 11:34gitNote Added: 0073136
2017-12-26 11:53ifvNote Added: 0073140
2017-12-26 11:53ifvAssigned Toifv => msv
2017-12-26 11:53ifvStatusassigned => resolved
2017-12-26 17:02msvNote Added: 0073154
2017-12-26 17:02msvAssigned Tomsv => ifv
2017-12-26 17:02msvStatusresolved => assigned
2017-12-26 17:03msvNote Added: 0073156
2017-12-26 17:14gitNote Added: 0073157
2017-12-28 10:39gitNote Added: 0073177
2017-12-28 16:21gitNote Added: 0073183
2017-12-29 10:24ifvNote Added: 0073185
2017-12-29 10:24ifvAssigned Toifv => msv
2017-12-29 10:24ifvStatusassigned => resolved
2017-12-29 14:59gitNote Added: 0073196
2017-12-29 15:00ifvAssigned Tomsv => ifv
2017-12-29 15:00ifvStatusresolved => assigned
2017-12-29 15:02ifvNote Added: 0073198
2017-12-29 15:02ifvAssigned Toifv => msv
2017-12-29 15:02ifvStatusassigned => resolved
2017-12-29 15:04msvNote Added: 0073199
2017-12-29 15:04msvAssigned Tomsv => bugmaster
2017-12-29 15:04msvStatusresolved => reviewed
2017-12-29 15:18apnTest case number => bugs modalg_7 bug28499
2017-12-29 15:18apnNote Added: 0073201
2017-12-29 15:18apnStatusreviewed => tested
2017-12-30 18:43apnChangeset attached => occt master 5d010b1d
2017-12-30 18:43apnAssigned Tobugmaster => apn
2017-12-30 18:43apnStatustested => verified
2017-12-30 18:43apnResolutionopen => fixed
2018-01-11 11:10gitNote Added: 0073306
2018-02-20 12:58aivTarget Version7.4.0 => 7.3.0
2018-06-29 21:15aivFixed in Version => 7.3.0
2018-06-29 21:19aivStatusverified => closed

Notes
(0066201)
git   
2017-05-17 14:57   
Branch CR28499 has been created by mpa.

SHA-1: cde3f22d3673962c47cbfdb7e1957cd2a69f5606


Detailed log of new commits:

Author: mpa
Date: Wed May 17 14:56:02 2017 +0300

    0028499: Checkshape incorrectly reports BRepCheck_NotClosed when gap is covered by vertex tolerance
    
(0066206)
mpa   
2017-05-17 15:14   
In the attached script the distance between two vertices(0.0003944) is more that 3D tolerance(0.0003943). Thus, current example don't show the problem.
But theoretically this bug can be reproduced for the other case.
(0066292)
msv   
2017-05-18 18:05   
Please consider verbal remarks.
(0072458)
msv   
2017-11-24 11:17   
Dear Igor, please consider this bug along with related #28722.
(0072996)
git   
2017-12-15 10:25   
Branch CR28499 has been updated forcibly by ifv.

SHA-1: 93dd583f1b465e401928e6f111b0522c8ac283ac
(0073000)
git   
2017-12-15 13:33   
Branch CR28499 has been updated forcibly by ifv.

SHA-1: 10366c066faacd13aa43924531f48da085c9ecbf
(0073013)
git   
2017-12-18 11:47   
Branch CR28499 has been updated forcibly by ifv.

SHA-1: dead30aba4f036af2d484c01603df1c5254e2cc9
(0073062)
git   
2017-12-21 12:06   
Branch CR28499 has been updated forcibly by ifv.

SHA-1: 8f46835d04816ecd5e81b29e8ca5cf2da997a2d2
(0073092)
git   
2017-12-22 17:04   
Branch CR28499 has been updated forcibly by ifv.

SHA-1: 10e91673fcdb2f1520150153f048ab4f4a632362
(0073110)
git   
2017-12-25 14:56   
Branch CR28499 has been updated forcibly by ifv.

SHA-1: 29997f1a5d861144e236b482493c23224a30cd6b
(0073136)
git   
2017-12-26 11:34   
Branch CR28499 has been updated forcibly by ifv.

SHA-1: 554de85da760f0387b430280659078ed993e0529
(0073140)
ifv   
2017-12-26 11:53   
Bramches CR28499 and CR28499-p (product git) are ready for review.
Test results are CR28499-master-IFV (CR28499-p contains only test modification)
(0073154)
msv   
2017-12-26 17:02   
Remarks:

src/BRepCheck/BRepCheck_Wire.cxx
- 490,495: use aMDU,aMDV instead of sqrt.
- make a new static function to avoid code duplication in 482-496 and 508-522.

tests/bugs/modalg_7/bug27711
- 1: too wide to do pattern.
- 45: why checkshape has been removed?

tests/bugs/modalg_7/bug28200
- remove the last two lines with showing faulty shapes.
(0073156)
msv   
2017-12-26 17:03   
src/BRepCheck/BRepCheck_Wire.cxx
- remove treatment below the line 362.
(0073157)
git   
2017-12-26 17:14   
Branch CR28499 has been updated by ifv.

SHA-1: aa9ccc17ec165e5da3001d488cfc42bb4fafbc56


Detailed log of new commits:

Author: ifv
Date: Tue Dec 26 17:14:18 2017 +0300

    Test Commit

(0073177)
git   
2017-12-28 10:39   
Branch CR28499 has been deleted by ifv.

SHA-1: aa9ccc17ec165e5da3001d488cfc42bb4fafbc56
(0073183)
git   
2017-12-28 16:21   
Branch CR28499 has been created by ifv.

SHA-1: aef8284d6113bf3d3769cee4b38b4177e0b13dd9


Detailed log of new commits:

Author: ifv
Date: Fri Dec 15 10:23:29 2017 +0300

    0028499: Checkshape incorrectly reports BRepCheck_NotClosed when gap is covered by vertex tolerance
    
    Calculation of 2d tolerance is improved
(0073185)
ifv   
2017-12-29 10:24   
Branch CR28499 is updated according to remarks.
Test results are on CR28499-master-IFV
(0073196)
git   
2017-12-29 14:59   
Branch CR28499 has been updated forcibly by ifv.

SHA-1: 0b2131b85fc8cffffc520af376b0e5b82fa2628f
(0073198)
ifv   
2017-12-29 15:02   
CR28499 is updated
(0073199)
msv   
2017-12-29 15:04   
Reviewed.
(0073201)
apn   
2017-12-29 15:18   
Combination -
OCCT branch : CR28499 SHA - aef8284d6113bf3d3769cee4b38b4177e0b13dd9
Products branch : CR28499-p SHA - 925de254fbff0d26b8cd6186c4471f1d2b35d25e
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

Test case:
bugs modalg_7 bug28499 - OK

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18376.299999999635 / 18513.219999999714 [-0.74%]
Products
Total CPU difference: 7466.750000000016 / 7509.540000000005 [-0.57%]
Windows-64-VC10:
OCCT
Total CPU difference: 17989.879318998544 / 17919.33566679854 [+0.39%]
Products
Total CPU difference: 8047.077583499998 / 8016.251785899991 [+0.38%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0073306)
git   
2018-01-11 11:10   
Branch CR28499 has been deleted by kgv.

SHA-1: 0b2131b85fc8cffffc520af376b0e5b82fa2628f