MantisBT - Community
View Issue Details
0028488Community[OCCT] OCCT:VISpublic2017-02-23 21:492019-03-05 13:46
jensgw 
apn 
normalfeature 
closedfixed 
[OCCT] 7.1.0 
[OCCT] 7.4.0[OCCT] 7.4.0 
Not needed
0028488: VIS - fix compilation with VTK 8.2
The VIS is a nice feature briding two awesome libraries. However, in the current OCCT release VIS depends on VTK 6.1 which is rather old by now. Especially rendering and performance has improved with ongoing VTK releases. So, an update to a recent VTK Version (at least 7.1 - 7.0 has some bugs...) would be awesome.


As a sidenote, IVtkTools_ShapeObject inherits from vtkDataObject but uses the vtkTypeMacro with vtkObject, this is incorrect.
Either use:
class IVtkTools_EXPORT IVtkTools_ShapeObject : public vtkDataObject
vtkTypeMacro (IVtkTools_ShapeObject, vtkDataObject)
or:
class IVtkTools_EXPORT IVtkTools_ShapeObject : public vtkObject
vtkBaseTypeMacro (IVtkTools_ShapeObject, vtkObject)
When updating to VTK 7.1 keep in mind that the method "InsertNextTupleValue" will be deprectated. Use "InsertNextTypedTuple" instead. (IVtkVTK_ShapeData).
No tags attached.
duplicate of 0028208closed bugmaster Open CASCADE Compile with VTK 7.1.0 
txt patchToOCCT.txt (4,023) 2017-02-27 19:39
https://tracker.dev.opencascade.org/
txt patchToOCCT_WithoutTypo.txt (4,019) 2017-02-27 19:44
https://tracker.dev.opencascade.org/
Issue History
2017-02-23 21:49jensgwNew Issue
2017-02-23 21:49jensgwAssigned To => san
2017-02-25 21:06sanRelationship addedduplicate of 0028208
2017-02-25 21:29sanNote Added: 0063994
2017-02-27 19:39jensgwFile Added: patchToOCCT.txt
2017-02-27 19:41jensgwNote Added: 0064016
2017-02-27 19:44jensgwFile Added: patchToOCCT_WithoutTypo.txt
2019-02-15 11:26kgvTarget Version => 7.4.0
2019-02-15 11:26kgvSummaryUpdate VTK Integration to latest VTK version (7.1) => VIS - fix compilation on VTK 8.2
2019-02-15 11:31kgvSummaryVIS - fix compilation on VTK 8.2 => VIS - fix compilation with VTK 8.2
2019-02-15 11:31gitNote Added: 0082191
2019-02-15 11:50gitNote Added: 0082192
2019-02-15 12:35kgvNote Added: 0082194
2019-02-15 12:35kgvAssigned Tosan => bugmaster
2019-02-15 12:35kgvStatusnew => resolved
2019-02-15 12:35kgvStatusresolved => reviewed
2019-02-15 13:30kgvNote Edited: 0082194bug_revision_view_page.php?bugnote_id=82194#r20677
2019-02-15 14:49apnTest case number => Not needed
2019-02-15 14:49apnNote Added: 0082196
2019-02-15 14:49apnStatusreviewed => tested
2019-02-16 11:48apnChangeset attached => occt master e607bd3e
2019-02-16 11:48apnAssigned Tobugmaster => apn
2019-02-16 11:48apnStatustested => verified
2019-02-16 11:48apnResolutionopen => fixed
2019-03-05 13:46gitNote Added: 0082608

Notes
(0063994)
san   
2017-02-25 21:29   
Hello jengsw,

Once you are interested in VTK 7.1 compatibility, can you prepare the OCCT patch?
Contributing to an open-source product is always appreciated.
(0064016)
jensgw   
2017-02-27 19:41   
Please find attached the patch with my modifcations to use VTK-7.1 with OCCT-7.1.

This works only for the VTK OpenGL1 Rendering Backend - see 0028208 for the issue with the OpenGL2 Redering backend.
(0082191)
git   
2019-02-15 11:31   
Branch CR28488 has been created by kgv.

SHA-1: f3d9fe536c0f820dbac9e5f3d80c2790858ae2dd


Detailed log of new commits:

Author: kgv
Date: Fri Feb 15 11:27:15 2019 +0300

    0028488: VIS - fix compilation with VTK 8.2
    
    Occurrences of removed method vtkDataArray::InsertNextTupleValue() have been replaced by InsertNextTypedTuple().
    Fixed misprint in vtkTypeMacro usage for class IVtkTools_ShapeObject.
    Patch 0030452 (SelectMgr_ViewerSelector::Deactivate() raises exception when called twice) has been propagated to IVtkOCC_ViewerSelector.
(0082192)
git   
2019-02-15 11:50   
Branch CR28488 has been updated forcibly by kgv.

SHA-1: 866557227e0f2c993d2c65b70dad136d246d1b37
(0082194)
kgv   
2019-02-15 12:35   
(edited on: 2019-02-15 13:30)
Please raise the patch.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR28488-master-KGV/ [^]

(0082196)
apn   
2019-02-15 14:49   
Combination -
OCCT branch : CR28488
master SHA - 866557227e0f2c993d2c65b70dad136d246d1b37
d67d4b811012eef8913d3c535c29654d0acf3c4c
Products branch : master SHA - 958a4e5e4b816adb6dba1a223ae557d1649e52b6
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16503.939999999908 / 16545.53999999999 [-0.25%]
Products
Total CPU difference: 9076.380000000025 / 9061.810000000012 [+0.16%]
Windows-64-VC14:
OCCT
Total CPU difference: 17918.59375 / 17918.46875 [+0.00%]
Products
Total CPU difference: 10451.5 / 10465.109375 [-0.13%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0082608)
git   
2019-03-05 13:46   
Branch CR28488 has been deleted by kgv.

SHA-1: 866557227e0f2c993d2c65b70dad136d246d1b37