MantisBT - Open CASCADE
View Issue Details
0028469Open CASCADE[OCCT] OCCT:Visualizationpublic2017-02-17 11:262017-09-29 16:24
kgv 
bugmaster 
normalintegration request 
closedfixed 
 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028469: Visualization, StdPrs_ShadedShape - do not create redundant copy of normal array
Current implementation of StdPrs_ShadedShape pre-allocates array of normals within processed Face as TColgp_Array1OfDir (e.g. with double precision) just to store them into Graphic3d_ArrayOfTriangles at the next step. This allocation does not sound reasonable.
N/A
No tags attached.
related to 0028630closed bugmaster Visualization, StdPrs_ShadedShape - do not create Poly_Connect without need 
Issue History
2017-02-17 11:26kgvNew Issue
2017-02-17 11:26kgvAssigned To => kgv
2017-02-17 11:31gitNote Added: 0063871
2017-02-17 11:32kgvNote Added: 0063872
2017-02-17 11:32kgvAssigned Tokgv => san
2017-02-17 11:32kgvStatusnew => resolved
2017-02-23 15:00sanNote Added: 0063979
2017-02-23 15:00sanAssigned Tosan => bugmaster
2017-02-23 15:00sanStatusresolved => reviewed
2017-02-27 15:14apvAssigned Tobugmaster => apv
2017-02-28 11:46apvTest case number => Not needed
2017-02-28 13:59apvNote Added: 0064024
2017-02-28 13:59apvAssigned Toapv => bugmaster
2017-02-28 13:59apvStatusreviewed => tested
2017-03-03 16:25bugmasterChangeset attached => occt master f4064435
2017-03-03 16:25bugmasterStatustested => verified
2017-03-03 16:25bugmasterResolutionopen => fixed
2017-03-20 14:34gitNote Added: 0064479
2017-04-05 14:26kgvRelationship addedrelated to 0028630
2017-09-29 16:20aivFixed in Version => 7.2.0
2017-09-29 16:24aivStatusverified => closed

Notes
(0063871)
git   
2017-02-17 11:31   
Branch CR28469 has been created by kgv.

SHA-1: d6de0ea11a52cd98d3145c9acfeca8a7e2d7d0a3


Detailed log of new commits:

Author: kgv
Date: Fri Feb 17 11:30:42 2017 +0300

    0028469: Visualization, StdPrs_ShadedShape - do not create redundant copy of normal array
(0063872)
kgv   
2017-02-17 11:32   
Patch is ready for review.
(0063979)
san   
2017-02-23 15:00   
Branch CR28469 reviewed without remarks, ready for testing.
(0064024)
apv   
2017-02-28 13:59   
Dear BugMaster,

Branch CR28469 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: d6de0ea11a52cd98d3145c9acfeca8a7e2d7d0a3

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1191

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 92663862 / 93208398 [-0.58%]
Total CPU difference: 19864.480000000225 / 19801.800000000218 [+0.32%]

Testing on Windows:
Total MEMORY difference: 57832466 / 57829936 [+0.00%]
Total CPU difference: 18626.176197798508 / 18793.846072598604 [-0.89%]
(0064479)
git   
2017-03-20 14:34   
Branch CR28469 has been deleted by inv.

SHA-1: d6de0ea11a52cd98d3145c9acfeca8a7e2d7d0a3