MantisBT - Open CASCADE
View Issue Details
0028400Open CASCADE[OCCT] OCCT:Visualizationpublic2017-01-27 18:032017-09-29 16:24
kgv 
apn 
normalintegration request 
closedfixed 
 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028400: Visualization, Graphic3d_MaterialAspect - remove undocumented and unsupported flag EnvReflexion()
Graphic3d_MaterialAspect::EnvReflexion() is undocumented and implies weird rendering pipeline within TKOpenGl. It is suggested removing this flag.
N/A
No tags attached.
related to 0027925closed bugmaster Visualization - implement order-independent transparency algorithm within rasterization rendering 
Issue History
2017-01-27 18:03kgvNew Issue
2017-01-27 18:03kgvAssigned To => kgv
2017-01-27 18:16gitNote Added: 0063148
2017-01-27 18:17kgvRelationship addedrelated to 0027925
2017-01-27 18:48kgvNote Added: 0063154
2017-01-27 18:48kgvAssigned Tokgv => san
2017-01-27 18:48kgvStatusnew => resolved
2017-01-27 20:09sanNote Added: 0063159
2017-01-27 20:09sanAssigned Tosan => bugmaster
2017-01-27 20:09sanStatusresolved => reviewed
2017-01-30 12:20apvAssigned Tobugmaster => apv
2017-01-30 19:00apvAssigned Toapv => mkv
2017-02-01 18:32mkvNote Added: 0063319
2017-02-01 18:32mkvNote Added: 0063320
2017-02-01 18:33mkvNote Added: 0063321
2017-02-01 18:33mkvAssigned Tomkv => bugmaster
2017-02-01 18:33mkvStatusreviewed => tested
2017-02-01 18:33mkvTest case number => Not needed
2017-02-03 16:52apnChangeset attached => occt master 1a0dfc1b
2017-02-03 16:52apnAssigned Tobugmaster => apn
2017-02-03 16:52apnStatustested => verified
2017-02-03 16:52apnResolutionopen => fixed
2017-02-08 11:36gitNote Added: 0063630
2017-09-29 16:21aivFixed in Version => 7.2.0
2017-09-29 16:24aivStatusverified => closed

Notes
(0063148)
git   
2017-01-27 18:16   
Branch CR28400 has been created by kgv.

SHA-1: 3616ca4476abd0df084d7e38b4aaeb3c4fb84be6


Detailed log of new commits:

Author: kgv
Date: Fri Jan 27 18:16:50 2017 +0300

    0028400: Visualization, Graphic3d_MaterialAspect - remove undocumented and unsupported flag EnvReflexion()
(0063154)
kgv   
2017-01-27 18:48   
Patch is ready for review.
(0063159)
san   
2017-01-27 20:09   
Branch CR28400 reviewed in occt and occt-products without remarks, ready for testing.

NOTE: It is mandatory to test the SSP sample operation with this patch!
(0063319)
mkv   
2017-02-01 18:32   
Dear BugMaster,
Branch CR28400 from occt git-repository (and CR28400 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 3616ca4476abd0df084d7e38b4aaeb3c4fb84be6
SHA-1: d1fa65feba39bac23e1158ce2b176d2422e43515

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1144

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 92321534 / 92295997 [+0.03%]
Total CPU difference: 19968.24000000023 / 19914.170000000217 [+0.27%]
products component :
Total MEMORY difference: 31457210 / 31477908 [-0.07%]
Total CPU difference: 5606.739999999979 / 5544.959999999981 [+1.11%]

Testing on Windows:
occt component :
Total MEMORY difference: 57621227 / 57618048 [+0.01%]
Total CPU difference: 18775.890357498454 / 18683.178963198647 [+0.50%]
products component :
Total MEMORY difference: 22659012 / 22621210 [+0.17%]
Total CPU difference: 5599.687095199988 / 5570.546108399986 [+0.52%]

There are no differences in images found by testdiff.
(0063320)
mkv   
2017-02-01 18:32   
Dear BugMaster,
SSP sample is TESTED.
(0063321)
mkv   
2017-02-01 18:33   
Dear BugMaster,
Branch CR28400 from occt git-repository and CR28400 from products git-repository are TESTED.
(0063630)
git   
2017-02-08 11:36   
Branch CR28400 has been deleted by kgv.

SHA-1: 3616ca4476abd0df084d7e38b4aaeb3c4fb84be6