MantisBT - Open CASCADE
View Issue Details
0028389Open CASCADE[OCCT] OCCT:Data Exchangepublic2017-01-25 14:042017-09-29 16:24
ika 
apn 
normalfeature 
closedfixed 
 
[OCCT] 7.2.0[OCCT] 7.2.0 
gdt export B9; gdt presentation B8; gdt view A1 - B5
0028389: Data Exchange - Import of STEP Saved Views and Clipping Planes
Implement Import of STEP Saved Views
Add tool to store and process Clipping Planes.
gdt view A1-B5
No tags attached.
child of 0028044closed apn Data Exchange - implement data structures for Saved Views 
? bug28389_CONFIDENTIAL_SHEET_METAL_F3D.stp (802,114) 2017-01-27 11:06
https://tracker.dev.opencascade.org/
Issue History
2017-01-25 14:04ikaNew Issue
2017-01-25 14:04ikaAssigned To => ika
2017-01-25 14:19gitNote Added: 0063006
2017-01-27 11:06gitNote Added: 0063110
2017-01-27 11:06ikaFile Added: bug28389_CONFIDENTIAL_SHEET_METAL_F3D.stp
2017-01-27 11:16ikaNote Added: 0063111
2017-01-27 11:16ikaAssigned Toika => gka
2017-01-27 11:16ikaStatusnew => resolved
2017-01-27 11:16ikaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15938#r15938
2017-01-27 11:16ikaRelationship addedchild of 0028044
2017-01-27 12:17gkaNote Added: 0063112
2017-01-27 12:17gkaAssigned Togka => bugmaster
2017-01-27 12:17gkaStatusresolved => reviewed
2017-01-27 13:20mkvAssigned Tobugmaster => mkv
2017-01-27 17:02mkvNote Added: 0063136
2017-01-27 17:02mkvAssigned Tomkv => ika
2017-01-27 17:02mkvStatusreviewed => feedback
2017-01-27 17:07gitNote Added: 0063137
2017-01-27 17:08ikaNote Added: 0063138
2017-01-27 17:08ikaAssigned Toika => mkv
2017-01-27 17:08ikaStatusfeedback => assigned
2017-01-27 18:39mkvStatusassigned => feedback
2017-01-27 18:39mkvStatusfeedback => reviewed
2017-01-30 15:59mkvNote Added: 0063198
2017-01-30 15:59mkvNote Added: 0063199
2017-01-30 15:59mkvAssigned Tomkv => ika
2017-01-30 15:59mkvStatusreviewed => assigned
2017-01-30 16:00mkvTest case number => gdt export B9; gdt presentation B8; gdt view A1 - B5
2017-01-31 15:29gitNote Added: 0063265
2017-01-31 15:30ikaNote Added: 0063266
2017-01-31 15:30ikaAssigned Toika => mkv
2017-01-31 15:30ikaStatusassigned => resolved
2017-01-31 15:48mkvStatusresolved => reviewed
2017-02-02 12:26mkvNote Added: 0063345
2017-02-02 12:26mkvNote Added: 0063346
2017-02-02 12:26mkvAssigned Tomkv => bugmaster
2017-02-02 12:26mkvStatusreviewed => tested
2017-02-03 16:52apnChangeset attached => occt master 0c63f2f8
2017-02-03 16:52apnAssigned Tobugmaster => apn
2017-02-03 16:52apnStatustested => verified
2017-02-03 16:52apnResolutionopen => fixed
2017-02-08 11:36gitNote Added: 0063626
2017-09-29 16:21aivFixed in Version => 7.2.0
2017-09-29 16:24aivStatusverified => closed

Notes
(0063006)
git   
2017-01-25 14:19   
Branch CR28389 has been created by ika.

SHA-1: eeae9acf1f9d55aaaea8e8b378cb3ac1c81b75d0


Detailed log of new commits:

Author: ika
Date: Wed Jan 25 14:13:45 2017 +0300

    0028389: Data Exchange - Import of STEP Saved Views and Clipping Planes
    
    - new STEP entities for Saved Views
    - import of STEP Saved Views
    - new XCAF tool for clipping planes
    - new draw commands
    - update test
(0063110)
git   
2017-01-27 11:06   
Branch CR28389 has been updated forcibly by ika.

SHA-1: d0de9d557c900337e681322b895712acf85584a5
(0063111)
ika   
2017-01-27 11:16   
- new STEP entities for Saved Views
- import of STEP Saved Views with/without clipping planes
- upgrade View object
- new XCAF tool for clipping planes
- new draw commands for clipping planes
- test cases

Note: this issue should be tested with changes of 28044.

Dear GKA,
could you please review branch CR28389?
(0063112)
gka   
2017-01-27 12:17   
Branch CR28389 is ready to be tested.
(0063136)
mkv   
2017-01-27 17:02   
Dear ika,
could you please rebase branch CR28389 on current master, there are conflict files.
(0063137)
git   
2017-01-27 17:07   
Branch CR28389 has been updated forcibly by ika.

SHA-1: 65b4ec4fd13e613314c42ef0cddffe4f61d39009
(0063138)
ika   
2017-01-27 17:08   
Dear MKV,

the branch was rebased.
(0063198)
mkv   
2017-01-30 15:59   
Dear BugMaster,
Branch CR28389 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 65b4ec4fd13e613314c42ef0cddffe4f61d39009

There are following compilation errors:
Linux:
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR28389-master/job/CR28389-master-OCCT-Debian70-64-opt-compile/1/parsed_console/ [^]
/dn54/builds/CR28389-master/Debian70-64-opt/OCCT/src/XCAFDoc/XCAFDoc_ViewTool.hxx:83:24: error: extra qualification 'XCAFDoc_ViewTool::' on member 'RemoveView' [-fpermissive]
MacOS:
http://jenkins-test-07.nnov.opencascade.com:8080/view/CR28389-master/job/CR28389-master-OCCT-MacOS-opt-compile/1/parsed_console/ [^]
/Users/mnt/builds/CR28389-master/MacOS-opt/OCCT/src/XCAFDoc/XCAFDoc_ViewTool.hxx:83:42: error: extra qualification on member 'RemoveView'

Number of compiler warnings:

occt component :
Windows: 2 (0 on master)

products component :
Windows: 0 (0 on master)

There are new additional compilation warnings on Windows platform:
http://jenkins-test-07.nnov.opencascade.com:8080/user/mnt/my-views/view/A_mnt_warnings/portlet/dashboard_portlet_13912/job/CR28389-master-OCCT-Windows-64-VC10-opt-compile/1/warnings34Result/ [^]
XDEDRAW_Views.cxx:83, MSBuild, Priority: Normal
'removeView' : unreferenced local function has been removed
XDEDRAW_Views.cxx:1245, MSBuild, Priority: Normal
'removeClippingPlane' : unreferenced local function has been removed

Regressions/Differences/Improvements:
http://occt-tests/CR28389-master-OCCT/Windows-64-VC10/bugs/xde/bug22962.html [^]
bugs xde bug22962: FAILED
Testing cases:
http://occt-tests/CR28389-master-OCCT/Windows-64-VC10/summary.html#gdt-export [^]
gdt export B9: OK
gdt presentation B8: OK
gdt view A1: OK
gdt view A2: OK
gdt view A3: OK
gdt view A4: OK
gdt view A5: OK
gdt view A6: OK
gdt view A7: OK
gdt view A8: OK
gdt view A9: OK
gdt view B1: OK
gdt view B2: OK
gdt view B3: OK
gdt view B4: OK
gdt view B5: OK
(0063199)
mkv   
2017-01-30 15:59   
Dear ika,
Branch CR28389 has been rejected due to:
- compilation errors
- additional warnings
- regressions/differences/improvements
(0063265)
git   
2017-01-31 15:29   
Branch CR28389 has been updated forcibly by ika.

SHA-1: d95c88e14de9c228b912e9c6a5d04b1746ec105d
(0063266)
ika   
2017-01-31 15:30   
Dear MKV,

the problems are fixed.
(0063345)
mkv   
2017-02-02 12:26   
Dear BugMaster,
Branch CR28389 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: d95c88e14de9c228b912e9c6a5d04b1746ec105d

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1137

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
http://occt-tests/CR28389-master-OCCT/Debian70-64/summary.html#gdt-export [^]
http://occt-tests/CR28389-master-OCCT/Windows-64-VC10/summary.html#gdt-export [^]
gdt export B9: OK
gdt presentation B8: OK
gdt view A1: OK
gdt view A2: OK
gdt view A3: OK
gdt view A4: OK
gdt view A5: OK
gdt view A6: OK
gdt view A7: OK
gdt view A8: OK
gdt view A9: OK
gdt view B1: OK
gdt view B2: OK
gdt view B3: OK
gdt view B4: OK
gdt view B5: OK

Testing on Linux:
occt component :
Total MEMORY difference: 92492964 / 92287721 [+0.22%]
Total CPU difference: 20020.710000000166 / 19914.260000000217 [+0.53%]
products component :
Total MEMORY difference: 31518218 / 31477908 [+0.13%]
Total CPU difference: 5596.959999999969 / 5544.959999999981 [+0.94%]

Testing on Windows:
occt component :
Total MEMORY difference: 57629695 / 57618048 [+0.02%]
Total CPU difference: 18553.29253059854 / 18683.178963198647 [-0.70%]
products component :
Total MEMORY difference: 22662893 / 22621210 [+0.18%]
Total CPU difference: 5617.315208199978 / 5570.546108399986 [+0.84%]

There are no differences in images found by testdiff.
(0063346)
mkv   
2017-02-02 12:26   
Dear BugMaster,
Branch CR28389 is TESTED.
(0063626)
git   
2017-02-08 11:36   
Branch CR28389 has been deleted by kgv.

SHA-1: d95c88e14de9c228b912e9c6a5d04b1746ec105d