MantisBT - Open CASCADE
View Issue Details
0028369Open CASCADE[OCCT] OCCT:Visualizationpublic2017-01-18 13:442017-09-29 16:24
dbp 
apn 
normalfeature 
closedfixed 
 
[OCCT] 7.2.0[OCCT] 7.2.0 
v3d raytrace sample_cube_clamp
0028369: Visualization, Path Tracing - Expose radiance clamping setting in path tracing mode
In some cases, it is very desirable to control radiance clamping value used by path tracing engine. Smaller value allows to decrease visible noise and get final result (sometimes much) faster, but it introduces extra bias. The main drawback is that caustics may become more dark or even dissapear. The higher value allows to keep path tracing unbiased, but may require more time for image convergence. The default value provides reasonable compromise between these properties, but it is not suitable for all the cases. So, the parameter to control this value is needed.
vrenderparams -maxrad <value>
No tags attached.
png sample_cube_clamp_1.png (314,275) 2017-01-18 14:35
https://tracker.dev.opencascade.org/
png sample_cube_clamp_2.png (338,138) 2017-01-18 14:35
https://tracker.dev.opencascade.org/
png sample_cube_clamp_10.png (363,139) 2017-01-18 14:35
https://tracker.dev.opencascade.org/
png sample_cube_clamp_100.png (369,983) 2017-01-18 14:35
https://tracker.dev.opencascade.org/
Issue History
2017-01-18 13:44dbpNew Issue
2017-01-18 13:44dbpAssigned To => dbp
2017-01-18 14:35gitNote Added: 0062750
2017-01-18 14:35dbpFile Added: sample_cube_clamp_1.png
2017-01-18 14:35dbpFile Added: sample_cube_clamp_2.png
2017-01-18 14:35dbpFile Added: sample_cube_clamp_10.png
2017-01-18 14:35dbpFile Added: sample_cube_clamp_100.png
2017-01-18 14:36dbpNote Added: 0062751
2017-01-18 14:36dbpAssigned Todbp => kgv
2017-01-18 14:36dbpStatusnew => resolved
2017-01-18 14:36dbpSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15866#r15866
2017-01-18 14:37dbpNote Added: 0062753
2017-01-18 16:10kgvNote Added: 0062761
2017-01-18 16:10kgvAssigned Tokgv => dbp
2017-01-18 16:10kgvStatusresolved => feedback
2017-01-18 16:56gitNote Added: 0062763
2017-01-18 16:56dbpNote Added: 0062765
2017-01-18 16:56dbpAssigned Todbp => kgv
2017-01-18 16:56dbpStatusfeedback => resolved
2017-01-18 16:58kgvNote Added: 0062766
2017-01-18 16:58kgvAssigned Tokgv => bugmaster
2017-01-18 16:58kgvSeverityminor => feature
2017-01-18 16:58kgvStatusresolved => reviewed
2017-01-18 17:34apvTest case number => v3d raytrace sample_cube_clamp
2017-01-18 17:34apvAssigned Tobugmaster => apv
2017-01-19 15:07apvNote Added: 0062802
2017-01-19 15:07apvAssigned Toapv => bugmaster
2017-01-19 15:07apvStatusreviewed => tested
2017-01-20 16:12apnChangeset attached => occt master b09447ed
2017-01-20 16:12apnAssigned Tobugmaster => apn
2017-01-20 16:12apnStatustested => verified
2017-01-20 16:12apnResolutionopen => fixed
2017-02-08 11:36gitNote Added: 0063618
2017-09-29 16:21aivFixed in Version => 7.2.0
2017-09-29 16:24aivStatusverified => closed

Notes
(0062750)
git   
2017-01-18 14:35   
Branch CR28369 has been created by dbp.

SHA-1: db3ba90015e7e796612b3b0a9b55a8a83cea322a


Detailed log of new commits:

Author: dbp
Date: Wed Jan 18 14:24:13 2017 +0300

    0028369: Visualization, Path Tracing - Expose radiance clamping setting in path tracing mode
    
    New parameter was added in the vrenderparams command:
    vrenderparams -maxrad <value>
(0062751)
dbp   
2017-01-18 14:36   
Dear kgv,

Could you please the patch in branch CR28369?
(0062753)
dbp   
2017-01-18 14:37   
New test case was added:
test v3d raytrace sample_cube_clamp

Reference images are attached to this issue.
(0062761)
kgv   
2017-01-18 16:10   
Shader resource files are not re-generated.
(0062763)
git   
2017-01-18 16:56   
Branch CR28369 has been updated forcibly by dbp.

SHA-1: f12626f4ad83e8ee49cf79f797ef447096423705
(0062765)
dbp   
2017-01-18 16:56   
Shader resources were regenerated.
(0062766)
kgv   
2017-01-18 16:58   
Please test the patch.
(0062802)
apv   
2017-01-19 15:07   
Dear BugMaster,

Branch CR28369 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: f12626f4ad83e8ee49cf79f797ef447096423705

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 63
   Windows: 0
   MacOS: 1144

Regressions/Differences:
Not detected

Testing cases:
v3d raytrace sample_cube_clamp - OK
http://occt-tests/CR28369-master-OCCT/Debian70-64/v3d/raytrace/sample_cube_clamp.html [^]
http://occt-tests/CR28369-master-OCCT/Windows-64-VC10/v3d/raytrace/sample_cube_clamp.html [^]

Testing on Linux:
Total MEMORY difference: 93510686 / 92923112 [+0.63%]
Total CPU difference: 21396.580000000173 / 21506.1200000003 [-0.51%]

Testing on Windows:
Total MEMORY difference: 58632152 / 58649007 [-0.03%]
Total CPU difference: 19512.745480898564 / 19749.742200098677 [-1.20%]
(0063618)
git   
2017-02-08 11:36   
Branch CR28369 has been deleted by kgv.

SHA-1: f12626f4ad83e8ee49cf79f797ef447096423705