MantisBT - Open CASCADE
View Issue Details
0028367Open CASCADE[OCCT] OCCT:DRAWpublic2017-01-18 10:572017-09-29 16:24
kgv 
apn 
normalminor 
closedfixed 
[OCCT] 7.1.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028367: Draw Harness - XSave should print an error on store failure
XSave command does not print any error on storage failure - TDocStd_Application::SaveAs() result is ignored. It does not look correct.
N/A
No tags attached.
Issue History
2017-01-18 10:57kgvNew Issue
2017-01-18 10:57kgvAssigned To => mpv
2017-01-18 10:59gitNote Added: 0062735
2017-01-18 10:59kgvNote Added: 0062736
2017-01-18 10:59kgvStatusnew => resolved
2017-01-20 17:49mpvNote Added: 0062855
2017-01-20 17:49mpvAssigned Tompv => bugmaster
2017-01-20 17:49mpvStatusresolved => reviewed
2017-01-20 19:11gitNote Added: 0062874
2017-01-20 19:12apvNote Added: 0062876
2017-01-20 19:14apvTest case number => Not needed
2017-01-20 19:14apvAssigned Tobugmaster => apv
2017-01-23 12:54apvAssigned Toapv => mkv
2017-01-25 15:53mkvNote Added: 0063026
2017-01-25 15:53mkvNote Added: 0063027
2017-01-25 15:53mkvAssigned Tomkv => bugmaster
2017-01-25 15:53mkvStatusreviewed => tested
2017-01-27 16:15apnChangeset attached => occt master 61887a4a
2017-01-27 16:15apnAssigned Tobugmaster => apn
2017-01-27 16:15apnStatustested => verified
2017-01-27 16:15apnResolutionopen => fixed
2017-02-08 11:36gitNote Added: 0063616
2017-09-29 16:21aivFixed in Version => 7.2.0
2017-09-29 16:24aivStatusverified => closed

Notes
(0062735)
git   
2017-01-18 10:59   
Branch CR28367 has been created by kgv.

SHA-1: 72e723df75589f7980e09627295dd66792a627a2


Detailed log of new commits:

Author: kgv
Date: Wed Jan 18 10:59:35 2017 +0300

    0028367: Draw Harness - XSave should print an error on store failure
(0062736)
kgv   
2017-01-18 10:59   
Patch is ready for review.
(0062855)
mpv   
2017-01-20 17:49   
OK, let it be like this right now.
Duplicated methods in different OCAF draw-packages is another story.
And receiving of more precised information about an error is also: there are too many ways to get advanced messages in different cases, so it must be collected in one method, I guess. Then it could be used.

Reviewed, ready for testing.
(0062874)
git   
2017-01-20 19:11   
Branch CR28367 has been updated forcibly by apv.

SHA-1: 1e5454695f1d22214423edfe15a83b53c47f69ab
(0062876)
apv   
2017-01-20 19:12   
Branch CR28367 has been rebased on the current master
(0063026)
mkv   
2017-01-25 15:53   
Dear BugMaster,
Branch CR28367 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 1e5454695f1d22214423edfe15a83b53c47f69ab

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1135

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 93331041 / 92055887 [+1.39%]
Total CPU difference: 21386.320000000127 / 21062.120000000155 [+1.54%]
products component :
Total MEMORY difference: 31305592 / 31311912 [-0.02%]
Total CPU difference: 5552.349999999974 / 5531.039999999989 [+0.39%]

Testing on Windows:
occt component :
Total MEMORY difference: 58327453 / 58324216 [+0.01%]
Total CPU difference: 19785.57562979855 / 19152.585972198493 [+3.30%]
products component :
Total MEMORY difference: 22558081 / 22520482 [+0.17%]
Total CPU difference: 5505.868093799953 / 5374.920854399972 [+2.44%]

There are no differences in images found by testdiff.
(0063027)
mkv   
2017-01-25 15:53   
Dear BugMaster,
Branch CR28367 is TESTED.
(0063616)
git   
2017-02-08 11:36   
Branch CR28367 has been deleted by kgv.

SHA-1: 1e5454695f1d22214423edfe15a83b53c47f69ab