MantisBT - Open CASCADE
View Issue Details
0028332Open CASCADE[OCCT] OCCT:Data Exchangepublic2017-01-03 21:232017-09-29 16:29
abv 
bugmaster 
normalminor 
closedfixed 
 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not required
0028332: Unstable tests in group gdt export
Tests in group gdt export are not stable: some of them fail from time to time.
Here is example of my log, comparing two runs of current master:

STATUS gdt export A3: OK / FAILED
STATUS gdt export B2: FAILED / OK

As far as I can see on both these examples, the problem is that GDT data get lost after writing. Here ix extract from log:

========================== Comparision with reference data ========

Error : 8 differences with reference data found :

 Reference data - NbOfDimensions : 10
 Current data - NbOfDimensions : 10
 Current data after writing - NbOfDimensions : 0

(further the same for other NbOf* parameters)
Not requared.
No tags attached.
Issue History
2017-01-03 21:23abvNew Issue
2017-01-03 21:23abvAssigned To => gka
2017-08-15 17:11abvAssigned Togka => ika
2017-08-15 17:11abvStatusnew => assigned
2017-08-21 15:33gitNote Added: 0069716
2017-08-21 16:08kgvNote Added: 0069718
2017-08-21 16:40gitNote Added: 0069720
2017-08-22 10:27ikaNote Added: 0069732
2017-08-22 10:27ikaAssigned Toika => abv
2017-08-22 10:27ikaStatusassigned => resolved
2017-08-22 10:27ikaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17361#r17361
2017-08-22 15:06abvNote Added: 0069749
2017-08-22 15:06abvAssigned Toabv => bugmaster
2017-08-22 15:06abvStatusresolved => reviewed
2017-08-24 11:27bugmasterTest case number => Not required
2017-08-24 11:29bugmasterNote Added: 0069819
2017-08-24 11:29bugmasterStatusreviewed => tested
2017-08-24 11:44bugmasterNote Edited: 0069819bug_revision_view_page.php?bugnote_id=69819#r17384
2017-08-25 15:02bugmasterChangeset attached => occt master 5b83cdb6
2017-08-25 15:02bugmasterStatustested => verified
2017-08-25 15:02bugmasterResolutionopen => fixed
2017-08-25 16:13gitNote Added: 0069897
2017-09-29 16:17aivFixed in Version => 7.2.0
2017-09-29 16:29aivStatusverified => closed

Notes
(0069716)
git   
2017-08-21 15:33   
Branch CR28332 has been created by ika.

SHA-1: 10f35e3aecbde44ac25d53c7d808745aab19e4ff


Detailed log of new commits:

Author: ika
Date: Mon Aug 21 15:22:39 2017 +0300

    0028332: Unstable tests in group gdt export
    
    Add initialization of variable GDTMode in STEP writer.
(0069718)
kgv   
2017-08-21 16:08   
@@ -299,6 +299,7 @@ STEPCAFControl_Writer::STEPCAFControl_Writer (const Handle(XSControl_WorkSession
   
myLayerMode = Standard_True;
   myPropsMode = Standard_True;
   mySHUOMode = Standard_True;
+  myGDTMode = Standard_True;
 }

It looks dangerous calling any class methods before all class fields have been initialized.
Please move all assignments to members initialization list, and keep only these that should be overridden by Init(), but are there any?
(0069720)
git   
2017-08-21 16:40   
Branch CR28332 has been updated forcibly by ika.

SHA-1: 2483717eece32c332c045bccfd6abd92615473e6
(0069732)
ika   
2017-08-22 10:27   
Dear ABV,

could you please review brach CR28332?

test results:
http://jenkins-test-10.nnov.opencascade.com/view/CR28332-master-ika/ [^]
bugs vis bug5682 - unstable test case, which cannot be affected by changes in this issue.
(0069749)
abv   
2017-08-22 15:06   
No remarks, please integrate
(0069819)
bugmaster   
2017-08-24 11:29   
(edited on: 2017-08-24 11:44)
Combination -
OCCT branch : CR28332 : SHA-1: 2483717eece32c332c045bccfd6abd92615473e6
Products branch : master
was compiled on Linux, MacOS and Windows platforms and tested on optimize mode.

Number of compiler warnings:

OCCT :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

Products :
Linux: 5 (5 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:

Windows:
OCCT
Total CPU difference: 17330.010689098726 / 17295.75286949859 [+0.20%]
Producst
Total CPU difference: 7688.758886599963 / 7720.302288799964 [-0.41%]

Linux:
OCCT
Total CPU difference: 19451.89000000023 / 19456.560000000376 [-0.02%]
Products
Total CPU difference: 7703.40000000009 / 7725.120000000072 [-0.28%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

(0069897)
git   
2017-08-25 16:13   
Branch CR28332 has been deleted by kgv.

SHA-1: 2483717eece32c332c045bccfd6abd92615473e6