0028316: Coding Rules - Elimilate confusing aliases of Standard_Real type in V3d_View

MantisBT - Community

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0028316

Community

[OCCT] OCCT:Coding

public

2016-12-29 10:34

2017-09-29 16:29

Reporter

Vico Liang

Assigned To

bugmaster

Priority

normal

Severity

integration request

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

[OCCT] 6.3.1

Target Version

[OCCT] 7.2.0

Fixed in Version

[OCCT] 7.2.0

Test case number

Not needed

Summary

0028316: Coding Rules - Elimilate confusing aliases of Standard_Real type in V3d_View

Description

In clas V3d_View, it used several kinds of typedef of Standard_Real, it's inconvinient and confused when calling methods with these arguments. It would be more clear to replace it with their raw type Standard_Real.

Quantity_Factor
Quantity_Coefficient
V3d_Coordinate
Quantity_Parameter

List several method as below:

  Standard_EXPORT void SetSize (const Quantity_Length theSize);
  Standard_EXPORT void SetZoom (const Quantity_Factor Coef, const Standard_Boolean Start = Standard_True);
  Standard_EXPORT void SetScale (const Quantity_Factor Coef);
  Standard_EXPORT void FitAll (const Quantity_Coefficient theMargin = 0.01, const Standard_Boolean theToUpdate = Standard_True);
  Standard_EXPORT void Convert (const V3d_Coordinate X, const V3d_Coordinate Y, const V3d_Coordinate Z, Standard_Integer& Xp, Standard_Integer& Yp) const;
  Standard_EXPORT void Proj (Quantity_Parameter& Vx, Quantity_Parameter& Vy, Quantity_Parameter& Vz) const;

Steps To Reproduce

Additional information
and documentation updates