MantisBT - Community
View Issue Details
0028316Community[OCCT] OCCT:Codingpublic2016-12-29 10:342017-09-29 16:29
Vico Liang 
bugmaster 
normalintegration request 
closedfixed 
[OCCT] 6.3.1 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028316: Coding Rules - Elimilate confusing aliases of Standard_Real type in V3d_View
In clas V3d_View, it used several kinds of typedef of Standard_Real, it's inconvinient and confused when calling methods with these arguments. It would be more clear to replace it with their raw type Standard_Real.

Quantity_Factor
Quantity_Coefficient
V3d_Coordinate
Quantity_Parameter

List several method as below:

  Standard_EXPORT void SetSize (const Quantity_Length theSize);
  Standard_EXPORT void SetZoom (const Quantity_Factor Coef, const Standard_Boolean Start = Standard_True);
  Standard_EXPORT void SetScale (const Quantity_Factor Coef);
  Standard_EXPORT void FitAll (const Quantity_Coefficient theMargin = 0.01, const Standard_Boolean theToUpdate = Standard_True);
  Standard_EXPORT void Convert (const V3d_Coordinate X, const V3d_Coordinate Y, const V3d_Coordinate Z, Standard_Integer& Xp, Standard_Integer& Yp) const;
  Standard_EXPORT void Proj (Quantity_Parameter& Vx, Quantity_Parameter& Vy, Quantity_Parameter& Vz) const;
No tags attached.
related to 0028799closed bugmaster Community Coding Rules - elimilate confusing Quantity aliases of Standard_Real type 
Issue History
2016-12-29 10:34Vico LiangNew Issue
2016-12-29 10:34Vico LiangAssigned To => kgv
2016-12-29 10:36Vico LiangDescription Updatedbug_revision_view_page.php?rev_id=15722#r15722
2016-12-29 10:38Vico LiangDescription Updatedbug_revision_view_page.php?rev_id=15723#r15723
2016-12-29 10:43kgvCategoryOCCT:Visualization => OCCT:Coding
2016-12-29 10:43kgvSummaryElimilate confusion typedef and replace it with the raw type in V3d_View => Coding Rules - Elimilate confusing aliases of Standard_Real type in V3d_View
2016-12-29 12:08kgvProduct Version => 6.3.1
2017-05-31 08:43Vico LiangRelationship addedrelated to 0028799
2017-05-31 16:47gitNote Added: 0066935
2017-05-31 16:49kgvNote Added: 0066937
2017-05-31 16:49kgvAssigned Tokgv => bugmaster
2017-05-31 16:49kgvStatusnew => resolved
2017-05-31 16:49kgvSeverityminor => integration request
2017-05-31 16:49kgvStatusresolved => reviewed
2017-05-31 16:57mkvAssigned Tobugmaster => mkv
2017-05-31 19:39mkvNote Added: 0066948
2017-05-31 19:39mkvNote Added: 0066949
2017-05-31 19:39mkvAssigned Tomkv => bugmaster
2017-05-31 19:39mkvStatusreviewed => tested
2017-05-31 19:39mkvTest case number => Not needed
2017-06-02 10:28bugmasterChangeset attached => occt master ee2be2a8
2017-06-02 10:28bugmasterStatustested => verified
2017-06-02 10:28bugmasterResolutionopen => fixed
2017-06-02 10:45gitNote Added: 0066984
2017-08-24 15:06kgvRelationship addedparent of 0029047
2017-09-29 16:17aivFixed in Version => 7.2.0
2017-09-29 16:29aivStatusverified => closed

Notes
(0066935)
git   
2017-05-31 16:47   
Branch CR28316 has been created by kgv.

SHA-1: 28c9bb58a79cdab9469a7a60cf1bf6da9d80bd6d


Detailed log of new commits:

Author: kgv
Date: Tue May 30 13:43:59 2017 +0300

    0028316: Coding Rules - Elimilate confusing aliases of Standard_Real type in V3d_View
    
    Quantity_Factor, Quantity_Parameter, Quantity_Ratio, Quantity_Coefficient,
    Quantity_PlaneAngle, Quantity_Length, V3d_Parameter and V3d_Coordinate
    have been replaced by Standard_Real in visualization classes.
(0066937)
kgv   
2017-05-31 16:49   
Please check compilation, regression testing is not needed.
(0066948)
mkv   
2017-05-31 19:39   
Dear BugMaster,
Branch CR28316 from occt git-repository (and CR28316 from products git-repository) was compiled on Linux, MacOS and Windows platforms on Release mode.
SHA-1: 28c9bb58a79cdab9469a7a60cf1bf6da9d80bd6d
SHA-1: 70855c037315d9703bb48c41ea67adf8f82122ee

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1194
(0066949)
mkv   
2017-05-31 19:39   
Dear BugMaster,
Branch CR28316 from occt git-repository and branch CR28316 from products git-repository are TESTED.
(0066984)
git   
2017-06-02 10:45   
Branch CR28316 has been deleted by inv.

SHA-1: 28c9bb58a79cdab9469a7a60cf1bf6da9d80bd6d