MantisBT - Open CASCADE
View Issue Details
0028276Open CASCADE[OCCT] OCCT:Visualizationpublic2016-12-23 21:192017-09-29 16:31
kgv 
apn 
normalminor 
closedfixed 
WindowsVC++ 201064 bit
[OCCT] 6.8.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028276: Visualization, Graphic3d_ArrayOfPrimitives - fix usage of 16-bit indices
Graphic3d_ArrayOfPrimitives decides to allocate 16-bit or 32-bit indices within the following check:
    if (theMaxEdges < Standard_Integer(USHRT_MAX))
    {
      if (!myIndices->Init<unsigned short> (theMaxEdges))
      {
        myIndices.Nullify();
        return;
      }
    }
    else
    {
      if (!myIndices->Init<unsigned int> (theMaxEdges))
      {
        myIndices.Nullify();
        return;
      }
    }


This check is OK for normally compressed data.

However, external data might include exhaustive amount of vertex data requiring 32-bit indexation while overall amount of indices is still small.
N/A
No tags attached.
related to 0024406closed apn Visualization - crash on re-usage of the same primitive array 
related to 0026081closed bugmaster Visualization, TKOpenGl - rebuild vertex attributes in order to not render large index arrays in OpenGL ES 
png indices_KO.png (249,052) 2016-12-23 21:19
https://tracker.dev.opencascade.org/
png indices_OK.png (217,750) 2016-12-23 21:19
https://tracker.dev.opencascade.org/
Issue History
2016-12-23 21:19kgvNew Issue
2016-12-23 21:19kgvAssigned To => kgv
2016-12-23 21:19kgvFile Added: indices_KO.png
2016-12-23 21:19kgvFile Added: indices_OK.png
2016-12-23 21:22gitNote Added: 0062087
2016-12-23 21:22kgvNote Added: 0062088
2016-12-23 21:22kgvAssigned Tokgv => san
2016-12-23 21:22kgvStatusnew => resolved
2016-12-23 21:24kgvRelationship addedrelated to 0024406
2016-12-23 21:24kgvProduct Version => 6.8.0
2016-12-23 21:26kgvRelationship addedrelated to 0026081
2016-12-24 16:26sanNote Added: 0062089
2016-12-24 16:26sanAssigned Tosan => kgv
2016-12-24 16:26sanStatusresolved => feedback
2016-12-24 16:46sanNote Added: 0062090
2016-12-24 16:46sanAssigned Tokgv => bugmaster
2016-12-24 16:46sanStatusfeedback => reviewed
2016-12-26 14:44apvAssigned Tobugmaster => apv
2016-12-26 14:53apvTest case number => Not needed
2016-12-27 12:20apvNote Added: 0062167
2016-12-27 12:20apvAssigned Toapv => bugmaster
2016-12-27 12:20apvStatusreviewed => tested
2016-12-30 18:08apnChangeset attached => occt master 09f30297
2016-12-30 18:08apnAssigned Tobugmaster => apn
2016-12-30 18:08apnStatustested => verified
2016-12-30 18:08apnResolutionopen => fixed
2017-02-08 11:32gitNote Added: 0063573
2017-09-29 16:21aivFixed in Version => 7.2.0
2017-09-29 16:31aivStatusverified => closed

Notes
(0062087)
git   
2016-12-23 21:22   
Branch CR28276 has been created by kgv.

SHA-1: b131c5c5bdbfb8cc90712e932140dc3f1c639c28


Detailed log of new commits:

Author: kgv
Date: Fri Dec 23 21:21:00 2016 +0300

    0028276: Visualization, Graphic3d_ArrayOfPrimitives - fix usage of 16-bit indices
    
    Graphic3d_ArrayOfPrimitives now check the amount of vertex data rather than amount of indices.
(0062088)
kgv   
2016-12-23 21:22   
Patch is ready for review.
(0062089)
san   
2016-12-24 16:26   
Is it possible to implement a simple test case using pure OCCT capabilities (i.e. outside CAD Assistant)?
(0062090)
san   
2016-12-24 16:46   
Branch CR28276 reviewed without remarks, ready for testing.
(0062167)
apv   
2016-12-27 12:20   
Dear BugMaster,

Branch CR28276 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: b131c5c5bdbfb8cc90712e932140dc3f1c639c28

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 63
   Windows: 0
   MacOS: 1126

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 92817441 / 93054576 [-0.25%]
Total CPU difference: 21527.880000000092 / 21520.74000000037 [+0.03%]

Testing on Windows:
Total MEMORY difference: 58626750 / 58650770 [-0.04%]
Total CPU difference: 19440.75101939849 / 19731.318481998722 [-1.47%]
(0063573)
git   
2017-02-08 11:32   
Branch CR28276 has been deleted by kgv.

SHA-1: b131c5c5bdbfb8cc90712e932140dc3f1c639c28