MantisBT - Open CASCADE
View Issue Details
0028263Open CASCADE[OCCT] OCCT:Codingpublic2016-12-22 12:472017-09-29 16:31
kgv 
apv 
normalminor 
closedfixed 
[OCCT] 7.1.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028263: Coding Rules - clean up definition of the class Graphic3d_MaterialAspect
Graphic3d_MaterialAspect has interface issues, the following methods operate with raw string Standard_CString, while class is holding TCollection_AsciiString:
  //! Returns the name of this material
  Standard_EXPORT Standard_CString MaterialName() const;


Other issues:
- Class properties are sorted in sub-optimal order (from memory layout point of view).
- It will be more optimal if most trivial methods (getters) will provide inline implementation in class header.
- myRequestedMaterialName property is not-accessible outside.
- Method ::IsEqual() is currently broken (should be fixed by patch for NCollection_Vec3 in #28180).
No tags attached.
Issue History
2016-12-22 12:47kgvNew Issue
2016-12-22 12:47kgvAssigned To => kgv
2016-12-22 13:58kgvRelationship addedrelated to 0028180
2016-12-29 20:39gitNote Added: 0062335
2016-12-29 23:02gitNote Added: 0062341
2016-12-29 23:03kgvNote Added: 0062342
2016-12-29 23:03kgvAssigned Tokgv => san
2016-12-29 23:03kgvStatusnew => resolved
2016-12-29 23:36gitNote Added: 0062346
2017-01-16 20:55sanNote Added: 0062660
2017-01-16 20:55sanAssigned Tosan => bugmaster
2017-01-16 20:55sanStatusresolved => reviewed
2017-01-17 16:07apvAssigned Tobugmaster => apv
2017-01-17 16:15gitNote Added: 0062705
2017-01-17 16:15apvNote Added: 0062706
2017-01-17 16:16apvTest case number => Not needed
2017-01-18 10:43apvNote Added: 0062730
2017-01-18 10:43apvAssigned Toapv => kgv
2017-01-18 10:43apvStatusreviewed => assigned
2017-01-18 10:45apvNote Added: 0062731
2017-01-18 11:15gitNote Added: 0062737
2017-01-18 11:16kgvNote Added: 0062738
2017-01-18 11:16kgvAssigned Tokgv => bugmaster
2017-01-18 11:16kgvStatusassigned => resolved
2017-01-18 11:16kgvStatusresolved => reviewed
2017-01-18 16:57apvAssigned Tobugmaster => apv
2017-01-20 17:44gitNote Added: 0062853
2017-01-20 17:45apvNote Added: 0062854
2017-01-24 12:09apvNote Added: 0062933
2017-01-24 12:09apvAssigned Toapv => bugmaster
2017-01-24 12:09apvStatusreviewed => tested
2017-01-27 16:15apvChangeset attached => occt master 4e1bc39a
2017-01-27 16:15apvAssigned Tobugmaster => apv
2017-01-27 16:15apvStatustested => verified
2017-01-27 16:15apvResolutionopen => fixed
2017-02-08 11:36gitNote Added: 0063600
2017-09-29 16:21aivFixed in Version => 7.2.0
2017-09-29 16:31aivStatusverified => closed

Notes
(0062335)
git   
2016-12-29 20:39   
Branch CR28263 has been created by kgv.

SHA-1: 643a707a77f0365a165c52ea5a5d8ee014e72ef5


Detailed log of new commits:

Author: kgv
Date: Thu Dec 29 20:39:28 2016 +0300

    0028263: Coding Rules - clean up definition of the class Graphic3d_MaterialAspect
    
    Fixed uninitialized fields in several classes.
    Body of trivial methods have been moved to class definition (header file).
    Ensure that non-primitive types are returned by reference, when possible.
(0062341)
git   
2016-12-29 23:02   
Branch CR28263 has been updated forcibly by kgv.

SHA-1: 67b67a587aab2e22de41dd17291f8c6cc694fb91
(0062342)
kgv   
2016-12-29 23:03   
Patch is ready for review.
(0062346)
git   
2016-12-29 23:36   
Branch CR28263 has been updated forcibly by kgv.

SHA-1: 36a8bfa1a507dfcf2ee322289240070963111337
(0062660)
san   
2017-01-16 20:55   
Branch CR28263 reviewed without remarks, ready for testing.
(0062705)
git   
2017-01-17 16:15   
Branch CR28263 has been updated forcibly by apv.

SHA-1: 49ad90f4c8ccf36de03a7cbbd03f804a78ea5394
(0062706)
apv   
2017-01-17 16:15   
Branch CR28263 has been rebased on the current master
(0062730)
apv   
2017-01-18 10:43   
Dear BugMaster,

During building of branch CR28263 (SHA-1: 49ad90f4c8ccf36de03a7cbbd03f804a78ea5394) from occt git-repository (and master from products git-repository) compilation errors have been detected.
On Linux:
http://jenkins-test-05.nnov.opencascade.com/view/CR28263-master/job/CR28263-master-OCCT-Debian70-64-opt-compile/1/parsed_console/ [^]
On Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR28263-master/job/CR28263-master-OCCT-Windows-64-VC10-opt-compile/1/parsed_console/ [^]
On MacOS:
http://jenkins-test-05.nnov.opencascade.com/view/CR28263-master/job/CR28263-master-OCCT-MacOS-opt-compile/1/parsed_console/ [^]
(0062731)
apv   
2017-01-18 10:45   
Dear Kirill,

Branch CR28263 has been rejected due to:
- compilation errors
(0062737)
git   
2017-01-18 11:15   
Branch CR28263 has been updated forcibly by kgv.

SHA-1: 1fd2617fb6d5eaa0e02596b086972c5374a28702
(0062738)
kgv   
2017-01-18 11:16   
Please check updated patch with fixed misprint.
(0062853)
git   
2017-01-20 17:44   
Branch CR28263 has been updated forcibly by apv.

SHA-1: 4e1bc39a81fc965d86aae06555a7c4a50bbf4eea
(0062854)
apv   
2017-01-20 17:45   
Branch CR28263 has been rebased on the current master
(0062933)
apv   
2017-01-24 12:09   
Dear BugMaster,

Branch CR28263 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 4e1bc39a81fc965d86aae06555a7c4a50bbf4eea

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 63
   Windows: 0
   MacOS: 1151

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 93105166 / 92063498 [+1.13%]
Total CPU difference: 21056.440000000253 / 21062.120000000155 [-0.03%]

Testing on Windows:
Total MEMORY difference: 58325545 / 58324216 [+0.00%]
Total CPU difference: 19347.24401999861 / 19152.585972198493 [+1.02%]
(0063600)
git   
2017-02-08 11:36   
Branch CR28263 has been deleted by kgv.

SHA-1: 4e1bc39a81fc965d86aae06555a7c4a50bbf4eea