MantisBT - Open CASCADE
View Issue Details
0028215Open CASCADE[OCCT] OCCT:Visualizationpublic2016-12-13 12:262017-09-29 16:31
kgv 
apn 
normalfeature 
closedfixed 
 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028215: Visualization - define EMPTY type line for consistenct with Interior Style
There is inconsistency between Fill Area aspects and Line Aspects - while Fill Area aspect defined empty type Aspect_IS_EMPTY (e.g. no faces), there is no such equivalent for Lines.

Such type might be useful in rare cases when specific arrays should be temporarily hidden (while preserving their presentation data).
No tags attached.
Issue History
2016-12-13 12:26kgvNew Issue
2016-12-13 12:26kgvAssigned To => kgv
2016-12-13 12:42gitNote Added: 0061608
2016-12-13 12:42kgvNote Added: 0061609
2016-12-13 12:42kgvAssigned Tokgv => san
2016-12-13 12:42kgvStatusnew => resolved
2016-12-13 21:28sanNote Added: 0061640
2016-12-13 21:28sanAssigned Tosan => bugmaster
2016-12-13 21:28sanStatusresolved => reviewed
2016-12-14 10:57mkvAssigned Tobugmaster => mkv
2016-12-15 12:06mkvNote Added: 0061687
2016-12-15 12:06mkvNote Added: 0061688
2016-12-15 12:06mkvAssigned Tomkv => bugmaster
2016-12-15 12:06mkvStatusreviewed => tested
2016-12-15 12:06mkvTest case number => Not needed
2016-12-16 16:34apnChangeset attached => occt master 3a4a3962
2016-12-16 16:34apnAssigned Tobugmaster => apn
2016-12-16 16:34apnStatustested => verified
2016-12-16 16:34apnResolutionopen => fixed
2016-12-18 10:53gitNote Added: 0061817
2017-09-29 16:21aivFixed in Version => 7.2.0
2017-09-29 16:31aivStatusverified => closed

Notes
(0061608)
git   
2016-12-13 12:42   
Branch CR28215 has been created by kgv.

SHA-1: 10b400e4fee180d22b430e1383efa8b83e0fb0ee


Detailed log of new commits:

Author: kgv
Date: Tue Dec 13 12:36:41 2016 +0300

    0028215: Visualization - define EMPTY type line for consistenct with Interior Style
    
    Added new values Aspect_TOL_EMPTY (line type) and Aspect_TOM_EMPTY (marker type).
(0061609)
kgv   
2016-12-13 12:42   
Patch is ready for review.
(0061640)
san   
2016-12-13 21:28   
Branch CR28215 reviewed without remarks, ready for testing.
(0061687)
mkv   
2016-12-15 12:06   
Dear BugMaster,
Branch CR28215 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 10b400e4fee180d22b430e1383efa8b83e0fb0ee

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1139

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 92451401 / 92761416 [-0.33%]
Total CPU difference: 21449.600000000235 / 21420.040000000274 [+0.14%]
products component :
Total MEMORY difference: 30113367 / 30095445 [+0.06%]
Total CPU difference: 5335.949999999976 / 5303.47999999998 [+0.61%]

Testing on Windows:
occt component :
Total MEMORY difference: 58455356 / 58462136 [-0.01%]
Total CPU difference: 20101.430854498583 / 20176.91973839851 [-0.37%]
products component :
Total MEMORY difference: 20893072 / 20859840 [+0.16%]
Total CPU difference: 5299.587971499974 / 5125.865257899959 [+3.39%]

There are no differences in images found by testdiff.
(0061688)
mkv   
2016-12-15 12:06   
Dear BugMaster,
Branch CR28215 is TESTED.
(0061817)
git   
2016-12-18 10:53   
Branch CR28215 has been deleted by kgv.

SHA-1: 10b400e4fee180d22b430e1383efa8b83e0fb0ee