MantisBT - Open CASCADE
View Issue Details
0028110Open CASCADE[OCCT] OCCT:Configurationpublic2016-11-15 16:452017-09-30 19:53
ski 
apn 
normalminor 
closedfixed 
[OCCT] 6.8.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0028110: Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio
OCCT is already using explicitly Unicode (wide-char) API in most places on Windows and MFC samples are build with Unicode charset. However, project files for OCCT itself are still generated with obsolete multibyte charset flag (both CMake and genproj).

The charset in project files should be changed to Unicode and remaining places relying on UNICODE macros in OCCT should be replaced by usage of wide-char API explicitly (thus technically OCCT should be build in the same way irrelevant to charset options in project settings).
• Generate Visual Studio project via CMake / genproj
• Check that Character set of projects is Unicode
• Build solution
No tags attached.
related to 0024943closed bugmaster Open CASCADE Port MFC sample to UNICODE for compatibility with VS2013 
parent of 0029169closed bugmaster Open CASCADE Configuration - fix compilation with undefined UNICODE on Windows 
related to 0028350closed apn Open CASCADE Draw Harness - DRAWEXE hangs up immediatly when redirecting input stream on Windows 
child of 0022484closed bugmaster Open CASCADE UNICODE characters support. 
Issue History
2016-11-15 16:45skiNew Issue
2016-11-15 16:45skiAssigned To => ski
2016-11-16 10:25kgvCategoryOCCT:Coding => OCCT:Configuration
2016-11-16 10:25kgvSummaryCoding - Port OCCT to UNICODE => Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio
2016-11-16 10:25kgvDescription Updatedbug_revision_view_page.php?rev_id=15334#r15334
2016-11-16 10:26kgvRelationship addedrelated to 0027350
2016-11-16 10:27kgvRelationship addedchild of 0022484
2016-11-16 10:27kgvRelationship addedrelated to 0024943
2016-11-16 10:28kgvProduct Version => 6.8.0
2016-12-08 16:37gitNote Added: 0061503
2016-12-08 17:53skiStatusnew => assigned
2016-12-08 18:06skiNote Added: 0061504
2016-12-08 18:06skiAssigned Toski => abv
2016-12-08 18:06skiStatusassigned => resolved
2016-12-08 18:06skiSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15551#r15551
2016-12-09 21:23gitNote Added: 0061546
2016-12-10 00:44gitNote Added: 0061547
2016-12-10 03:48gitNote Added: 0061548
2016-12-10 03:49gitNote Added: 0061549
2016-12-10 03:54kgvNote Added: 0061550
2016-12-13 13:05abvNote Added: 0061612
2016-12-13 13:05abvAssigned Toabv => bugmaster
2016-12-13 13:05abvStatusresolved => reviewed
2016-12-21 15:13kgvNote Added: 0061957
2016-12-21 15:17apvAssigned Tobugmaster => apv
2016-12-21 17:45gitNote Added: 0061965
2016-12-21 17:45apvNote Added: 0061966
2016-12-22 11:04apvNote Added: 0061985
2016-12-22 11:04apvAssigned Toapv => kgv
2016-12-22 11:04apvStatusreviewed => assigned
2016-12-22 11:04apvNote Added: 0061986
2016-12-22 11:53gitNote Added: 0061995
2016-12-22 11:54gitNote Added: 0061996
2016-12-22 11:54kgvNote Added: 0061997
2016-12-22 11:54kgvAssigned Tokgv => bugmaster
2016-12-22 11:54kgvStatusassigned => resolved
2016-12-22 11:55kgvStatusresolved => reviewed
2016-12-22 12:16apvAssigned Tobugmaster => apv
2016-12-23 16:03gitNote Added: 0062068
2016-12-23 16:04apvNote Added: 0062069
2016-12-26 10:35apvNote Added: 0062107
2016-12-26 10:35apvAssigned Toapv => kgv
2016-12-26 10:35apvStatusreviewed => assigned
2016-12-26 10:35apvTest case number => Not needed
2016-12-26 10:36apvNote Added: 0062108
2016-12-26 12:50kgvNote Added: 0062116
2016-12-26 12:50kgvAssigned Tokgv => bugmaster
2016-12-26 12:50kgvStatusassigned => resolved
2016-12-26 12:50kgvStatusresolved => reviewed
2016-12-26 14:45apvAssigned Tobugmaster => apv
2016-12-27 11:29apvNote Added: 0062162
2016-12-27 11:29apvAssigned Toapv => bugmaster
2016-12-27 11:29apvStatusreviewed => tested
2016-12-30 18:08apnChangeset attached => occt master ad03c234
2016-12-30 18:08apnAssigned Tobugmaster => apn
2016-12-30 18:08apnStatustested => verified
2016-12-30 18:08apnResolutionopen => fixed
2017-01-12 16:53nbvRelationship addedrelated to 0028350
2017-02-08 11:31gitNote Added: 0063542
2017-02-08 11:31gitNote Added: 0063543
2017-02-08 11:31gitNote Added: 0063544
2017-09-29 16:21aivFixed in Version => 7.2.0
2017-09-29 16:24aivStatusverified => closed
2017-09-30 19:53kgvRelationship addedparent of 0029169

Notes
(0061503)
git   
2016-12-08 16:37   
Branch CR28110 has been created by ski.

SHA-1: 8a6f606dc9f16df8968e3c4692a8f020b2eaa43d


Detailed log of new commits:

Author: ski
Date: Mon Nov 14 14:31:00 2016 +0300

    0028110: Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio
    
    Eliminated usage of ANSI methods.
    All Visual Studio projects generated by genproj or CMake use Unicode character set.
(0061504)
ski   
2016-12-08 18:06   
Dear abv,

branch CR28110 contains changed to generate Unicode projects for Visual Studio,
 it is possible now to build occt using both Multibyte and Unicode character sets.

Please review.
(0061546)
git   
2016-12-09 21:23   
Branch CR28110 has been updated forcibly by kgv.

SHA-1: c19b6a853fbc040909d1306bf20c355ad983847d
(0061547)
git   
2016-12-10 00:44   
Branch CR28110 has been updated by kgv.

SHA-1: 824579415631c1819c954a5e4b252a42cd53b8e6


Detailed log of new commits:

Author: kgv
Date: Sat Dec 10 00:44:16 2016 +0300

    corrections

(0061548)
git   
2016-12-10 03:48   
Branch CR28110 has been updated by kgv.

SHA-1: 082f8603f047a0b77bd6f33741015d58531145b6


Detailed log of new commits:

Author: kgv
Date: Sat Dec 10 03:47:59 2016 +0300

    Draw Harness now handles Unicode input on Windows.
    
    Tcl test scripts are now expected in UTF-8 encoding by default.

(0061549)
git   
2016-12-10 03:49   
Branch CR28110_1 has been created by kgv.

SHA-1: 029122cb037ef19372ffb73ba755a5653b2219e8


Detailed log of new commits:

Author: kgv
Date: Sat Dec 10 03:47:59 2016 +0300

    Draw Harness now handles Unicode input on Windows.
    
    Tcl test scripts are now expected in UTF-8 encoding by default.

Author: ski
Date: Mon Nov 14 14:31:00 2016 +0300

    0028110: Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio
    
    Eliminated usage of ANSI methods.
    All Visual Studio projects generated by genproj or CMake use Unicode character set.
(0061550)
kgv   
2016-12-10 03:54   
Updated patch is ready for review.
(0061612)
abv   
2016-12-13 13:05   
No remarks, please test
(0061957)
kgv   
2016-12-21 15:13   
Why the patch is still not processed within normal queue?
(0061965)
git   
2016-12-21 17:45   
Branch CR28110_1 has been updated forcibly by apv.

SHA-1: 9193591deca4a3fbb4962f59b0ce42a1a1bf796e
(0061966)
apv   
2016-12-21 17:45   
Branch CR28110_1 has been rebased on the current master
(0061985)
apv   
2016-12-22 11:04   
Dear BugMaster,

During building of branch CR28110_1 (SHA-1: 9193591deca4a3fbb4962f59b0ce42a1a1bf796e) from occt git-repository (and master from products git-repository) compilation errors have been detected.
On Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR28110_1-master/job/CR28110_1-master-OCCT-Windows-64-VC10-opt-compile/2/parsed_console/ [^]
On MacOS:
http://jenkins-test-05.nnov.opencascade.com/view/CR28110_1-master/job/CR28110_1-master-OCCT-MacOS-opt-compile/2/parsed_console/ [^]
(0061986)
apv   
2016-12-22 11:04   
Dear Kirill,

Branch CR28110_1 has been rejected due to:
- compilation errors
(0061995)
git   
2016-12-22 11:53   
Branch CR28110_1 has been updated by kgv.

SHA-1: 5821edabf5e53db76692a6d2e23cba71ab129c92


Detailed log of new commits:

Author: kgv
Date: Thu Dec 22 11:52:58 2016 +0300

    Correct IVtkDraw::WClass() definition and add missing TCollection_AsciiString definition.

(0061996)
git   
2016-12-22 11:54   
Branch CR28110_2 has been created by kgv.

SHA-1: 1c90075136e8c0a2cd7f798ccaf30404449289a2


Detailed log of new commits:

Author: ski
Date: Mon Nov 14 14:31:00 2016 +0300

    0028110: Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio
    
    Eliminated usage of ANSI methods.
    All Visual Studio projects generated by genproj or CMake use Unicode character set.
    
    Draw Harness now handles Unicode input on Windows.
    Tcl test scripts are now expected in UTF-8 encoding by default.
(0061997)
kgv   
2016-12-22 11:54   
Please check updated patch in branch CR28110_2.
(0062068)
git   
2016-12-23 16:03   
Branch CR28110_2 has been updated forcibly by apv.

SHA-1: 0f2c2785c8a15e82c139d63999b0ed6197e6a17e
(0062069)
apv   
2016-12-23 16:04   
Branch CR28110_2 has been rebased on the current master
(0062107)
apv   
2016-12-26 10:35   
Dear BugMaster,

Branch CR28110_2 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 0f2c2785c8a15e82c139d63999b0ed6197e6a17e

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 63
   Windows: 0
   MacOS: 1132

Compilation errors have been detected during building of CSharp Products samples on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR28110_2-master/job/CR28110_2-master-Products-Windows-64-VC10-csharp-samples/1/parsed_console/ [^]

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 93444851 / 93048855 [+0.43%]
Total CPU difference: 21557.14000000025 / 21520.60000000037 [+0.17%]

Testing on Windows:
Total MEMORY difference: 58631217 / 58650770 [-0.03%]
Total CPU difference: 19384.419058298598 / 19731.318481998722 [-1.76%]
(0062108)
apv   
2016-12-26 10:36   
Dear Kirill,

Branch CR28110_2 has been rejected due to:
- compilation errors
(0062116)
kgv   
2016-12-26 12:50   
Please check compilation of modified C# sample, regression testing is not needed.
(0062162)
apv   
2016-12-27 11:29   
Dear BugMaster,

Branch CR28110_2 from occt git-repository (and CR28110_2 from products git-repository) was compiled on Linux, MacOS and Windows platforms.
SHA-1: 0f2c2785c8a15e82c139d63999b0ed6197e6a17e
SHA-1: 88d177502ae0061ec5d746fcbb8dd588c1e78685

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 63
   Windows: 0
   MacOS: 1152
(0063542)
git   
2017-02-08 11:31   
Branch CR28110 has been deleted by kgv.

SHA-1: 082f8603f047a0b77bd6f33741015d58531145b6
(0063543)
git   
2017-02-08 11:31   
Branch CR28110_1 has been deleted by kgv.

SHA-1: 5821edabf5e53db76692a6d2e23cba71ab129c92
(0063544)
git   
2017-02-08 11:31   
Branch CR28110_2 has been deleted by kgv.

SHA-1: 0f2c2785c8a15e82c139d63999b0ed6197e6a17e