MantisBT - Open CASCADE
View Issue Details
0028095Open CASCADE[OCCT] OCCT:DRAWpublic2016-11-12 14:192016-12-09 16:39
kgv 
apn 
normalminor 
closedfixed 
WindowsVC++ 201564 bit
[OCCT] 7.1.0 
[OCCT] 7.1.0[OCCT] 7.1.0 
Not needed
0028095: Draw Harness, ViewerTest - use RGBA format instead of BGRA within vreadpixel
OpenGL ES has GL_EXT_texture_format_BGRA8888 extension defining BGRA texture format but there are no extensions for glReadPixels()!

Command vreadpixel erroneously uses unsupported format leading to failures within OpenGL ES renderer.
N/A
No tags attached.
related to 0027811closed bugmaster Configuration - allow building TKOpenGl with OpenGL ES on Windows 
related to 0028098new kgv Visualization - errors in tests when using OpenGL ES (ANGLE) 
Issue History
2016-11-12 14:19kgvNew Issue
2016-11-12 14:19kgvAssigned To => kgv
2016-11-12 14:21kgvRelationship addedrelated to 0027811
2016-11-12 14:31kgvDescription Updatedbug_revision_view_page.php?rev_id=15293#r15293
2016-11-12 16:51gitNote Added: 0060261
2016-11-12 16:51kgvNote Added: 0060262
2016-11-12 16:51kgvAssigned Tokgv => san
2016-11-12 16:51kgvStatusnew => resolved
2016-11-13 20:43gitNote Added: 0060266
2016-11-13 23:22gitNote Added: 0060268
2016-11-14 10:17kgvRelationship addedrelated to 0028098
2016-11-14 21:18abvNote Added: 0060329
2016-11-15 19:08sanNote Added: 0060385
2016-11-15 19:08sanAssigned Tosan => bugmaster
2016-11-15 19:08sanStatusresolved => reviewed
2016-11-15 19:20mkvAssigned Tobugmaster => mkv
2016-11-16 18:04mkvNote Added: 0060449
2016-11-16 18:04mkvNote Added: 0060451
2016-11-16 18:04mkvAssigned Tomkv => bugmaster
2016-11-16 18:04mkvStatusreviewed => tested
2016-11-16 18:04mkvTest case number => Not needed
2016-11-17 06:17abvNote Edited: 0060329bug_revision_view_page.php?bugnote_id=60329#r15355
2016-11-18 16:37apnChangeset attached => occt master f9f740d6
2016-11-18 16:37apnAssigned Tobugmaster => apn
2016-11-18 16:37apnStatustested => verified
2016-11-18 16:37apnResolutionopen => fixed
2016-12-07 11:31gitNote Added: 0061290
2016-12-09 16:29aivStatusverified => closed
2016-12-09 16:39aivFixed in Version => 7.1.0

Notes
(0060261)
git   
2016-11-12 16:51   
Branch CR28095 has been created by kgv.

SHA-1: 256776787cc0f4bf5926faff117073bab8ce4a80


Detailed log of new commits:

Author: kgv
Date: Sat Nov 12 16:51:20 2016 +0300

    0028095: Draw Harness, ViewerTest - use RGBA format instead of BGRA within vreadpixel
    
    OpenGl_Workspace::BufferDump() now implicitly converts RGBA dump
    into requested BGR, BGRA and RGB image.
(0060262)
kgv   
2016-11-12 16:51   
Patch is ready for review.
(0060266)
git   
2016-11-13 20:43   
Branch CR28095 has been updated by abv.

SHA-1: 219f23ed14796363102e9953919b9118307ca342


Detailed log of new commits:

Author: abv
Date: Sun Nov 13 20:42:53 2016 +0300

    DRAW command dversion is improved to report OpenGL variant used (desktop or ES); reporting of version of MSVC is corrected for VC14 and above; reporting of HAVE_OPENCL option is removed.
    
    Usage of command vdump is corrected in some tests to specify extension .png for an image file.
    
    Compiler warning is eliminated in OpenGl_Text.cxx (OpenGL ES mode only).

(0060268)
git   
2016-11-13 23:22   
Branch CR28095 has been updated forcibly by kgv.

SHA-1: 39f0075338d791cf349dc5d9e4fb3a358ee110c3
(0060329)
abv   
2016-11-14 21:18   
(edited on: 2016-11-17 06:17)
I confirm that this fix resolves problems on ~ 280 test cases when running on Windows with ANGLE

(0060385)
san   
2016-11-15 19:08   
Branch CR28095 reviewed without remarks, ready for testing.
(0060449)
mkv   
2016-11-16 18:04   
Dear BugMaster,
Branch CR28095 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 39f0075338d791cf349dc5d9e4fb3a358ee110c3

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1125

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 91550787 / 91876668 [-0.35%]
Total CPU difference: 21674.74000000023 / 21600.690000000308 [+0.34%]
products component :
Total MEMORY difference: 29925013 / 29934528 [-0.03%]
Total CPU difference: 5318.629999999979 / 5309.129999999963 [+0.18%]

Testing on Windows:
occt component :
Total MEMORY difference: 56588716 / 56597852 [-0.02%]
Total CPU difference: 20301.112134498435 / 19669.510885798518 [+3.21%]
products component :
Total MEMORY difference: 20822560 / 20790286 [+0.16%]
Total CPU difference: 5307.6064228999685 / 5153.477434899959 [+2.99%]

There are no differences in images found by testdiff.
(0060451)
mkv   
2016-11-16 18:04   
Dear BugMaster,
Branch CR28095 is TESTED.
(0061290)
git   
2016-12-07 11:31   
Branch CR28095 has been deleted by kgv.

SHA-1: 39f0075338d791cf349dc5d9e4fb3a358ee110c3