MantisBT - Open CASCADE
View Issue Details
0028061Open CASCADE[OCCT] OCCT:Samplespublic2016-11-07 19:472016-12-09 16:39
ski 
apn 
highmajor 
closedfixed 
WindowsVC++ 201064 bit
[OCCT] 7.1.0 
[OCCT] 7.1.0[OCCT] 7.1.0 
bugs vis bug28061
0028061: Samples - Highlighting of any object with "Hidden On" option leads to crash in mfc Modeling
Highlighting of any object with "Hidden On" option leads to crash in mfc Modeling
Within Draw Harness:
pload MODELING VISUALIZATION
box b 1 2 3

vclear
vinit View1
vdisplay -dispMode 1 b
vfit
vhlr on
vmoveto 250 250


Within MFC sample:
• Run mfc Modeling sample
• Create boxes using "Box" button
• Press "Hidden On" button
• Try to highlight any box

No tags attached.
child of 0027818closed kgv Visualization - provide an interface to define highlight presentation properties 
Issue History
2016-11-07 19:47skiNew Issue
2016-11-07 19:47skiAssigned To => abv
2016-11-08 14:02kgvProduct Version => 7.1.0
2016-11-08 14:02kgvTarget Version7.2.0 => 7.1.0
2016-11-08 14:02kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15230#r15230
2016-11-08 14:02kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15231#r15231
2016-11-08 14:04kgvRelationship addedchild of 0027818
2016-11-08 14:06kgvNote Added: 0060010
2016-11-08 14:06kgvAssigned Toabv => vpa
2016-11-08 14:06kgvPrioritynormal => high
2016-11-08 14:06kgvStatusnew => assigned
2016-11-08 14:07kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15232#r15232
2016-11-09 16:07gitNote Added: 0060122
2016-11-09 16:07vpaNote Added: 0060123
2016-11-09 16:07vpaAssigned Tovpa => kgv
2016-11-09 16:07vpaStatusassigned => resolved
2016-11-09 16:51gitNote Added: 0060130
2016-11-09 17:56gitNote Added: 0060144
2016-11-09 19:35gitNote Added: 0060147
2016-11-09 19:35kgvNote Added: 0060148
2016-11-09 19:35kgvAssigned Tokgv => bugmaster
2016-11-09 19:35kgvSeverityminor => major
2016-11-09 19:35kgvStatusresolved => reviewed
2016-11-09 20:45mkvAssigned Tobugmaster => mkv
2016-11-10 17:58mkvNote Added: 0060209
2016-11-10 17:59mkvNote Added: 0060210
2016-11-10 17:59mkvAssigned Tomkv => vpa
2016-11-10 17:59mkvStatusreviewed => feedback
2016-11-10 17:59mkvTest case number => bugs vis bug28061
2016-11-10 18:54vpaAssigned Tovpa => ski
2016-11-10 18:54vpaAssigned Toski => vpa
2016-11-10 19:07vpaNote Added: 0060213
2016-11-10 19:08vpaAssigned Tovpa => mkv
2016-11-11 13:13mkvNote Added: 0060238
2016-11-11 13:13mkvAssigned Tomkv => bugmaster
2016-11-11 13:13mkvStatusfeedback => tested
2016-11-18 16:37apnChangeset attached => occt master 424392e0
2016-11-18 16:37apnAssigned Tobugmaster => apn
2016-11-18 16:37apnStatustested => verified
2016-11-18 16:37apnResolutionopen => fixed
2016-12-07 11:31gitNote Added: 0061271
2016-12-09 16:29aivStatusverified => closed
2016-12-09 16:39aivFixed in Version => 7.1.0

Notes
(0060010)
kgv   
2016-11-08 14:06   
Dear Varvara,

please fix regression introduced within 0027818.
(0060122)
git   
2016-11-09 16:07   
Branch CR28061 has been created by vpa.

SHA-1: c363856eceec2a5ed8e2445edd5724653ca3d9eb


Detailed log of new commits:

Author: vpa
Date: Wed Nov 9 16:06:44 2016 +0300

    0028061: Samples - Highlighting of any object with "Hidden On" option leads to crash in mfc Modeling
    
    - handle to highlight style is nullified only in Release() method of OpenGl_Structure;
    - Graphic3d_CStructure and Graphic3d_Structure now return copy of highlight style regarding to structure's highlight state;
    - test case for issue 0028061
(0060123)
vpa   
2016-11-09 16:07   
Dear Kirill,

please review patch in branch CR28061.
(0060130)
git   
2016-11-09 16:51   
Branch CR28061 has been updated forcibly by vpa.

SHA-1: 4477fc96fe7ce8918dc9425b65d61b47d4056e04
(0060144)
git   
2016-11-09 17:56   
Branch CR28061 has been updated forcibly by vpa.

SHA-1: d5a3ba021a7b85610419aa9c94181b99f518b917
(0060147)
git   
2016-11-09 19:35   
Branch CR28061 has been updated forcibly by kgv.

SHA-1: 5626ebfe13d0bbe748f2673c3a3f72d2c0ae9d50
(0060148)
kgv   
2016-11-09 19:35   
Please test the patch.
(0060209)
mkv   
2016-11-10 17:58   
Dear BugMaster,
Branch CR28061 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 5626ebfe13d0bbe748f2673c3a3f72d2c0ae9d50

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1135

Regressions/Differences/Improvements:
http://occt-tests/CR28061-master-OCCT/Windows-64-VC10/gdt/presentation/A5.html [^]
gdt presentation A5: IMPROVEMENT

Testing cases:
http://occt-tests/CR28061-master-OCCT/Debian70-64/bugs/vis/bug28061.html [^]
http://occt-tests/CR28061-master-OCCT/Windows-64-VC10/bugs/vis/bug28061.html [^]
bugs vis bug28061: OK

Testing on Linux:
occt component :
Total MEMORY difference: 91235778 / 91873955 [-0.69%]
Total CPU difference: 21759.330000000202 / 21600.690000000308 [+0.73%]
products component :
Total MEMORY difference: 30024879 / 29935586 [+0.30%]
Total CPU difference: 5309.309999999983 / 5309.249999999963 [+0.00%]

Testing on Windows:
occt component :
Total MEMORY difference: 56588043 / 56597852 [-0.02%]
Total CPU difference: 20325.72909229838 / 19669.510885798518 [+3.34%]
products component :
Total MEMORY difference: 20822538 / 20790286 [+0.16%]
Total CPU difference: 5299.9155735999875 / 5153.477434899959 [+2.84%]

There are no differences in images found by testdiff.
(0060210)
mkv   
2016-11-10 17:59   
Dear vpa,
Branch CR28061 has been rejected due to:
- regressions/differences/improvements
(0060213)
vpa   
2016-11-10 19:07   
Dear Mikhail,

it is impossible that improvement in gdt/presentation/A5 is caused by this patch. Code changes in CR28061 are related to visualization component which is not used at all in gdt/presentation/A5.

Moreover, on my PC test case does show the error message just like on master.

Please, check gdt/presentation/A5 once again.
(0060238)
mkv   
2016-11-11 13:13   
Test case gdt/presentation/A5 was retested, now it is BAD (known problem).

Dear BugMaster,
Branch CR28061 is TESTED.
(0061271)
git   
2016-12-07 11:31   
Branch CR28061 has been deleted by kgv.

SHA-1: 5626ebfe13d0bbe748f2673c3a3f72d2c0ae9d50