MantisBT - Open CASCADE
View Issue Details
0028039Open CASCADE[OCCT] OCCT:Codingpublic2016-11-02 12:442016-12-09 16:39
kgv 
apn 
normaltrivial 
closedfixed 
[OCCT] 7.1.0 
[OCCT] 7.1.0[OCCT] 7.1.0 
Not needed
0028039: Coding rules, TObj - pass file name by reference
It is common practice to pass TCollection_AsciiString/TCollection_ExtendedString by reference, however the following methods pass string by copy:

- TObj_Application::SaveDocument()
- TObj_Application::LoadDocument()
- TObj_Model::SaveAs()
- TObj_Model::Load ()

which is inconsistent and sub-optimal.
N/A
No tags attached.
child of 0025534closed bugmaster Community TObj_Application unicode path issue. 
Issue History
2016-11-02 12:44kgvNew Issue
2016-11-02 12:44kgvAssigned To => kgv
2016-11-02 12:44kgvRelationship addedrelated to 0025534
2016-11-02 12:44kgvRelationship replacedchild of 0025534
2016-11-02 12:50gitNote Added: 0059768
2016-11-02 12:50kgvNote Added: 0059769
2016-11-02 12:50kgvAssigned Tokgv => bugmaster
2016-11-02 12:50kgvSeverityminor => trivial
2016-11-02 12:50kgvStatusnew => resolved
2016-11-02 12:51kgvStatusresolved => reviewed
2016-11-03 17:10apvAssigned Tobugmaster => apv
2016-11-03 18:56gitNote Added: 0059888
2016-11-03 18:56apvNote Added: 0059889
2016-11-07 12:50apvNote Added: 0059919
2016-11-07 12:50apvAssigned Toapv => bugmaster
2016-11-07 12:50apvStatusreviewed => tested
2016-11-07 12:51apvTest case number => Not needed
2016-11-09 17:43apnChangeset attached => occt master be70005c
2016-11-09 17:43apnAssigned Tobugmaster => apn
2016-11-09 17:43apnStatustested => verified
2016-11-09 17:43apnResolutionopen => fixed
2016-12-07 11:30gitNote Added: 0061263
2016-12-09 16:30aivStatusverified => closed
2016-12-09 16:39aivFixed in Version => 7.1.0

Notes
(0059768)
git   
2016-11-02 12:50   
Branch CR28039 has been created by kgv.

SHA-1: c34c49593b892f42315f5fe0d74ed2fd59d94b18


Detailed log of new commits:

Author: kgv
Date: Wed Nov 2 12:50:02 2016 +0300

    0028039: Coding rules, TObj - pass file name by reference
(0059769)
kgv   
2016-11-02 12:50   
Please check building, regression testing is not needed.
(0059888)
git   
2016-11-03 18:56   
Branch CR28039 has been updated forcibly by apv.

SHA-1: 9f9b54021e87eb16aad85b238809c67f419a7f4c
(0059889)
apv   
2016-11-03 18:56   
Branch CR28039 has been rebased on the current master
(0059919)
apv   
2016-11-07 12:50   
Dear BugMaster,

Branch CR28039 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms.
SHA-1: 9f9b54021e87eb16aad85b238809c67f419a7f4c

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 63
   Windows: 0
   MacOS: 1139
(0061263)
git   
2016-12-07 11:30   
Branch CR28039 has been deleted by kgv.

SHA-1: 9f9b54021e87eb16aad85b238809c67f419a7f4c