MantisBT - Open CASCADE
View Issue Details
0027991Open CASCADE[OCCT] OCCT:Modeling Algorithmspublic2016-10-22 18:232018-04-24 11:52
kgv 
apv 
normalminor 
closedfixed 
WindowsVC++ 201564 bit
[OCCT] 6.3.1 
[OCCT] 7.1.0[OCCT] 7.1.0 
bugs vis bug27821
0027991: Modeling Algorithms - BRepGProp_Face crashes on face without geometric surface
It is suggested that BRepGProp_Face will handle faces without geometric surface smoothly - at least without a crash.
pload MODELING VISUALIZATION
restore [locate_data_file bug27821_nullsurf.brep] s
sprops s


Result:
An exception was caught 0000000005835120 : OSD_Exception_ACCESS_VIOLATION: ACCESS VIOLATION at address 
0x0000000000000000 during 'READ' operation
** Exception ** 0000000005835120 : OSD_Exception_ACCESS_VIOLATION: ACCESS VIOLATION at address 0x0000000000000000 
during 'READ' operation
No tags attached.
related to 0027821closed bugmaster Visualization, AIS_Shape - add NULL checks for displaying TopoDS_Face with NULL surface 
related to 0027992closed apn Modeling Algorithms - Extrema_ExtPS crashes on face without geometric surface 
related to 0028125new msv Modeling Algorithms - support of BRep shapes based on tessellated geometry 
related to 0029524closed bugmaster Modeling Algorithms - access violation in HLRBRep_PolyAlgo while computing HLR for triangulation-only surface 
Issue History
2016-10-22 18:23kgvNew Issue
2016-10-22 18:23kgvAssigned To => msv
2016-10-22 18:23kgvRelationship addedrelated to 0027821
2016-10-22 18:27kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15037#r15037
2016-10-22 18:37kgvSummaryModeling Algorithms - BRepGProp_Face is crashing on face without geometric surface => Modeling Algorithms - BRepGProp_Face crashes on face without geometric surface
2016-10-22 18:38gitNote Added: 0058981
2016-10-22 18:41kgvProduct Version7.0.0 => 6.3.1
2016-10-22 18:43kgvNote Added: 0058982
2016-10-22 18:43kgvStatusnew => resolved
2016-10-22 18:43kgvNote Edited: 0058982bug_revision_view_page.php?bugnote_id=58982#r15039
2016-10-22 19:24gitNote Added: 0058983
2016-10-22 19:25kgvRelationship addedrelated to 0027992
2016-10-24 10:17msvNote Added: 0058991
2016-10-24 10:17msvAssigned Tomsv => kgv
2016-10-24 10:17msvStatusresolved => assigned
2016-10-24 10:17msvNote Added: 0058992
2016-10-24 16:11gitNote Added: 0059030
2016-10-24 16:12kgvNote Added: 0059031
2016-10-24 16:12kgvAssigned Tokgv => msv
2016-10-24 16:12kgvStatusassigned => resolved
2016-10-24 18:24gitNote Added: 0059040
2016-10-24 18:25msvNote Added: 0059041
2016-10-24 18:25msvNote Added: 0059042
2016-10-24 18:25msvAssigned Tomsv => bugmaster
2016-10-24 18:25msvStatusresolved => reviewed
2016-10-24 18:56apvAssigned Tobugmaster => apv
2016-10-26 13:37apvTest case number => bugs vis bug27821
2016-10-26 14:11apvNote Added: 0059165
2016-10-26 14:11apvAssigned Toapv => kgv
2016-10-26 14:11apvStatusreviewed => assigned
2016-10-26 14:11apvNote Edited: 0059165bug_revision_view_page.php?bugnote_id=59165#r15065
2016-10-26 14:13apvNote Added: 0059166
2016-10-26 22:03gitNote Added: 0059217
2016-10-26 22:07gitNote Added: 0059218
2016-10-26 22:07kgvNote Added: 0059219
2016-10-26 22:07kgvAssigned Tokgv => bugmaster
2016-10-26 22:07kgvStatusassigned => resolved
2016-10-26 22:08kgvStatusresolved => reviewed
2016-10-27 09:55apvAssigned Tobugmaster => apv
2016-10-28 17:27gitNote Added: 0059367
2016-10-28 17:27apvNote Added: 0059368
2016-10-31 15:32apvNote Added: 0059638
2016-10-31 15:32apvAssigned Toapv => bugmaster
2016-10-31 15:32apvStatusreviewed => tested
2016-10-31 15:33apvNote Edited: 0059638bug_revision_view_page.php?bugnote_id=59638#r15137
2016-11-03 17:10apvChangeset attached => occt master 4d19a2c5
2016-11-03 17:10apvAssigned Tobugmaster => apv
2016-11-03 17:10apvStatustested => verified
2016-11-03 17:10apvResolutionopen => fixed
2016-11-17 17:22abvRelationship addedrelated to 0028125
2016-12-07 11:25gitNote Added: 0061216
2016-12-07 11:25gitNote Added: 0061217
2016-12-09 16:30aivStatusverified => closed
2016-12-09 16:39aivFixed in Version => 7.1.0
2018-04-24 11:52kgvRelationship addedrelated to 0029524

Notes
(0058981)
git   
2016-10-22 18:38   
Branch CR27991 has been created by kgv.

SHA-1: 6630a31f52ff8ce21ad3be148b86515769d4a255


Detailed log of new commits:

Author: kgv
Date: Sat Oct 22 18:37:51 2016 +0300

    0027991: Modeling Algorithms - BRepGProp_Face crashes on face without geometric surface
(0058982)
kgv   
2016-10-22 18:43   
The workaround fixing the crash has been pushed to the branch.
Note that the shape contains triangulation - thus some surface properties like area can be actually computed from it.

(0058983)
git   
2016-10-22 19:24   
Branch CR27991 has been updated forcibly by kgv.

SHA-1: 738f2ecf6316d7947d039d78351b76d3d578edaa
(0058991)
msv   
2016-10-24 10:17   
No remarks to implementation. But please describe in commit message what you have done, because you fixed two other places not connected directly with gprops calculation.
(0058992)
msv   
2016-10-24 10:17   
Also, create a test case.
(0059030)
git   
2016-10-24 16:11   
Branch CR27991 has been updated forcibly by kgv.

SHA-1: 6cfe5e6412f18fa4d2ac6c2b326f526a8007f044
(0059031)
kgv   
2016-10-24 16:12   
Commit message has been updated.
Test case bugs/vis/bug27821 has been extended to check this issue as well.
(0059040)
git   
2016-10-24 18:24   
Branch CR27991 has been updated forcibly by msv.

SHA-1: 9d9e9239aa2ec6d858bbca4d415102ac9c0412ad
(0059041)
msv   
2016-10-24 18:25   
Commit message has been updated.
(0059042)
msv   
2016-10-24 18:25   
Reviewed.
(0059165)
apv   
2016-10-26 14:11   
Dear BugMaster,

Branch CR27991 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 9d9e9239aa2ec6d858bbca4d415102ac9c0412ad

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 63
   Windows: 0
   MacOS: 1167

Regressions/Differences:
http://occt-tests/CR27991-master-OCCT/Debian70-64/summary.html [^]
http://occt-tests/CR27991-master-OCCT/Windows-64-VC10/summary.html [^]
prj base C5, C6

Testing cases:
bugs vis bug27821 - OK
http://occt-tests/CR27991-master-OCCT/Debian70-64/bugs/vis/bug27821.html [^]
http://occt-tests/CR27991-master-OCCT/Windows-64-VC10/bugs/vis/bug27821.html [^]

Testing on Linux:
Total MEMORY difference: 89935820 / 90328255 [-0.43%]
Total CPU difference: 19489.399999999965 / 19231.589999999847 [+1.34%]

Testing on Windows:
Total MEMORY difference: 57288337 / 57220230 [+0.12%]
Total CPU difference: 17906.434384098717 / 18211.026336598778 [-1.67%]

There is difference in images found by testdiff:
http://occt-tests/CR27991-master-OCCT/Debian70-64/diff-Debian70-64.html [^]
http://occt-tests/CR27991-master-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html [^]
bugs modalg_2 bug472_3

(0059166)
apv   
2016-10-26 14:13   
Dear Kirill,

Branch CR27991 has been rejected due to:
- regressions/differences/improvements
- differences in images
(0059217)
git   
2016-10-26 22:03   
Branch CR27991 has been updated by kgv.

SHA-1: 3e80a0b142be8ce119685d9df71f437b9d71ba40


Detailed log of new commits:

Author: kgv
Date: Wed Oct 26 22:03:42 2016 +0300

    fix regression

(0059218)
git   
2016-10-26 22:07   
Branch CR27991_1 has been created by kgv.

SHA-1: 85103e140443d6adbe3e1d7ace47ad0f7d74fe30


Detailed log of new commits:

Author: kgv
Date: Sat Oct 22 18:37:51 2016 +0300

    0027991: Modeling Algorithms - BRepGProp_Face crashes on face without geometric surface
    
    BRepGProps now ignores faces without geometric surface to avoid access violation.
    BRepExtrema_DistShapeShape::DistanceMapMap() now skips comparison between void bounding boxes.
    BRepBndLib::Add() now ignores useTriangulation flag for faces without geometric surfaces, and uses triangulation if any for updating of the box.
(0059219)
kgv   
2016-10-26 22:07   
Please check updated patch.
(0059367)
git   
2016-10-28 17:27   
Branch CR27991_1 has been updated forcibly by apv.

SHA-1: 4d19a2c5e73415f81c1e3cae34bdd0fe1ddd0b66
(0059368)
apv   
2016-10-28 17:27   
Branch CR27991_1 has been rebased on the current master
(0059638)
apv   
2016-10-31 15:32   
(edited on: 2016-10-31 15:33)
Dear BugMaster,

Branch CR27991_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 4d19a2c5e73415f81c1e3cae34bdd0fe1ddd0b66

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 63
   Windows: 0
   MacOS: 1149

Regressions/Differences:
Not detected

Testing cases:
bugs vis bug27821 - OK
http://occt-tests/CR27991_1-master-OCCT/Debian70-64/bugs/vis/bug27821.html [^]
http://occt-tests/CR27991_1-master-OCCT/Windows-64-VC10/bugs/vis/bug27821.html [^]

Testing on Linux:
Total MEMORY difference: 91250103 / 90744466 [+0.56%]
Total CPU difference: 19325.789999999834 / 19313.189999999897 [+0.07%]

Testing on Windows:
Total MEMORY difference: 57304054 / 57321116 [-0.03%]
Total CPU difference: 17981.970068298648 / 18220.18359529866 [-1.31%]

(0061216)
git   
2016-12-07 11:25   
Branch CR27991 has been deleted by kgv.

SHA-1: 3e80a0b142be8ce119685d9df71f437b9d71ba40
(0061217)
git   
2016-12-07 11:25   
Branch CR27991_1 has been deleted by kgv.

SHA-1: 4d19a2c5e73415f81c1e3cae34bdd0fe1ddd0b66