MantisBT - Open CASCADE
View Issue Details
0027988Open CASCADE[OCCT] OCCT:Visualizationpublic2016-10-21 12:392016-12-09 16:38
kgv 
apn 
normalminor 
closedfixed 
[OCCT] 7.1.0 
[OCCT] 7.1.0[OCCT] 7.1.0 
Not needed
0027988: Visualization, AIS_InteractiveContext - fix inconsistent methods for setting highlight styles
Patch for 0027818 has introduced the following new methods:
+  Handle(Graphic3d_HighlightStyle)& ChangeHighlightStyle()
+  {
+    return myHiStyle;
+  }
+
+  Handle(Graphic3d_HighlightStyle)& ChangeSelectionStyle()
+  {
+    return mySelStyle;
+  }


The "Change" syntax makes sense only in context of primitive types, where it can be used in expressions like "ChangeValue() += 33.0", but not with Handle types.
It is better changing these methods to "Set" syntax for easier lookup of class properties.
N/A
No tags attached.
child of 0027818closed kgv Visualization - provide an interface to define highlight presentation properties 
Issue History
2016-10-21 12:39kgvNew Issue
2016-10-21 12:39kgvAssigned To => kgv
2016-10-21 12:40kgvRelationship addedchild of 0027818
2016-10-21 12:51gitNote Added: 0058954
2016-10-21 12:51kgvNote Added: 0058955
2016-10-21 12:51kgvAssigned Tokgv => san
2016-10-21 12:51kgvStatusnew => resolved
2016-10-21 12:52kgvDescription Updatedbug_revision_view_page.php?rev_id=15035#r15035
2016-10-23 16:10sanNote Added: 0058985
2016-10-23 16:10sanAssigned Tosan => bugmaster
2016-10-23 16:10sanStatusresolved => reviewed
2016-10-24 14:43mkvAssigned Tobugmaster => mkv
2016-10-24 14:45kgvNote Added: 0059025
2016-10-25 12:08mkvNote Added: 0059066
2016-10-25 12:08mkvNote Added: 0059067
2016-10-25 12:08mkvAssigned Tomkv => bugmaster
2016-10-25 12:08mkvStatusreviewed => tested
2016-10-25 12:08mkvTest case number => Not needed
2016-10-28 14:35apnChangeset attached => occt master d94bed0e
2016-10-28 14:35apnAssigned Tobugmaster => apn
2016-10-28 14:35apnStatustested => verified
2016-10-28 14:35apnResolutionopen => fixed
2016-10-28 21:37gitNote Added: 0059422
2016-12-09 16:30aivStatusverified => closed
2016-12-09 16:38aivFixed in Version => 7.1.0

Notes
(0058954)
git   
2016-10-21 12:51   
Branch CR27988 has been created by kgv.

SHA-1: 507307afb53e3e9d93e72c02eacfb3e543f39f22


Detailed log of new commits:

Author: kgv
Date: Fri Oct 21 12:51:26 2016 +0300

    0027988: Visualization, AIS_InteractiveContext - fix inconsistent methods for setting highlight styles
    
    Methods ::ChangeHighlightStyle() and ::ChangeSelectionStyle() have been
    replaced by ::SetHighlightStyle() and ::SetSelectionStyle().
(0058955)
kgv   
2016-10-21 12:51   
Patch is ready for review.
(0058985)
san   
2016-10-23 16:10   
Branch CR27988 reviewed without remarks, ready for testing.
(0059025)
kgv   
2016-10-24 14:45   
Please check building, regression testing is not needed.
(0059066)
mkv   
2016-10-25 12:08   
Dear BugMaster,
Branch CR27988 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 507307afb53e3e9d93e72c02eacfb3e543f39f22

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1148
(0059067)
mkv   
2016-10-25 12:08   
Dear BugMaster,
Branch CR27988 is TESTED.
(0059422)
git   
2016-10-28 21:37   
Branch CR27988 has been deleted by kgv.

SHA-1: 507307afb53e3e9d93e72c02eacfb3e543f39f22