MantisBT - Open CASCADE
View Issue Details
0027929Open CASCADE[OCCT] OCCT:Modeling Algorithmspublic2016-10-04 13:452016-12-09 16:38
nbv 
apn 
normalminor 
closedfixed 
[OCCT] 7.0.0 
[OCCT] 7.1.0[OCCT] 7.1.0 
bugs modalg_6 bug27929
0027929: Methods D0 and D1 for trimmed offset surface return different values if the surface has osculating surface
Attached face is based on the trimmed Offset surface. At that the Offset surface is based on the trimmed B-spline surface.

After the fix for issue 0027892, the surface, which the given face is based on has obtained osculating surface (on the MASTER, osculating surface is NULL). As result, the behavior of methods D0 and D1 is different.

P.S.

Methods D0 and D1 are called in the point where the normal to the basis (to offset) surface is well defined. Therefore, osculating surface must not play any role in this case. But it is not indeed...
Draw[]> restore f1.brep
Draw[]> mksurf os1 f1
Draw[]> svalue os1 0.5 0.5 x1 y1 z1
Draw[]> svalue os1 0.5 0.5 x2 y2 z2 dux duy duz dvx dvy dvz
Draw[]> vertex v1 x1 y1 z1
Draw[]> vertex v2 x2 y2 z2
Draw[]> distmini dd v1 v2
Draw[]> dump dd_val
# 0.694623157424446
Work of D0 method seems to be more correct than D1. And result of D0 method matches with the current MASTER.
No tags attached.
child of 0027892closed apn Construction error in offset 
? f1.brep (4,287) 2016-10-04 13:45
https://tracker.dev.opencascade.org/
Issue History
2016-10-04 13:45nbvNew Issue
2016-10-04 13:45nbvAssigned To => msv
2016-10-04 13:45nbvFile Added: f1.brep
2016-10-04 13:47nbvNote Added: 0058390
2016-10-04 13:48nbvAdditional Information Updatedbug_revision_view_page.php?rev_id=14869#r14869
2016-10-04 13:51nbvRelationship addedchild of 0027892
2016-10-04 15:34msvAssigned Tomsv => nbv
2016-10-04 15:34msvStatusnew => assigned
2016-10-04 15:34msvProduct Version => 7.0.0
2016-10-05 16:09gitNote Added: 0058436
2016-10-05 16:11nbvNote Added: 0058437
2016-10-05 16:11nbvAssigned Tonbv => msv
2016-10-05 16:11nbvStatusassigned => resolved
2016-10-05 16:52gitNote Added: 0058439
2016-10-05 16:53nbvNote Added: 0058440
2016-10-05 17:15gitNote Added: 0058441
2016-10-05 17:17msvNote Added: 0058442
2016-10-05 17:17msvAssigned Tomsv => bugmaster
2016-10-05 17:17msvStatusresolved => reviewed
2016-10-05 17:24apvAssigned Tobugmaster => apv
2016-10-06 11:37apvTest case number => bugs modalg_6 bug27929
2016-10-06 11:38apvNote Added: 0058448
2016-10-06 11:38apvAssigned Toapv => bugmaster
2016-10-06 11:38apvStatusreviewed => tested
2016-10-07 16:09apnChangeset attached => occt master 95ae6ebb
2016-10-07 16:09apnAssigned Tobugmaster => apn
2016-10-07 16:09apnStatustested => verified
2016-10-07 16:09apnResolutionopen => fixed
2016-10-28 21:42gitNote Added: 0059463
2016-12-09 16:30aivStatusverified => closed
2016-12-09 16:38aivFixed in Version => 7.1.0

Notes
(0058390)
nbv   
2016-10-04 13:47   
This bug is not reproduced on the current MASTER because the given offset surface does not have any osculating surface. Please use the fix for issue 0027892 in order to reproduce.
(0058436)
git   
2016-10-05 16:09   
Branch CR27929 has been created by nbv.

SHA-1: d4fe6566b298d400d84434660bf946ae28444418


Detailed log of new commits:

Author: nbv
Date: Wed Oct 5 14:36:33 2016 +0300

    0027929: Methods D0 and D1 for trimmed offset surface return different values if the surface has osculating surface
    
    Using osculating surface is forbidden if the normal to basis (for offset) surface is well defined.
    
    Creation of test case for this issue.
    Adjusting test cases according to their new behavior.
(0058437)
nbv   
2016-10-05 16:11   
Dear Mikhail,

Please review CR27929 branch. The regression in "bugs modalg_4 bug8842_8" has been fixed.
(0058439)
git   
2016-10-05 16:52   
Branch CR27929 has been updated forcibly by nbv.

SHA-1: 978d33e37695e42765ad1fea85659eafb6e2e6f0
(0058440)
nbv   
2016-10-05 16:53   
Small correction in the code.
(0058441)
git   
2016-10-05 17:15   
Branch CR27929 has been updated forcibly by nbv.

SHA-1: 0fc153ddd7a94d42034b46fe395fb55e5103ad98
(0058442)
msv   
2016-10-05 17:17   
Reviewed.
(0058448)
apv   
2016-10-06 11:38   
Dear BugMaster,

Branch CR27929 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 0fc153ddd7a94d42034b46fe395fb55e5103ad98

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1134

Regressions/Differences:
Not detected

Testing cases:
bugs modalg_6 bug27929 - OK
http://occt-tests/CR27929-master-OCCT/Debian70-64/bugs/modalg_6/bug27929.html [^]
http://occt-tests/CR27929-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug27929.html [^]

Testing on Linux:
Total MEMORY difference: 90563706 / 90542307 [+0.02%]
Total CPU difference: 19367.579999999944 / 19276.80999999978 [+0.47%]

Testing on Windows:
Total MEMORY difference: 57216784 / 57236340 [-0.03%]
Total CPU difference: 17928.30572429874 / 18116.099728098634 [-1.04%]
(0059463)
git   
2016-10-28 21:42   
Branch CR27929 has been deleted by kgv.

SHA-1: 0fc153ddd7a94d42034b46fe395fb55e5103ad98