MantisBT - Open CASCADE
View Issue Details
0027732Open CASCADE[OCCT] OCCT:Visualizationpublic2016-08-01 15:422018-06-29 21:19
oan 
bugmaster 
normalminor 
closedfixed 
[OCCT] 7.0.0 
[OCCT] 7.3.0[OCCT] 7.3.0 
Not needed
0027732: Visualization - AIS_ConnectedInteractive crashes on NULL handle returned by MeshVS_CommonSensitiveEntity::GetConnected()
MeshVS_CommonSensitiveEntity::GetConnected() returns null handle leading to crash in case of AIS_MultipleConnectedInteractive
pload VISUALIZATION XDE
vclear
vinit View1
meshfromstl m [locate_data_file bug26680.stl]
meshcolors m elem2 1
vselmode m 0 1
vconnect cm 50 0 0 m

Result:
** Exception ** 0000025F253A3F90 : OSD_Exception_ACCESS_VIOLATION: ACCESS VIOLATION at address 0x0000000000000000 
during 'READ' operation


Original test case:
Handle(AIS_MultipleConnectedInteractive) aPrs = new AIS_MultipleConnectedInteractive;

aPrs->Connect((MeshVS_Mesh)(...));
aPrs->Connect((MeshVS_Mesh)(...));

//Display
No tags attached.
Issue History
2016-08-01 15:42oanNew Issue
2016-08-01 15:42oanAssigned To => kgv
2016-10-25 09:32kgvTarget Version7.1.0 => 7.2.0
2017-07-20 10:49kgvTarget Version7.2.0 => 7.3.0
2018-03-13 16:07kgvProduct Version => 7.0.0
2018-03-13 16:07kgvSummaryMeshVS_CommonSensitiveEntity::GetConnected() returns null handle leading to crash in case of AIS_MultipleConnectedInteractive => Visualization - AIS_ConnectedInteractive crashes on NULL handle returned by MeshVS_CommonSensitiveEntity::GetConnected()
2018-03-13 16:07kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18722#r18722
2018-03-13 17:55gitNote Added: 0074448
2018-03-13 20:49kgvNote Added: 0074453
2018-03-13 20:49kgvAssigned Tokgv => san
2018-03-13 20:49kgvStatusnew => resolved
2018-03-13 23:17abvNote Added: 0074454
2018-03-14 11:07gitNote Added: 0074461
2018-03-21 20:15sanNote Added: 0074751
2018-03-21 20:15sanAssigned Tosan => bugmaster
2018-03-21 20:15sanStatusresolved => reviewed
2018-03-22 14:05bugmasterTest case number => Not needed
2018-03-22 14:08bugmasterNote Added: 0074760
2018-03-22 14:08bugmasterStatusreviewed => tested
2018-03-24 11:51bugmasterChangeset attached => occt master 834f2897
2018-03-24 11:51bugmasterStatustested => verified
2018-03-24 11:51bugmasterResolutionopen => fixed
2018-03-24 20:01gitNote Added: 0074864
2018-06-29 21:14aivFixed in Version => 7.3.0
2018-06-29 21:19aivStatusverified => closed

Notes
(0074448)
git   
2018-03-13 17:55   
Branch CR27732 has been created by kgv.

SHA-1: e09390d14538551acd4c645ea8c836e1a04f5d70


Detailed log of new commits:

Author: kgv
Date: Tue Mar 13 17:54:11 2018 +0300

    0027732: Visualization - AIS_ConnectedInteractive crashes on NULL handle returned by MeshVS_CommonSensitiveEntity::GetConnected()
    
    AIS_ConnectedInteractive::ComputeSelection() - added NULL-check.
(0074453)
kgv   
2018-03-13 20:49   
Patch is ready for review.
Note that patch only solves NULL-dereference - it does not make MeshVS_Mesh useful with AIS_MultipleConnectedInteractive due to numerous of other issues like dynamic highlighting overridden by MeshVS_Mesh.

http://jenkins-test-10.nnov.opencascade.com/view/CR27732-master-KGV/ [^]
(0074454)
abv   
2018-03-13 23:17   
Kirill, please describe all the changes included in the commit in its message, not only changes in one file
(0074461)
git   
2018-03-14 11:07   
Branch CR27732 has been updated forcibly by kgv.

SHA-1: bd2412acb57924eefd1eee28b185c3943ed60b53
(0074751)
san   
2018-03-21 20:15   
Branch CR27732 reviewed without remarks, ready for testing.
(0074760)
bugmaster   
2018-03-22 14:08   
Combination -
OCCT branch : CR27732 SHA - e09390d14538551acd4c645ea8c836e1a04f5d70
Products branch : master SHA - 4fd289ec73d35d02f23f3990c73b3acac9a60574
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18374.429999999764 / 18338.37999999957 [+0.20%]
Products
Total CPU difference: 7443.820000000006 / 7461.340000000009 [-0.23%]
Windows-64-VC10:
OCCT
Total CPU difference: 17602.0764330986 / 17653.338361698563 [-0.29%]
Products
Total CPU difference: 7975.207922799987 / 7990.761222500007 [-0.19%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0074864)
git   
2018-03-24 20:01   
Branch CR27732 has been deleted by kgv.

SHA-1: bd2412acb57924eefd1eee28b185c3943ed60b53