MantisBT - Open CASCADE
View Issue Details
0027731Open CASCADE[OCCT] OCCT:Visualizationpublic2016-08-01 15:412016-12-09 16:38
kgv 
bugmaster 
normalminor 
closedfixed 
[OCCT] 6.7.0 
[OCCT] 7.1.0[OCCT] 7.1.0 
bugs vis bug23654_MarkersRecompute
0027731: Visualization, OpenGl_AspectMarker - handle fractional marker Scale when sharing resources
Current code of OpenGl_AspectMarker::Resources::SpriteKeys() rounds the marker scale to the nearest integer number. However, some markers support fractional ratios (with step 0.5) leading to non-equal resources collision.

This is reflected by continuous regressions of test case bugs/vis/bug23654_MarkersRecompute - the second image is unstable. It is because on second display (Graphic3d_CView::Activate() after creating a new view) the order of displayed markers is undefined (Graphic3d_StructureManager::myDisplayedStructure is NCollection_Map<Handle(Graphic3d_Structure)>) and thus, collided marker resources are initialized in arbitrary order.
bugs/vis/bug23654_MarkersRecompute
No tags attached.
related to 0026791assigned kgv Visualization, TKOpenGl - apply view resolution to built-in markers 
png markers_KO.png (33,420) 2016-08-01 15:50
https://tracker.dev.opencascade.org/
png markers_OK.png (35,805) 2016-08-01 15:51
https://tracker.dev.opencascade.org/
Issue History
2016-08-01 15:41kgvNew Issue
2016-08-01 15:41kgvAssigned To => kgv
2016-08-01 15:41kgvProduct Version7.0.0 => 6.7.0
2016-08-01 15:50kgvFile Added: markers_KO.png
2016-08-01 15:51kgvFile Added: markers_OK.png
2016-08-01 16:58kgvNote Added: 0056341
2016-08-01 17:00kgvDescription Updatedbug_revision_view_page.php?rev_id=14288#r14288
2016-08-01 17:14gitNote Added: 0056342
2016-08-01 17:15kgvNote Added: 0056343
2016-08-01 17:15kgvAssigned Tokgv => san
2016-08-01 17:15kgvStatusnew => resolved
2016-08-01 18:19sanNote Added: 0056350
2016-08-01 18:19sanAssigned Tosan => bugmaster
2016-08-01 18:19sanStatusresolved => reviewed
2016-08-02 11:19apvAssigned Tobugmaster => apv
2016-08-03 09:17apvTest case number => bugs vis bug23654_MarkersRecompute
2016-08-03 10:05apvNote Added: 0056407
2016-08-03 10:05apvAssigned Toapv => bugmaster
2016-08-03 10:05apvStatusreviewed => tested
2016-08-05 13:30bugmasterChangeset attached => occt master d509e5a4
2016-08-05 13:30bugmasterStatustested => verified
2016-08-05 13:30bugmasterResolutionopen => fixed
2016-08-06 13:04kgvRelationship addedrelated to 0026791
2016-08-26 16:25gitNote Added: 0057178
2016-12-09 16:30aivStatusverified => closed
2016-12-09 16:38aivFixed in Version => 7.1.0

Notes
(0056341)
kgv   
2016-08-01 16:58   
Note that bugs/vis/bug23654_MarkersRecompute reveals also another problem - since order of re-displayed objects is undefined, the label/marker overlaps in undefined order (a couple of pixels blinking).
(0056342)
git   
2016-08-01 17:14   
Branch CR27731 has been created by kgv.

SHA-1: a9f089dab263d709bacfefd1f83687d1d6252291


Detailed log of new commits:

Author: kgv
Date: Mon Aug 1 17:15:52 2016 +0300

    0027731: Visualization, OpenGl_AspectMarker - handle fractional marker Scale when sharing resources
    
    OpenGl_AspectMarker::Resources::SpriteKeys() now encodes decimal number of marker scale into resource key,
    since built-in markers are defined with 0.5 scale step.
(0056343)
kgv   
2016-08-01 17:15   
Patch is ready for review.
(0056350)
san   
2016-08-01 18:19   
Branch CR27731 reviewed without remarks, ready for testing.
(0056407)
apv   
2016-08-03 10:05   
Dear BugMaster,

Branch CR27731 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: a9f089dab263d709bacfefd1f83687d1d6252291

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1132

Regressions/Differences:
Not detected

Testing cases:
bugs vis bug23654_MarkersRecompute - OK
http://occt-tests/CR27731-master-OCCT/Debian70-64/bugs/vis/bug23654_MarkersRecompute.html [^]
http://occt-tests/CR27731-master-OCCT/Windows-64-VC10/bugs/vis/bug23654_MarkersRecompute.html [^]

Testing on Linux:
Total MEMORY difference: 90124282 / 90097678 [+0.03%]
Total CPU difference: 19320.88999999996 / 19470.040000000092 [-0.77%]

Testing on Windows:
Total MEMORY difference: 57084324 / 57093912 [-0.02%]
Total CPU difference: 18219.933993698705 / 18078.831089198848 [+0.78%]
(0057178)
git   
2016-08-26 16:25   
Branch CR27731 has been deleted by inv.

SHA-1: a9f089dab263d709bacfefd1f83687d1d6252291