MantisBT - Open CASCADE
View Issue Details
0027691Open CASCADE[OCCT] OCCT:Testspublic2016-07-19 15:292017-09-29 16:29
apn 
apn 
normalminor 
closedfixed 
ALL
 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not needed
0027691: Remove dchrono from all test cases and move its to perf group
Remove using dchrono in test cases
Move cases in appropriate perf test subgroups
Compare performance of these cases using testdiff -cpu -memory with reference data.
testgrid perf -outdir D:/results1
testgrid perf -outdir D:/results2
testdiff D:/results1 D:/results2 -cpu
No tags attached.
parent of 0029004closed bugmaster DRAW - update help of chrono and dchrono commands 
Issue History
2016-07-19 15:29apnNew Issue
2016-07-19 15:29apnAssigned To => apn
2016-07-19 15:36apnStatusnew => assigned
2016-07-19 15:36apnDescription Updatedbug_revision_view_page.php?rev_id=14219#r14219
2016-07-20 12:14apnDescription Updatedbug_revision_view_page.php?rev_id=14224#r14224
2016-07-20 12:22abvNote Added: 0056048
2016-07-28 18:12gitNote Added: 0056271
2016-07-28 18:12gitNote Added: 0056272
2016-07-28 18:22gitNote Added: 0056273
2016-08-02 11:58gitNote Added: 0056367
2016-08-03 18:42gitNote Added: 0056446
2016-08-03 18:48apnNote Added: 0056447
2016-08-03 18:49apnNote Edited: 0056447bug_revision_view_page.php?bugnote_id=56447#r14324
2016-08-03 18:49apnTest case number => Not needed
2016-08-03 18:49apnAssigned Toapn => abv
2016-08-03 18:49apnStatusassigned => resolved
2016-08-03 18:50apnSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14326#r14326
2016-09-23 15:29gitNote Added: 0058077
2016-11-22 10:47kgvTarget Version7.1.0 => 7.2.0
2017-01-12 11:19gitNote Added: 0062519
2017-01-12 12:40gitNote Added: 0062525
2017-01-12 13:22skiNote Added: 0062527
2017-01-12 17:54gitNote Added: 0062546
2017-01-16 07:11gitNote Added: 0062603
2017-01-16 21:00gitNote Added: 0062662
2017-01-17 08:30abvNote Added: 0062670
2017-01-17 08:30abvAssigned Toabv => bugmaster
2017-01-17 08:30abvStatusresolved => reviewed
2017-01-17 16:49apvAssigned Tobugmaster => apv
2017-01-18 15:54apvNote Added: 0062760
2017-01-18 15:54apvAssigned Toapv => bugmaster
2017-01-18 15:54apvStatusreviewed => tested
2017-01-20 16:12apnChangeset attached => occt master 44fae8b1
2017-01-20 16:12apnAssigned Tobugmaster => apn
2017-01-20 16:12apnStatustested => verified
2017-01-20 16:12apnResolutionopen => fixed
2017-02-08 11:35gitNote Added: 0063588
2017-02-08 11:40gitNote Added: 0063640
2017-02-08 11:40gitNote Added: 0063641
2017-07-31 17:31msvNote Added: 0068921
2017-07-31 17:32msvNote Added: 0068922
2017-07-31 17:32msvStatusverified => assigned
2017-08-16 15:46abvRelationship addedparent of 0029004
2017-08-16 15:46abvNote Added: 0069463
2017-08-16 15:46abvStatusassigned => feedback
2017-08-16 15:47abvStatusfeedback => tested
2017-08-16 15:47abvStatustested => verified
2017-09-29 16:17aivFixed in Version => 7.2.0
2017-09-29 16:29aivStatusverified => closed

Notes
(0056048)
abv   
2016-07-20 12:22   
Andrey, please do not focus on removing 'dchrono' -- this command is not a problem, the problem is comparing its result with hard-coded values as a check for test success.

A possible improvement of the test system can be to be able to measure particular parameter of the test (e.g. CPU of some command, measured by dchrono or otherwise) and make it recognizable for testdiff command, so that it can compare not only general CPU / MEMORY data of all tests, but also test-specific measures. We have discussed this need with Vladimir Turin when new test system was developed, but never implemented that. It can be a time now to do that.
(0056271)
git   
2016-07-28 18:12   
Branch CR27691 has been created by apn.

SHA-1: 131ec6cd2f31f1772a3bf19d172a0ef862c5cb37


Detailed log of new commits:

Author: apn
Date: Thu Jul 28 18:12:42 2016 +0300

    0027691: Remove dchrono from all test cases and move its to perf group
    
    Remove performance comparing with hardcoded value.
    Test cases for performance of some commands were moved to perf group.
(0056272)
git   
2016-07-28 18:12   
Branch CR27691 has been updated forcibly by apn.

SHA-1: f2edc5b5b34db65d3000ed40dcf2fcb633d959d1
(0056273)
git   
2016-07-28 18:22   
Branch CR27691 has been updated by apn.

SHA-1: 41fa40c777cb2e050760390f75a010f762e74434


Detailed log of new commits:

Author: apn
Date: Thu Jul 28 18:23:46 2016 +0300

    Modified grids.list in perf test group

(0056367)
git   
2016-08-02 11:58   
Branch CR27691 has been updated forcibly by apn.

SHA-1: e90b814b7f11c3dc1afdde93d7033ffe12635d53
(0056446)
git   
2016-08-03 18:42   
Branch CR27691 has been updated by apn.

SHA-1: f35ac300e788db63f4aaa2e2bee0510806deeb4d


Detailed log of new commits:

Author: apn
Date: Wed Aug 3 18:43:47 2016 +0300

    Small corrections

(0056447)
apn   
2016-08-03 18:48   
(edited on: 2016-08-03 18:49)
All cases with dchrono command were moved to appropriate perf subgroups.
If some command in test cases are measured by dchrono, testdiff parses output and compares CPU user time of command with the same value in reference branch.
Result is saved in general log\html file if testdiff has no arguments or in diffcpu log\html.

Dear abv, please review CR27691.

(0058077)
git   
2016-09-23 15:29   
Branch CR27691_1 has been created by ski.

SHA-1: efc8b0320955cd593574faf44e0398d657981af0


Detailed log of new commits:

Author: apn
Date: Thu Jul 28 18:12:42 2016 +0300

    0027691: Remove dchrono from all test cases and move its to perf group
    
    Remove performance comparing with hardcoded value.
    Test cases for performance of some commands were moved to perf group.
    Procedure testdiffCPU was created.
(0062519)
git   
2017-01-12 11:19   
Branch CR27691_2 has been created by ski.

SHA-1: ead5583fc4d2fd29f0ba705503b17605341cad96


Detailed log of new commits:

Author: ski
Date: Tue Jan 10 20:00:19 2017 +0300

    0027691: Remove dchrono from all test cases and move its to perf group
    
    Remove performance comparing with hardcoded value.
    Test cases for performance of some commands were moved to perf group.
(0062525)
git   
2017-01-12 12:40   
Branch CR27691_2 has been updated forcibly by ski.

SHA-1: ee2b430e80eee798c402c98b560b8612acaf404b
(0062527)
ski   
2017-01-12 13:22   
Dear abv,

occt branch CR27691_2 contains next changes:

1) Commands dchrono/chrono can be used with next syntax
> dchrono s stop show
it will stop the timer and show info about elapsed time

2) New option "restart" was added to commands dchrono/chrono
> dchrono s restart
it is the same as
> dchrono s stop reset start
> dchrono s reset start

3) New option "counter text" was added to commands dchrono/chrono
> dchrono s counter text
with such option command dchrono will print "COUNTER text: N", where N is elapsed user CPU time.
Testdiff command will compare value of each counters between several tests results.

All test performance cases were moved to perf group.

Please, review.
(0062546)
git   
2017-01-12 17:54   
Branch CR27691_2 has been updated by ski.

SHA-1: 5efb4193b1f67b201e3ad8b059e52b96ee1049b7


Detailed log of new commits:

Author: ski
Date: Thu Jan 12 17:53:49 2017 +0300

    Updated documentation.

(0062603)
git   
2017-01-16 07:11   
Branch CR27691_2 has been updated by abv.

SHA-1: 9384467df2ed27cd1fc8a78747ea024567cfdaef


Detailed log of new commits:

Author: abv
Date: Mon Jan 16 07:11:35 2017 +0300

    // minor corrections

(0062662)
git   
2017-01-16 21:00   
Branch CR27691_2 has been updated by abv.

SHA-1: 9bb02de5b6c9a2021c9fcd19dae24db15559867e


Detailed log of new commits:

Author: abv
Date: Mon Jan 16 21:00:33 2017 +0300

    // more details on counters added in tests.md

(0062670)
abv   
2017-01-17 08:30   
Reviewed with some corrections, please test
(0062760)
apv   
2017-01-18 15:54   
Dear BugMaster,

Branch CR27691_2 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 9bb02de5b6c9a2021c9fcd19dae24db15559867e

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 63
   Windows: 0
   MacOS: 1153

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 89341028 / 89062940 [+0.31%]
Total CPU difference: 18600.519999999742 / 18962.369999999915 [-1.91%]

Testing on Windows:
Total MEMORY difference: 53703897 / 53715833 [-0.02%]
Total CPU difference: 17020.847907298783 / 17414.500830698835 [-2.26%]
(0063588)
git   
2017-02-08 11:35   
Branch CR27691_2 has been deleted by kgv.

SHA-1: 9bb02de5b6c9a2021c9fcd19dae24db15559867e
(0063640)
git   
2017-02-08 11:40   
Branch CR27691 has been deleted by kgv.

SHA-1: f35ac300e788db63f4aaa2e2bee0510806deeb4d
(0063641)
git   
2017-02-08 11:40   
Branch CR27691_1 has been deleted by kgv.

SHA-1: efc8b0320955cd593574faf44e0398d657981af0
(0068921)
msv   
2017-07-31 17:31   
The commands chrono and dchrono have been updated but their help has not.
(0068922)
msv   
2017-07-31 17:32   
Please update help of these commands.
(0069463)
abv   
2017-08-16 15:46   
I have created separate issue, 0029004, to address note 0027691:0068922