MantisBT - Open CASCADE
View Issue Details
0027684Open CASCADE[OCCT] OCCT:Codingpublic2016-07-16 14:362016-12-09 16:40
kgv 
bugmaster 
normalintegration request 
closedfixed 
[OCCT] 7.0.0 
[OCCT] 7.1.0[OCCT] 7.1.0 
Not needed
0027684: Coding rules - drop unused declarations from Graphic3d
Graphic3d package contains the following declarations that can be removed:
Graphic3d_TypeOfPolygon
Graphic3d_TypeOfPrimitive
Graphic3d_Array1OfVector.hxx
Graphic3d_Array1OfVertex.hxx
Graphic3d_Array2OfVertex.hxx
Graphic3d_CStructurePtr.hxx
Graphic3d_CycleError.hxx
Graphic3d_DataStructure.pxx
Graphic3d_HSequenceOfStructure.hxx
Graphic3d_InitialisationError.hxx
Graphic3d_ListIteratorOfListOfShortReal.hxx
Graphic3d_ListOfShortReal.hxx
Graphic3d_NListOfHAsciiString.hxx
Graphic3d_CBitFields8.hxx
Graphic3d_CBitFields16.hxx
Graphic3d_CBitFields20.hxx

Graphic3d_CBitFields4.hxx
Graphic3d_StructureManagerPtr.hxx
Graphic3d_StructurePtr.hxx


N/A
No tags attached.
Issue History
2016-07-16 14:36kgvNew Issue
2016-07-16 14:36kgvAssigned To => kgv
2016-07-16 15:58gitNote Added: 0055978
2016-07-16 15:58kgvNote Added: 0055979
2016-07-16 15:58kgvAssigned Tokgv => bugmaster
2016-07-16 15:58kgvStatusnew => resolved
2016-07-16 15:58kgvStatusresolved => reviewed
2016-07-18 17:30apvAssigned Tobugmaster => apv
2016-07-19 14:06apvNote Added: 0056026
2016-07-19 14:06apvAssigned Toapv => kgv
2016-07-19 14:06apvStatusreviewed => assigned
2016-07-19 14:08apvNote Edited: 0056026bug_revision_view_page.php?bugnote_id=56026#r14213
2016-07-19 14:09apvNote Added: 0056027
2016-07-19 14:59gitNote Added: 0056031
2016-07-19 15:02kgvNote Added: 0056033
2016-07-19 15:02kgvAssigned Tokgv => bugmaster
2016-07-19 15:02kgvStatusassigned => resolved
2016-07-19 15:02kgvStatusresolved => reviewed
2016-07-19 16:37apvAssigned Tobugmaster => apv
2016-07-20 13:37apvNote Added: 0056050
2016-07-20 13:37apvAssigned Toapv => kgv
2016-07-20 13:37apvStatusreviewed => assigned
2016-07-20 13:38apvNote Added: 0056051
2016-07-20 13:39apvNote Edited: 0056051bug_revision_view_page.php?bugnote_id=56051#r14228
2016-07-20 13:57gitNote Added: 0056052
2016-07-20 13:58kgvNote Added: 0056053
2016-07-20 13:58kgvAssigned Tokgv => bugmaster
2016-07-20 13:58kgvStatusassigned => resolved
2016-07-20 13:58kgvStatusresolved => reviewed
2016-07-20 17:35apvAssigned Tobugmaster => apv
2016-07-21 08:51apvNote Added: 0056066
2016-07-21 08:51apvAssigned Toapv => bugmaster
2016-07-21 08:51apvStatusreviewed => tested
2016-07-21 08:51apvTest case number => Not needed
2016-07-22 10:23bugmasterChangeset attached => occt master 59ec40f8
2016-07-22 10:23bugmasterStatustested => verified
2016-07-22 10:23bugmasterResolutionopen => fixed
2016-07-22 10:43gitNote Added: 0056096
2016-12-09 16:29aivStatusverified => closed
2016-12-09 16:40aivFixed in Version => 7.1.0

Notes
(0055978)
git   
2016-07-16 15:58   
Branch CR27684 has been created by kgv.

SHA-1: d3caf66f12ef99729a83f0f71d5ad0a69b6d4f8d


Detailed log of new commits:

Author: kgv
Date: Sat Jul 16 15:57:23 2016 +0300

    0027684: Coding rules - drop unused declarations from Graphic3d
    
    The following headers have been removed:
    - Graphic3d_TypeOfPolygon
    - Graphic3d_TypeOfPrimitive
    - Graphic3d_Array1OfVector.hxx
    - Graphic3d_Array1OfVertex.hxx
    - Graphic3d_Array2OfVertex.hxx
    - Graphic3d_CBitFields4.hxx
    - Graphic3d_CBitFields8.hxx
    - Graphic3d_CBitFields16.hxx
    - Graphic3d_CBitFields20.hxx
    - Graphic3d_CStructurePtr.hxx
    - Graphic3d_CycleError.hxx
    - Graphic3d_DataStructure.pxx
    - Graphic3d_HSequenceOfStructure.hxx
    - Graphic3d_InitialisationError.hxx
    - Graphic3d_ListIteratorOfListOfShortReal.hxx
    - Graphic3d_ListOfShortReal.hxx
    - Graphic3d_NListOfHAsciiString.hxx
    - Graphic3d_StructureManagerPtr.hxx
    - Graphic3d_StructurePtr.hxx
    
    Graphic3d_StructureManager - remove default aspects, which have been never used.
(0055979)
kgv   
2016-07-16 15:58   
Please check compilation, regression testing is not needed.
(0056026)
apv   
2016-07-19 14:06   
(edited on: 2016-07-19 14:08)
Dear BugMaster,

Branch CR27684 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms.
SHA-1: d3caf66f12ef99729a83f0f71d5ad0a69b6d4f8d

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1126

Compilation errors have been detected during building of
Qt-based Products samples on Linux:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-master/job/CR27684-master-Products-Debian70-64-qt-samples-linux/1/parsed_console/ [^]
MFC-based OCCT samples on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-master/job/CR27684-master-OCCT-Windows-64-VC10-mfc-samples/2/parsed_console/ [^]
C# Products sample on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-master/job/CR27684-master-Products-Windows-64-VC10-csharp-samples/1/parsed_console/ [^]
Java Products sample on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-master/job/CR27684-master-Products-Windows-64-VC10-java-samples/1/parsed_console/ [^]
MFC-based Products samples on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-master/job/CR27684-master-Products-Windows-64-VC10-mfc-samples/1/parsed_console/ [^]
Qt-based Products samples on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-master/job/CR27684-master-Products-Windows-64-VC10-qt-samples-windows/1/parsed_console/ [^]

(0056027)
apv   
2016-07-19 14:09   
Dear Kirill,

Branch CR26684 has been rejected due to:
- compilation errors
(0056031)
git   
2016-07-19 14:59   
Branch CR27684 has been updated by kgv.

SHA-1: ad53ce898ab69c8a1f3432d67263a106fc5d7d07


Detailed log of new commits:

Author: kgv
Date: Tue Jul 19 15:00:16 2016 +0300

    do not include non-existing header Graphic3d_Array1OfVertex.hxx from MFC sample

(0056033)
kgv   
2016-07-19 15:02   
Please check OCCT/Products samples on updated branch CR27684 (occt and products); occt itself was not modified.
(0056050)
apv   
2016-07-20 13:37   
Dear BugMaster,

Branch CR27684 from occt git-repository (and CR27684 from products git-repository) was compiled on Linux, MacOS and Windows platforms.
SHA-1: ad53ce898ab69c8a1f3432d67263a106fc5d7d07
SHA-1: ab4324c18ed67f6c114a367824bf30008fbc1bcf

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1118

Compilation errors have been detected during building of
C# Products sample on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-CR27684/job/CR27684-CR27684-Products-Windows-64-VC10-csharp-samples/2/parsed_console/ [^]
Java Products sample on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR27684-CR27684/job/CR27684-CR27684-Products-Windows-64-VC10-java-samples/2/parsed_console/ [^]
(0056051)
apv   
2016-07-20 13:38   
(edited on: 2016-07-20 13:39)
Dear Kirill,

Branches CR27684 from occt git-repository and CR27684 from products git-repository have been rejected due to:
- compilation errors

(0056052)
git   
2016-07-20 13:57   
Branch CR27684 has been updated by kgv.

SHA-1: 6f228083fefce00f9df03099890bf37638a41530


Detailed log of new commits:

Author: kgv
Date: Wed Jul 20 13:58:27 2016 +0300

    Graphic3d_Group::MinMaxValues() - add missing Standard_EXPORT

(0056053)
kgv   
2016-07-20 13:58   
Updated patch should fix the issue - please check compilation.
(0056066)
apv   
2016-07-21 08:51   
Dear BugMaster,

Branch CR27684 from occt git-repository (and CR27684 from products git-repository) was compiled on Linux, MacOS and Windows platforms.
SHA-1: 6f228083fefce00f9df03099890bf37638a41530
SHA-1: ab4324c18ed67f6c114a367824bf30008fbc1bcf

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1152
(0056096)
git   
2016-07-22 10:43   
Branch CR27684 has been deleted by inv.

SHA-1: 6f228083fefce00f9df03099890bf37638a41530