MantisBT - Open CASCADE
View Issue Details
0027638Open CASCADE[OCCT] OCCT:Testspublic2016-06-24 16:282016-12-09 16:38
bugmaster 
bugmaster 
normalminor 
closedfixed 
 
[OCCT] 7.1.0[OCCT] 7.1.0 
Not needed
0027638: Optimisation of testdiff command
Preamble:
testdiff command executed during 25-30 minutes.
Images, memory and cup is compared with reference data simultaneously.
It is suggested to add additional option to this command
-images - only images are compared
-memory - only memory are compared
-cpu - only cpu is compared.
It will allow :
1. Launch process of comparison in parallel (decreasing time of execution)
2. Tests are launched in parallel , one per processor core (usually 4). It caused incorrect deviation of CPU time. It is suggested to distinguish cpu comparison in separate process with following restart test cases with critical increasing of cpu time in one stream with re-comparison new result. Thus we could report more objective results of cpu increasing.
testdiff dir1 dir2 -image -cpu -memory
No tags attached.
Issue History
2016-06-24 16:28bugmasterNew Issue
2016-06-24 16:28bugmasterAssigned To => abv
2016-06-24 16:29bugmasterNote Added: 0055452
2016-06-24 16:29bugmasterStatusnew => feedback
2016-07-12 10:37bugmasterAssigned Toabv => apn
2016-07-13 18:18gitNote Added: 0055889
2016-07-13 18:24apnNote Added: 0055890
2016-07-13 18:25apnNote Added: 0055891
2016-07-13 18:27apnTest case number => Not needed
2016-07-13 18:27apnAssigned Toapn => abv
2016-07-13 18:27apnStatusfeedback => resolved
2016-07-13 18:27apnSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14170#r14170
2016-07-14 07:23abvNote Added: 0055900
2016-07-14 07:23abvAssigned Toabv => bugmaster
2016-07-14 07:23abvStatusresolved => reviewed
2016-07-14 11:24bugmasterStatusreviewed => tested
2016-07-15 10:44bugmasterChangeset attached => occt master 28cab376
2016-07-15 10:44bugmasterStatustested => verified
2016-07-15 10:44bugmasterResolutionopen => fixed
2016-07-22 10:44gitNote Added: 0056107
2016-12-09 16:31aivStatusverified => closed
2016-12-09 16:38aivFixed in Version => 7.1.0

Notes
(0055452)
bugmaster   
2016-06-24 16:29   
Dear ABV
What do you think about this idea?
(0055889)
git   
2016-07-13 18:18   
Branch CR27638 has been created by apn.

SHA-1: 09bb5143bf7c0e15fccc44140ad35253caa45eb4


Detailed log of new commits:

Author: apn
Date: Wed Jul 13 18:18:50 2016 +0300

    0027638: Optimisation of testdiff command
    
    Added functionality to compare image, memory and CPU differences separately.
(0055890)
apn   
2016-07-13 18:24   
Additional options (-image, -cpu, -memory) to launch only image, memory or CPU comparison were added. Each option saves result in specified file which can be determined by user (or has default value).
Example:
testdiff dir1 dir2 -image D:/branch/imagediff.log -cpu D:/branch/cpudiff.log -memory D:/branch/memorydiff.log

If there're no any options (testdiff dir1 dir2) log and html files will be saved as usual in one file.
(0055891)
apn   
2016-07-13 18:25   
Dear abv, please review CR27638.
(0055900)
abv   
2016-07-14 07:23   
OK, please proceed.

One general remark: in Tcl, instead of comparing logical variable with value "true" or "false", you can simply use this variable as condition. For instance, instead of

if { $memory == false } {...}

you can put

if { ! $memory } {...}

This is easier to comprehend and also will handle other variants of defining logical variable:
true: "true", "t", or any non-zero integer or real
false: "false", "f", or zero
 
(0056107)
git   
2016-07-22 10:44   
Branch CR27638 has been deleted by inv.

SHA-1: 09bb5143bf7c0e15fccc44140ad35253caa45eb4