MantisBT - Open CASCADE
View Issue Details
0027591Open CASCADE[OCCT] OCCT:Visualizationpublic2016-06-10 14:452016-12-09 16:37
apl 
bugmaster 
normalminor 
closedfixed 
WindowsVC++ 201064 bit
[OCCT] 7.0.0 
[OCCT] 7.1.0[OCCT] 7.1.0 
Not needed
0027591: TKViewerTest, ViewerTest_CmdParser regression - methods ArgVec3f, ArgVec3d return inccorect values
The regression has been found on current development version.

The code of parser methods should address valid value component via "theArgumentIndex" with offset index, e.g.:

Graphic3d_Vec3 ViewerTest_CmdParser::ArgVec3f (const std::string& theOptionName, Standard_Integer theArgumentIndex)
{
  return Graphic3d_Vec3 (static_cast<Standard_ShortReal> (Draw::Atof (Arg (theOptionName, theArgumentIndex + 0).c_str())),
                         static_cast<Standard_ShortReal> (Draw::Atof (Arg (theOptionName, theArgumentIndex + 1).c_str())),
                         static_cast<Standard_ShortReal> (Draw::Atof (Arg (theOptionName, theArgumentIndex + 2).c_str())));
}

Now the offset index is missing and the argument values are interpreted improperly for DRAW commands "vmanipulator" and "vbsdf".
Not required
No tags attached.
Issue History
2016-06-10 14:45aplNew Issue
2016-06-10 14:45aplAssigned To => apl
2016-06-10 14:46aplRelationship addedrelated to 0027038
2016-06-10 16:35gitNote Added: 0054917
2016-06-10 16:35aplStatusnew => assigned
2016-06-10 16:35aplNote Added: 0054918
2016-06-10 16:35aplAssigned Toapl => dbp
2016-06-10 16:35aplStatusassigned => resolved
2016-06-10 16:35aplSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13892#r13892
2016-06-10 21:59kgvNote Added: 0054927
2016-06-10 21:59kgvAssigned Todbp => bugmaster
2016-06-10 21:59kgvStatusresolved => reviewed
2016-06-14 13:08mkvAssigned Tobugmaster => mkv
2016-06-15 14:26mkvNote Added: 0055018
2016-06-15 14:26mkvNote Added: 0055020
2016-06-15 14:26mkvAssigned Tomkv => bugmaster
2016-06-15 14:26mkvStatusreviewed => tested
2016-06-15 14:26mkvTest case number => Not needed
2016-06-17 12:04bugmasterChangeset attached => occt master 907fb7a5
2016-06-17 12:04bugmasterStatustested => verified
2016-06-17 12:04bugmasterResolutionopen => fixed
2016-06-17 12:13gitNote Added: 0055141
2016-12-09 16:31aivStatusverified => closed
2016-12-09 16:37aivFixed in Version => 7.1.0

Notes
(0054917)
git   
2016-06-10 16:35   
Branch CR27591 has been created by apl.

SHA-1: f39d0001282f49d635a0227fc914c36bd053f5be


Detailed log of new commits:

Author: apl
Date: Fri Jun 10 16:35:00 2016 +0300

    0027591: TKViewerTest, ViewerTest_CmdParser regression - methods ArgVec3f, ArgVec3d return inccorect values
    
    Fix regression in methods ViewerTest_CmdParser::ArgVec3f, ::ArgVec3d, ::ArgVec, ::ArgPnt.
(0054918)
apl   
2016-06-10 16:35   
Dear Denis,

Could you please review the branch CR27591?
(0054927)
kgv   
2016-06-10 21:59   
Please test the patch.
(0055018)
mkv   
2016-06-15 14:26   
Dear BugMaster,
Branch CR27591 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: f39d0001282f49d635a0227fc914c36bd053f5be

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 72 (72 on master)
Windows: 4 (4 on master)
MacOS : 1128

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 88433483 / 88301575 [+0.15%]
Total CPU difference: 19486.879999999906 / 19439.919999999966 [+0.24%]
products component :
Total MEMORY difference: 27622383 / 27641722 [-0.07%]
Total CPU difference: 5166.139999999992 / 5152.139999999989 [+0.27%]

Testing on Windows:
occt component :
Total MEMORY difference: 55955583 / 55983280 [-0.05%]
Total CPU difference: 18128.517407698822 / 19056.302154998906 [-4.87%]
products component :
Total MEMORY difference: 18749007 / 18714258 [+0.19%]
Total CPU difference: 4955.80856779995 / 5090.484231099957 [-2.65%]

There are no differences in images found by testdiff.
(0055020)
mkv   
2016-06-15 14:26   
Dear BugMaster,
Branch CR27591 is TESTED.
(0055141)
git   
2016-06-17 12:13   
Branch CR27591 has been deleted by inv.

SHA-1: f39d0001282f49d635a0227fc914c36bd053f5be