MantisBT - Open CASCADE
View Issue Details
0027310Open CASCADE[OCCT] OCCT:Modeling Algorithmspublic2016-03-28 09:332016-12-09 16:37
emv 
bugmaster 
normalminor 
closedfixed 
[OCCT] 7.0.0 
[OCCT] 7.1.0[OCCT] 7.1.0 
bugs modalg_6 bug27310_1, bug27310_2
0027310: Huge tolerance obtained in the result of intersection of two cylindrical faces
The result of intersection of two attached cylindrical faces has a huge tolerance.
The intersection tolerance obtained in version 680 of OCCT is OK, about 5.05e-7.

The problem has been discovered during analysis of the test case bugs moddata_2 bug496
Test case has already been created and pushed to the branch.

restore bug496_faces.brep cf
explode cf
bopcurves cf_1 cf_2 -2d
# Tolerance Reached=28.00037987240534

restore bug496_faces_2.brep cf
explode cf
bopcurves cf_1 cf_2 -2d
# Tolerance Reached=30.005183963106642
No tags attached.
duplicate of 0026771closed bugmaster Boolean intersection gives too large reached tolerance 
? bug496_faces.brep (3,935) 2016-03-28 09:33
https://tracker.dev.opencascade.org/
? bug496_faces_2.brep (3,382) 2016-03-28 09:45
https://tracker.dev.opencascade.org/
Issue History
2016-03-28 09:33emvNew Issue
2016-03-28 09:33emvAssigned To => msv
2016-03-28 09:33emvFile Added: bug496_faces.brep
2016-03-28 09:37msvAssigned Tomsv => nbv
2016-03-28 09:37msvStatusnew => assigned
2016-03-28 09:37msvProduct Version7.1.0 => 7.0.0
2016-03-28 09:45emvNote Added: 0052048
2016-03-28 09:45emvFile Added: bug496_faces_2.brep
2016-03-28 09:46emvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13312#r13312
2016-04-08 14:34nbvRelationship addedduplicate of 0026771
2016-04-11 09:18gitNote Added: 0052559
2016-04-11 09:19nbvNote Added: 0052560
2016-04-11 09:19nbvAssigned Tonbv => msv
2016-04-11 09:19nbvStatusassigned => resolved
2016-04-11 09:19nbvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13430#r13430
2016-04-27 16:21msvNote Added: 0053639
2016-04-27 16:21msvStatusresolved => assigned
2016-04-27 16:22msvAssigned Tomsv => nbv
2016-04-27 16:28gitNote Added: 0053641
2016-04-27 16:28nbvNote Added: 0053642
2016-04-27 16:28nbvAssigned Tonbv => msv
2016-04-27 16:28nbvStatusassigned => resolved
2016-04-27 16:30msvNote Added: 0053645
2016-04-27 16:30msvAssigned Tomsv => bugmaster
2016-04-27 16:30msvStatusresolved => reviewed
2016-04-27 16:37mkvAssigned Tobugmaster => mkv
2016-04-28 15:14mkvNote Added: 0053677
2016-04-28 15:14mkvNote Added: 0053678
2016-04-28 15:14mkvAssigned Tomkv => bugmaster
2016-04-28 15:14mkvStatusreviewed => tested
2016-04-28 15:15mkvTest case number => bugs modalg_6 bug27310_1, bug27310_2
2016-04-29 16:10bugmasterChangeset attached => occt master 79997052
2016-04-29 16:10bugmasterStatustested => verified
2016-04-29 16:10bugmasterResolutionopen => fixed
2016-05-20 12:22gitNote Added: 0054199
2016-12-09 16:31aivStatusverified => closed
2016-12-09 16:37aivFixed in Version => 7.1.0

Notes
(0052048)
emv   
2016-03-28 09:45   
One more pair of faces with the same problem has been found in the same test case.
(0052559)
git   
2016-04-11 09:18   
Branch CR27310 has been created by nbv.

SHA-1: c3712e63ff7bb90eb41501779e60618dc1e894c2


Detailed log of new commits:

Author: nbv
Date: Thu Apr 7 13:53:57 2016 +0300

    0027310: Huge tolerance obtained in the result of intersection of two cylindrical faces
    
    Sometimes start point of the intersection line is in the surface boundary strictly. I.e. the parameter of this point in the surface can be equal to both 0 or 2*PI equivalently. It is important to chose correct parameter value.
    
    The algorithm of prediction is based on monotonicity property (see CylCylMonotonicity(...) function in IntPatch_ImpImpIntersection_4.gxx). Now, this function is used wrongly. The fix improves this situation.
    
    Small optimization in the code.
    Creation of test cases .
(0052560)
nbv   
2016-04-11 09:19   
Dear Mikhail,

Please review CR27310 branch.
(0053639)
msv   
2016-04-27 16:21   
Please correct the logic of returning value by the method BoundariesComputing().
(0053641)
git   
2016-04-27 16:28   
Branch CR27310 has been updated forcibly by nbv.

SHA-1: 2ecd80ebcbd4e8c168b4a329e8817d031bc99c9a
(0053642)
nbv   
2016-04-27 16:28   
Dear Mikhail,

Please review the current state of CR27310 branch.
(0053645)
msv   
2016-04-27 16:30   
Reviewed.
(0053677)
mkv   
2016-04-28 15:14   
Dear BugMaster,
Branch CR27310 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 2ecd80ebcbd4e8c168b4a329e8817d031bc99c9a

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 72 (72 on master)
Windows: 4 (4 on master)
MacOS : 1124

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
http://occt-tests/CR27310-master-OCCT/Debian70-64/bugs/modalg_6/bug27310_1.html [^]
http://occt-tests/CR27310-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug27310_1.html [^]
bugs modalg_6 bug27310_1: OK
http://occt-tests/CR27310-master-OCCT/Debian70-64/bugs/modalg_6/bug27310_2.html [^]
http://occt-tests/CR27310-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug27310_2.html [^]
bugs modalg_6 bug27310_2: OK

Testing on Linux:
occt component :
Total MEMORY difference: 88342133 / 88959013 [-0.69%]
Total CPU difference: 19122.64 / 19139.950000000026 [-0.09%]
products component :
Total MEMORY difference: 27942212 / 27891155 [+0.18%]
Total CPU difference: 5366.989999999994 / 5370.249999999996 [-0.06%]

Testing on Windows:
occt component :
Total MEMORY difference: 55686826 / 55717599 [-0.06%]
Total CPU difference: 18626.987402998813 / 17772.835127698927 [+4.81%]
products component :
Total MEMORY difference: 19062934 / 19031321 [+0.17%]
Total CPU difference: 5210.527000599963 / 5185.613640899959 [+0.48%]

There are no differences in images found by testdiff.
(0053678)
mkv   
2016-04-28 15:14   
Dear BugMaster,
Branch CR27310 is TESTED.

(0054199)
git   
2016-05-20 12:22   
Branch CR27310 has been deleted by inv.

SHA-1: 2ecd80ebcbd4e8c168b4a329e8817d031bc99c9a