MantisBT - Community
View Issue Details
0027092Community[OCCT] OCCT:Codingpublic2016-01-20 09:172019-11-22 18:36
Epy 
abv 
normaltrivial 
closedfixed 
Lubuntu 15.10 x64
[OCCT] 7.0.0 
[OCCT] 7.0.0[OCCT] 7.0.0 
Not needed
0027092: Coding - src/BRep/BRep_Tool.hxx extra semicolon triggers annoying warnings on Clang
Clang tends to be overly verbose with warnings, and the extra semicolon at the beginning of src/BRep/BRep_Tool.hxx creates a large amount of extra warning text (this is repeated every time this file is referenced):

In file included from /home/jake/opencascade-7.0.0-beta/build/inc/BRep_Tool.hxx:1:0,
                 from /home/jake/opencascade-7.0.0-beta/src/BRep/BRep_Builder.lxx:21,
                 from /home/jake/opencascade-7.0.0-beta/build/inc/BRep_Builder.lxx:1,
                 from /home/jake/opencascade-7.0.0-beta/src/BRep/BRep_Builder.hxx:274,
                 from /home/jake/opencascade-7.0.0-beta/build/inc/BRep_Builder.hxx:1,
                 from /home/jake/opencascade-7.0.0-beta/src/BRepPrim/BRepPrim_Builder.hxx:24,
                 from /home/jake/opencascade-7.0.0-beta/build/inc/BRepPrim_Builder.hxx:1,
                 from /home/jake/opencascade-7.0.0-beta/src/BRepPrim/BRepPrim_OneAxis.hxx:24,
                 from /home/jake/opencascade-7.0.0-beta/build/inc/BRepPrim_OneAxis.hxx:1,
                 from /home/jake/opencascade-7.0.0-beta/src/BRepPrim/BRepPrim_Revolution.hxx:24,
                 from /home/jake/opencascade-7.0.0-beta/build/inc/BRepPrim_Revolution.hxx:1,
                 from /home/jake/opencascade-7.0.0-beta/src/BRepPrim/BRepPrim_Sphere.hxx:25,
                 from /home/jake/opencascade-7.0.0-beta/build/inc/BRepPrim_Sphere.hxx:1,
                 from /home/jake/opencascade-7.0.0-beta/src/BRepPrimAPI/BRepPrimAPI_MakeSphere.hxx:24,
                 from /home/jake/opencascade-7.0.0-beta/build/inc/BRepPrimAPI_MakeSphere.hxx:1,
                 from Ex5_ScaleAndBoundBox.cxx:7:
/home/jake/opencascade-7.0.0-beta/src/BRep/BRep_Tool.hxx:1:1: warning: extra ‘;’ [-Wpedantic]
 ;// Created on: 1993-07-07
 ^

I realize this is a "nit-pick" request, but all that needs to be done is to remove the semi-colon. Clang emits so many warnings, anything that can be done to reduce the text volume is extremely helpful as I look through those warnings. Thanks!
No tags attached.
related to 0027097closed abv Open CASCADE GCC and CLang compiler warnings and errors with -Wpedantic 
related to 0031007closed bugmaster Open CASCADE Coding - eliminate warnings issued while compiling with -pedantic flag 
child of 0026560closed bugmaster Community BRepBndLib build too large bounding box in Z direction for planar spline edge. 
child of 0027105closed abv Community Make code ISO-compliant [-Wpedantic fixes] 
Issue History
2016-01-20 09:17EpyNew Issue
2016-01-20 09:17EpyAssigned To => kgv
2016-01-20 10:23kgvRelationship addedchild of 0026560
2016-01-20 10:24kgvStatusnew => assigned
2016-01-20 10:24kgvProduct Version => 7.0.0
2016-01-20 10:24kgvTarget Version => 7.0.0
2016-01-20 10:24kgvSummary7.0.0 beta: src/BRep/BRep_Tool.hxx extra semicolon triggers annoying warnings on Clang => Coding - src/BRep/BRep_Tool.hxx extra semicolon triggers annoying warnings on Clang
2016-01-20 10:24gitNote Added: 0049959
2016-01-20 10:25kgvNote Added: 0049960
2016-01-20 10:25kgvAssigned Tokgv => bugmaster
2016-01-20 10:25kgvStatusassigned => resolved
2016-01-20 10:25kgvStatusresolved => reviewed
2016-01-20 10:26kgvNote Edited: 0049960bug_revision_view_page.php?bugnote_id=49960#r12777
2016-01-20 13:22mkvAssigned Tobugmaster => mkv
2016-01-20 18:18mkvNote Added: 0049981
2016-01-20 18:18mkvNote Added: 0049982
2016-01-20 18:18mkvAssigned Tomkv => bugmaster
2016-01-20 18:18mkvStatusreviewed => tested
2016-01-20 18:19mkvTest case number => Not needed
2016-01-21 06:52abvRelationship addedrelated to 0027097
2016-01-22 02:37EpyRelationship addedchild of 0027105
2016-01-22 12:17abvChangeset attached => occt master 163d7e8d
2016-01-22 12:17abvAssigned Tobugmaster => abv
2016-01-22 12:17abvStatustested => verified
2016-01-22 12:17abvResolutionopen => fixed
2016-04-17 13:27gitNote Added: 0052869
2016-04-20 15:43aivFixed in Version => 7.0.0
2016-04-20 15:50aivStatusverified => closed
2019-11-22 18:36kgvRelationship addedrelated to 0031007

Notes
(0049959)
git   
2016-01-20 10:24   
Branch CR27092 has been created by kgv.

SHA-1: 917f5d6614817a480d17bd67e5277d41ad6cbd64


Detailed log of new commits:

Author: kgv
Date: Wed Jan 20 10:24:20 2016 +0300

    0027092: Coding - src/BRep/BRep_Tool.hxx extra semicolon triggers annoying warnings on Clang
(0049960)
kgv   
2016-01-20 10:25   
(edited on: 2016-01-20 10:26)
Dear bugmaster,

please check compilation, testing is not needed.

(0049981)
mkv   
2016-01-20 18:18   
Dear BugMaster,
Branch CR27092 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 917f5d6614817a480d17bd67e5277d41ad6cbd64

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 7 (7 on master)

products component :
Linux: 36 (36 on master)
Windows: 0 (0 on master)
(0049982)
mkv   
2016-01-20 18:18   
Dear BugMaster,
Branch CR27092 is TESTED.
(0052869)
git   
2016-04-17 13:27   
Branch CR27092 has been deleted by kgv.

SHA-1: 917f5d6614817a480d17bd67e5277d41ad6cbd64