MantisBT - Open CASCADE
View Issue Details
0026885Open CASCADE[OCCT] OCCT:Visualizationpublic2015-11-17 16:002016-12-09 16:38
kgv 
bugmaster 
normalintegration request 
closedfixed 
[OCCT] 6.5.3 
[OCCT] 7.1.0[OCCT] 7.1.0 
Not needed
0026885: Visualization - drop redundant aspects from structure level
Original quotation from 0023117:

2. Aspects at the level of Graphic3d_Structure and OpenGl_Structure.
Currently, if e.g. a face aspect is defined at structure level, and a group inside this structure also defines a face aspect, then the structure's one is simply ignored. Since it is a common practice to define the necessary aspects at the level of the current group (not at the level of the structure), holding structure aspects is of no use.
No tags attached.
related to 0026612closed bugmaster Community High memory footprint displaying model with big amount of solids 
related to 0027617closed bugmaster Open CASCADE Visualization, TKOpenGl - apply highlighting color without disabling lighting 
parent of 0027717closed bugmaster Open CASCADE Visualization - drop broken Prs3d_Drawer::ShadingAspectGlobal() flag 
child of 0023117closed bugmaster Open CASCADE TKV3d and TKOpenGl code clean-up 
Issue History
2015-11-17 16:00kgvNew Issue
2015-11-17 16:00kgvAssigned To => kgv
2015-11-17 16:00kgvRelationship addedchild of 0023117
2016-06-16 23:26gitNote Added: 0055115
2016-06-16 23:27kgvNote Added: 0055116
2016-06-16 23:27kgvAssigned Tokgv => san
2016-06-16 23:27kgvSeverityminor => integration request
2016-06-16 23:27kgvStatusnew => resolved
2016-06-17 10:30gitNote Added: 0055123
2016-06-17 11:16gitNote Added: 0055125
2016-06-17 14:46sanNote Added: 0055175
2016-06-17 14:46sanAssigned Tosan => bugmaster
2016-06-17 14:46sanStatusresolved => reviewed
2016-06-17 15:05kgvRelationship addedrelated to 0026612
2016-06-17 15:25apvAssigned Tobugmaster => apv
2016-06-20 16:26apvNote Added: 0055240
2016-06-20 16:26apvAssigned Toapv => kgv
2016-06-20 16:26apvStatusreviewed => assigned
2016-06-20 16:26apvNote Edited: 0055240bug_revision_view_page.php?bugnote_id=55240#r14008
2016-06-20 16:28apvNote Added: 0055241
2016-06-20 19:05gitNote Added: 0055259
2016-06-20 19:10gitNote Added: 0055260
2016-06-20 19:14kgvRelationship addedrelated to 0027617
2016-06-20 19:40kgvNote Added: 0055267
2016-06-20 19:40kgvAssigned Tokgv => bugmaster
2016-06-20 19:40kgvStatusassigned => resolved
2016-06-20 19:40kgvStatusresolved => reviewed
2016-06-21 11:12apvAssigned Tobugmaster => apv
2016-06-22 11:00apvTest case number => Not needed
2016-06-22 11:02apvNote Added: 0055326
2016-06-22 11:02apvAssigned Toapv => bugmaster
2016-06-22 11:02apvStatusreviewed => tested
2016-06-24 12:41bugmasterChangeset attached => occt master 2831708b
2016-06-24 12:41bugmasterStatustested => verified
2016-06-24 12:41bugmasterResolutionopen => fixed
2016-06-24 12:57gitNote Added: 0055419
2016-06-24 12:57gitNote Added: 0055420
2016-07-27 16:44kgvRelationship addedparent of 0027717
2016-12-09 16:31aivStatusverified => closed
2016-12-09 16:38aivFixed in Version => 7.1.0

Notes
(0055115)
git   
2016-06-16 23:26   
Branch CR26885 has been created by kgv.

SHA-1: e17ea5d2fc29dc2ad399b457d92a7c53e8eb23f5


Detailed log of new commits:

Author: kgv
Date: Thu Jun 16 23:26:19 2016 +0300

    0026885: Visualization - drop redundant aspects from structure level
    
    Graphic3d_CStructure and OpenGl_Structure do not store structure aspects anymore.
    Graphic3d_Structure, Prs3d_Presentation - structure aspect methods have been removed.
    
    AIS_InteractiveObject::SetAspect() - globalChange argument has been removed.
    
    Undocumented test methods V3d::DrawSphere(), ::SetPlane(), ::PickGrid() have been removed.
(0055116)
kgv   
2016-06-16 23:27   
Patch is ready for review.
(0055123)
git   
2016-06-17 10:30   
Branch CR26885 has been updated forcibly by kgv.

SHA-1: 02204e375a077585e82dd494090b6ae77d0aa984
(0055125)
git   
2016-06-17 11:16   
Branch CR26885 has been updated forcibly by kgv.

SHA-1: da779162cbbbc2cd216e89882f9b064198e3aa9c
(0055175)
san   
2016-06-17 14:46   
Branch CR26885 reviewed without remarks, ready for testing.
(0055240)
apv   
2016-06-20 16:26   
Dear BugMaster,

Branch CR26885 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: da779162cbbbc2cd216e89882f9b064198e3aa9c

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 68
   Windows: 0
   MacOS: 1119

Regressions/Differences:
http://occt-tests/CR26885-master-OCCT/Debian70-64/summary.html [^]
http://occt-tests/CR26885-master-OCCT/Windows-64-VC10/summary.html [^]
bugs vis bug23067, bug26754, bug26975

Testing on Linux:
Total MEMORY difference: 89671289 / 89135419 [+0.60%]
Total CPU difference: 19427.789999999997 / 19457.88999999997 [-0.15%]

Testing on Windows:
Total MEMORY difference: 55860575 / 55898813 [-0.07%]
Total CPU difference: 18441.205812098793 / 18535.524016698953 [-0.51%]

There are differences in images found by testdiff:
http://occt-tests/CR26885-master-OCCT/Debian70-64/diff-Debian70-64.html [^]
http://occt-tests/CR26885-master-OCCT/Windows-64-VC10/diff-Windows-64-VC10.html [^]
v3d point_cloud sphere

(0055241)
apv   
2016-06-20 16:28   
Dear Kirill,

Branch CR26885 has been rejected due to:
- regressions/differences/improvements
- differences in images
(0055259)
git   
2016-06-20 19:05   
Branch CR26885 has been updated by kgv.

SHA-1: 3d23d8a36a27fbcbbf3954eaf88cdb34b15cd8da


Detailed log of new commits:

Author: kgv
Date: Mon Jun 20 18:56:30 2016 +0300

    AIS_PointCloud now sets up ShadingAspect within Compute()
    and does not override PointAspect of global drawer.
    ViewerTest now sets group aspect within vuserdraw and vdrawparray.

(0055260)
git   
2016-06-20 19:10   
Branch CR26885_1 has been created by kgv.

SHA-1: 0da88b20899dcd481230237bda9c6bbcd53d6f29


Detailed log of new commits:

Author: kgv
Date: Mon Jun 20 19:10:51 2016 +0300

    0026885: Visualization - drop redundant aspects from structure level
    
    Graphic3d_CStructure and OpenGl_Structure do not store structure aspects anymore.
    Graphic3d_Structure, Prs3d_Presentation - structure aspect methods have been removed.
    
    AIS_InteractiveObject::SetAspect() - globalChange argument has been removed.
    
    Undocumented test methods V3d::DrawSphere(), ::SetPlane(), ::PickGrid() have been removed.
(0055267)
kgv   
2016-06-20 19:40   
Regressions should be fixed within updated patch CR26885_.
(0055326)
apv   
2016-06-22 11:02   
Dear BugMaster,

Branch CR26885_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 0da88b20899dcd481230237bda9c6bbcd53d6f29

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MacOS: 0 (0 on master)
products component:
   Linux: 68
   Windows: 0
   MacOS: 1140

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 88723219 / 89129632 [-0.46%]
Total CPU difference: 19421.43000000002 / 19458.48999999997 [-0.19%]

Testing on Windows:
Total MEMORY difference: 55859943 / 55904007 [-0.08%]
Total CPU difference: 18101.73203599882 / 18535.836018698956 [-2.34%]
(0055419)
git   
2016-06-24 12:57   
Branch CR26885_1 has been deleted by inv.

SHA-1: 0da88b20899dcd481230237bda9c6bbcd53d6f29
(0055420)
git   
2016-06-24 12:57   
Branch CR26885 has been deleted by inv.

SHA-1: 3d23d8a36a27fbcbbf3954eaf88cdb34b15cd8da