MantisBT - Community
View Issue Details
0026799Community[OCCT] OCCT:Documentationpublic2015-10-22 10:382016-04-20 15:51
Vico Liang 
bugmaster 
normalmajor 
closedfixed 
[OCCT] 6.9.1 
[OCCT] 7.0.0[OCCT] 7.0.0 
Not needed
0026799: NCollection_Array2's RowLength and ColLength return wrong value.
Please see the implementation of these two methods RowLength and ColLength:
The RowLength() returns the column length value while ColLength() returns the row length value.

Please swap these two method implementation codes to fix the isue.

  //! RowLength
  Standard_Integer RowLength (void) const
  { return (myUpperCol-myLowerCol+1); }
  //! ColLength
  Standard_Integer ColLength (void) const
  { return (myUpperRow-myLowerRow+1); }
N/A
No tags attached.
Issue History
2015-10-22 10:38Vico LiangNew Issue
2015-10-22 10:38Vico LiangAssigned To => abv
2015-10-23 22:14abvRelationship addedrelated to 0015125
2015-10-23 22:29abvNote Added: 0047409
2015-10-24 08:01gitNote Added: 0047411
2015-10-24 08:02abvNote Added: 0047412
2015-10-24 08:02abvAssigned Toabv => Vico Liang
2015-10-24 08:02abvStatusnew => resolved
2015-10-24 08:02abvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11958#r11958
2015-10-24 15:22Vico LiangNote Added: 0047418
2015-10-24 15:26Vico LiangAssigned ToVico Liang => abv
2015-10-24 16:54abvNote Added: 0047420
2015-10-24 16:54abvAssigned Toabv => bugmaster
2015-10-24 16:54abvStatusresolved => reviewed
2015-10-24 18:26abvCategoryOCCT:Foundation Classes => OCCT:Documentation
2015-10-26 12:12apvTest case number => Not needed
2015-10-26 12:12apvStatusreviewed => tested
2015-10-30 16:00bugmasterChangeset attached => occt master 9535c4be
2015-10-30 16:00bugmasterStatustested => verified
2015-10-30 16:00bugmasterResolutionopen => fixed
2016-04-17 14:35gitNote Added: 0053203
2016-04-20 15:42aivFixed in Version => 7.0.0
2016-04-20 15:51aivStatusverified => closed

Notes
(0047409)
abv   
2015-10-23 22:29   
Hello Vico,

I guess you may be confused by names of these methods: "RowLength" means length of the row (nb. of columns), and not nb. of rows, as you probably expect. Consider array of 2 rows, 3 columns:

Array1 (1, 2, 1, 3);

11 12 13
21 22 23

Here RowLength() should return 3, and ColLength() should be 2.
(0047411)
git   
2015-10-24 08:01   
Branch CR26799 has been created by abv.

SHA-1: 7a27a25ebd8846694f56a6e6e624e87c453851ba


Detailed log of new commits:

Author: abv
Date: Sat Oct 24 08:00:58 2015 +0300

    0026799: NCollection_Array2's RowLength and ColLength return wrong value.
    
    Comments to methods RowLength() and ColLength() improved to avoid possible misinterpretation
(0047412)
abv   
2015-10-24 08:02   
I have improved comments to these methods to avoid such kind of confusion, please review
(0047418)
Vico Liang   
2015-10-24 15:22   
Dear abv,

Right that i'm confused. The improved comments is clear for these two methods. Thanks for the improvement.
(0047420)
abv   
2015-10-24 16:54   
Please integrate, no testing is needed
(0053203)
git   
2016-04-17 14:35   
Branch CR26799 has been deleted by kgv.

SHA-1: 7a27a25ebd8846694f56a6e6e624e87c453851ba